WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 4 days ago

#45211 closed theme (closed-newer-version-uploaded)

THEME: Ariel – 1.0.2

Reported by: lyrathemes Owned by: gookaani
Priority: new theme Keywords: theme-ariel
Cc: webmaster@…

Description

Ariel - 1.0.0

Ariel Pro is a simple but feature-filled blogging WordPress theme.

Theme URL - https://www.lyrathemes.com/ariel/
Author URL - https://www.lyrathemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/ariel/1.0.0

SVN - https://themes.svn.wordpress.org/ariel/1.0.0
ZIP - https://wordpress.org/themes/download/ariel.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#45211 THEME: Ariel – 1.0.2 closed closed-newer-version-uploaded gookaani

(this ticket)

#47322 THEME: Ariel – 1.0.3 reviewing gookaani


https://themes.svn.wordpress.org/ariel/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are ariel, kirki

Change History (27)

#1 @themetracbot
3 months ago

  • Summary changed from THEME: Ariel – 1.0.0 to THEME: Ariel – 1.0.1

Ariel - 1.0.1

Ariel Pro is a simple but feature-filled blogging WordPress theme.

Theme URL - https://www.lyrathemes.com/ariel/
Author URL - https://www.lyrathemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/ariel/1.0.1

SVN - https://themes.svn.wordpress.org/ariel/1.0.1
ZIP - https://wordpress.org/themes/download/ariel.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=ariel/1.0.0&new_path=ariel/1.0.1

History:

Ticket Summary Status Resolution Owner
#45211 THEME: Ariel – 1.0.2 closed closed-newer-version-uploaded gookaani

(this ticket)

#47322 THEME: Ariel – 1.0.3 reviewing gookaani


https://themes.svn.wordpress.org/ariel/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are ariel, kirki

#2 @themetracbot
3 months ago

  • Summary changed from THEME: Ariel – 1.0.1 to THEME: Ariel – 1.0.2

Ariel - 1.0.2

Ariel Pro is a simple but feature-filled blogging WordPress theme.

Theme URL - https://www.lyrathemes.com/ariel/
Author URL - https://www.lyrathemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/ariel/1.0.2

SVN - https://themes.svn.wordpress.org/ariel/1.0.2
ZIP - https://wordpress.org/themes/download/ariel.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=ariel/1.0.1&new_path=ariel/1.0.2

History:

Ticket Summary Status Resolution Owner
#45211 THEME: Ariel – 1.0.2 closed closed-newer-version-uploaded gookaani

(this ticket)

#47322 THEME: Ariel – 1.0.3 reviewing gookaani


https://themes.svn.wordpress.org/ariel/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are ariel, kirki

#3 @themetracbot
3 weeks ago

  • Owner set to ooppx
  • Status changed from new to reviewing

#4 @ooppx
3 weeks ago

I'll be reviewing your theme in the next few days, thanks!

#5 @lyrathemes
2 weeks ago

Thanks for your time. I look forward to the review. When can I expect something?

#6 @lyrathemes
2 weeks ago

Hello @ooppx

Can you give me an ETA on the theme review please? Would love to move forward with this :)

Thank you for your time!

This ticket was mentioned in Slack in #themereview by mutantspinach. View the logs.


2 weeks ago

#8 @jcastaneda
2 weeks ago

  • Owner ooppx deleted

Putting back in the queue.

#9 @themetracbot
13 days ago

  • Owner set to antonies

#10 @antonies
13 days ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

this theme has 5+ different problems. Please correct the alert with plugin nc theme check please resend

#11 @antonies
13 days ago

https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]

This ticket was mentioned in Slack in #themereview by mutantspinach. View the logs.


13 days ago

#13 @williampatton
13 days ago

Hi,

@antonies could you post the list of 5+ issues for the author to see so that they know specifically what needs looked at to move forward? Thank you

#14 @grapplerulrich
13 days ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#15 @grapplerulrich
13 days ago

  • Owner antonies deleted
  • Status changed from reopened to reviewing

#16 @lyrathemes
13 days ago

For the next reviewer:

These are the errors the sniffer throws up:

ariel/woocommerce/single-product/up-sells.php
37	ERROR	Overriding WordPress globals is prohibited

ariel/woocommerce/single-product/related.php
35	ERROR	Overriding WordPress globals is prohibited

ariel/woocommerce/loop/result-count.php

41	ERROR	Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
44	ERROR	Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

ariel/woocommerce/checkout/form-coupon.php
27	ERROR	Only variables can be passed to empty() prior to PHP 5.5.

ariel/inc/kirki/core/class-kirki-helper.php
34	ERROR	The function array_replace_recursive() is not present in PHP version 5.2 or earlier

The first 4 are all from WooCommerce templates, and the code is exactly the same as what it is in the official plugin.

I tested at PHP ver 5.2 (Minimum PHP Version) which is what the last error refers to. It is also a part of the Kirki library which we've included as-is.

No issues with the *theme* found.

This ticket was mentioned in Slack in #themereview by mutantspinach. View the logs.


13 days ago

#18 @themetracbot
13 days ago

  • Owner set to arfanmahmood

#19 @grapplerulrich
12 days ago

I can confirm that the two PHP version issues are false positives.

@lyrathemes You could improve the strings in result-count.php and open a PR for them in WooCommerce.

For "Overriding WordPress globals is prohibited" we can make an exception in this case.

#20 @lyrathemes
12 days ago

@grapplerulrich You got it, I'll get a ticket over to WooCommerce.

Could you review the theme? Or should I wait for @arfanmahmood?

#21 @rabmalin
9 days ago

  • Owner arfanmahmood deleted

Returning ticket back to review queue for new reviewer.

#22 @themetracbot
8 days ago

  • Owner set to gookaani

#23 @gookaani
8 days ago

@lyrathemes

Reviewers are now allowed to close the ticket if your theme has more than 5+ distinct issues, so make sure your theme developed based on org's handbook.
https://make.wordpress.org/themes/handbook/review/required/

If you want to update the theme, update within 48 hours, or else I'll start to review the latest version of the theme.

#24 @lyrathemes
8 days ago

Thanks @gookaani - I look forward to your review. Thanks for your time!

#25 @gookaani
5 days ago

Hello @lyrathemes

*REQUIRED: Declare copyright of your theme like the example below in readme.txt file

== Copyright ==

Theme name WordPress Theme, Copyright 2016 Company
Theme name is distributed under the terms of the GNU GPL

*REQUIRED: Documentation page URL on Customizer goes to 404 and needs to be fixed or removed.

*REQUIRED: Header image license/credit is missing.

*REQUIRED: Theme contains outdated copies of some WooCommerce template files.

*REQUIRED: Missing language folder and translate file.

*WARNING: wp-content/themes/ariel/inc/helper-functions.php:60 - array_rand() expects parameter 1 to be array, null given

require('wp-blog-header.php'),
require_once('wp-includes/template-loader.php'),
include('/themes/ariel/single.php'),
get_template_part,
locate_template,
load_template,
require('/themes/ariel/parts/entry.php'),
ariel_entry_thumbnail,
ariel_get_sample,
array_rand

*NOTICE: wp-content/themes/ariel/inc/template-tags.php:153 - Undefined variable: separator

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/ariel/front-page.php'), get_template_part, locate_template, load_template, require('/themes/ariel/parts/feed.php'), get_template_part, locate_template, load_template, require('/themes/ariel/parts/blog-grid.php'), get_template_part, locate_template, load_template, require('/themes/ariel/parts/entry-grid.php'), ariel_entry_comments_link

*NOTICE: wp-content/themes/ariel/inc/helper-functions.php:59 - Undefined index: ariel-slider-fs

require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), include('/themes/ariel/single.php'), get_template_part, locate_template, load_template, require('/themes/ariel/parts/entry.php'), ariel_entry_thumbnail, ariel_get_sample

#26 @lyrathemes
4 days ago

@gookaani Thanks for the review. I've made all the requested changes.

https://themes.trac.wordpress.org/ticket/47322

#27 @rabmalin
4 days ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.