WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 2 months ago

#45221 closed theme (closed-newer-version-uploaded)

THEME: Kuva – 1.0.2

Reported by: sitecreateio Owned by: samuelguebo
Priority: new theme Keywords: theme-kuva
Cc: hello@…

Description

Kuva - 1.0.0

A clean and simple blogging theme.

Theme URL - http://demo.sitecreate.io/kuva/
Author URL - https://www.sitecreate.io

Trac Browser - https://themes.trac.wordpress.org/browser/kuva/1.0.0

SVN - https://themes.svn.wordpress.org/kuva/1.0.0
ZIP - https://wordpress.org/themes/download/kuva.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#45221 THEME: Kuva – 1.0.2 closed closed-newer-version-uploaded samuelguebo

(this ticket)

#47289 THEME: Kuva – 1.0.4 closed not-approved samuelguebo


https://themes.svn.wordpress.org/kuva/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

Change History (23)

#1 @poena
3 months ago

Hi!
This is not a complete review, your theme will be fully reviewed when it reaches the top of the queue.

Update Kirki to the latest stable version.

Download a correct version of TGMPA.
It currently says: * @version 2.6.1 for parent theme Dapper for publication on ThemeForest
Note: don't just change the above text, the versions are different, you want to use the one for WordPress.org.

-And if you have borrowed code from any other theme, you need to provide attribution.

All theme text strings are to be translatable.
This includes your footer credit text.

Please look through your scripts carefully:
No minification of scripts or files unless you provide original files.
Themes are required to use core-bundled scripts rather than including their own version of that script.
List of scripts:
https://developer.wordpress.org/reference/functions/wp_enqueue_script/#default-scripts-included-and-registered-by-wordpress
Declare licenses of any resources included.

Escape theme mods on output.
All untrusted data should be escaped before output

If you are able to do this beforehand it will speed up your review.

#2 @jrf
3 months ago

Download a correct version of TGMPA.

Not just that, when looking at the file I can clearly see @sitecreateio has done a manual search & replace for the text domain. This search & replace has been done incorrectly and will cause fatal errors for users of your theme in its current state.
If you download the correct version, there is no need for the manual search & replace as the text-domain will have been automagically adjusted for you (correctly).

So, yes, please download a fresh copy of TGMPA using the correct settings - i.e choose "wordpress.org" as distribution channel in the Custom TGMPA Generator.

#3 @themetracbot
3 months ago

  • Summary changed from THEME: Kuva – 1.0.0 to THEME: Kuva – 1.0.1

Kuva - 1.0.1

A clean and simple blogging theme.

Theme URL - http://demo.sitecreate.io/kuva/
Author URL - https://www.sitecreate.io

Trac Browser - https://themes.trac.wordpress.org/browser/kuva/1.0.1

SVN - https://themes.svn.wordpress.org/kuva/1.0.1
ZIP - https://wordpress.org/themes/download/kuva.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kuva/1.0.0&new_path=kuva/1.0.1

History:

Ticket Summary Status Resolution Owner
#45221 THEME: Kuva – 1.0.2 closed closed-newer-version-uploaded samuelguebo

(this ticket)

#47289 THEME: Kuva – 1.0.4 closed not-approved samuelguebo


https://themes.svn.wordpress.org/kuva/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr, with the arguments '

#4 @themetracbot
3 months ago

  • Summary changed from THEME: Kuva – 1.0.1 to THEME: Kuva – 1.0.2

Kuva - 1.0.2

A clean and simple blogging theme.

Theme URL - http://demo.sitecreate.io/kuva/
Author URL - https://www.sitecreate.io

Trac Browser - https://themes.trac.wordpress.org/browser/kuva/1.0.2

SVN - https://themes.svn.wordpress.org/kuva/1.0.2
ZIP - https://wordpress.org/themes/download/kuva.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kuva/1.0.1&new_path=kuva/1.0.2

History:

Ticket Summary Status Resolution Owner
#45221 THEME: Kuva – 1.0.2 closed closed-newer-version-uploaded samuelguebo

(this ticket)

#47289 THEME: Kuva – 1.0.4 closed not-approved samuelguebo


https://themes.svn.wordpress.org/kuva/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#5 @themetracbot
3 months ago

  • Owner set to asadkhan602
  • Status changed from new to reviewing

#6 @sitecreateio
3 months ago

Any update on this? seems to have gone quiet since going into review

This ticket was mentioned in Slack in #themereview by makebootstrap. View the logs.


3 months ago

#8 @rabmalin
3 months ago

  • Owner asadkhan602 deleted

Returning back to queue for new reviewer.

#9 @themetracbot
3 months ago

  • Owner set to antonies

#10 @antonies
3 months ago

this theme has 5+ different problems. Please correct your warning with your hand nc theme check and send it again

#11 @antonies
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]

#12 @poena
3 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#13 @poena
3 months ago

  • Owner antonies deleted
  • Status changed from reopened to reviewing

#14 @themetracbot
3 months ago

  • Owner set to antonies

#15 @antonies
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

this theme has 5+ different problems. Please correct your warning with your hand ns theme check and send it again

https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]

#16 @grapplerulrich
3 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#17 @grapplerulrich
3 months ago

  • Owner antonies deleted
  • Status changed from reopened to reviewing

#18 @themetracbot
2 months ago

  • Owner set to samuelguebo

#19 @samuelguebo
2 months ago

Hello, bellow is my review:

REQUIRED

  1. Sanitize $_GET[] data in:
    • /home-page/blog.php
    • /home-page/widgets.php
    • /footer.php
    • /header.php
  2. Make strings translatable
    • home-page/intro.php L3
    • theme-functions/theme-welcome.php
  3. Enqueue css in theme-functions/theme-welcome.php instead of including using the <link> html tag.
  4. The Readme.txt fails to credit all scripts authors: Kirki, Meta Box, and so on are not mentioned explicitly.
  • Update Kirki framewok, the available version is 3.0.10, yours is 2.2.6

#20 @samuelguebo
2 months ago

Hello @sitecreateio, it's been 6 days since my review. Did you get the chance to work on your ticket? Let me know if you need more time.

#21 @sitecreateio
2 months ago

Hi there

Iv addressed all issues and resubmitted :) I hope its ok :D

This ticket was mentioned in Slack in #themereview by samuelguebo. View the logs.


2 months ago

#23 @thinkupthemes
2 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.