WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 2 months ago

#45225 closed theme (not-approved)

THEME: CreativePress – 1.0.3

Reported by: nextwp Owned by: poena
Priority: previously reviewed Keywords: theme-creativepress
Cc: techgeek@…

Description

CreativePress - 1.0.3

Clean Magazine Theme with dynamic color. Create amazing magazine or blog site using widgets and various options. Get Free Support at http://nextwp.com

Theme URL - http://nextwp.com/themes/creativepress
Author URL - http://nextwp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/creativepress/1.0.3

SVN - https://themes.svn.wordpress.org/creativepress/1.0.3
ZIP - https://wordpress.org/themes/download/creativepress.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creativepress/1.0.2&new_path=creativepress/1.0.3

History:

Ticket Summary Status Resolution Owner
#32563 THEME: CreativePress – 1.0.0 closed not-approved thinkupthemes
#38861 THEME: CreativePress – 1.0.2 closed not-approved maneshtimilsina
#45225 THEME: CreativePress – 1.0.3 closed not-approved poena

(this ticket)


https://themes.svn.wordpress.org/creativepress/1.0.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are creativepress, hybrid-core

Change History (18)

#1 @imranaliweb
3 months ago

  • Owner set to imranaliweb
  • Status changed from new to reviewing

#2 @rabmalin
2 months ago

@imranaliweb Are you still available to continue review? If not we can reassign.

#3 @imranaliweb
2 months ago

Hi @rabmalin,

Yes I am reviewing it and will reply today.

Thanks
Imran Ali

#4 @imranaliweb
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @nextwp,

Thank you for submitting your theme.

Your theme has been partially reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/
As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.

This is part of our long-term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. -We want you to resubmit your theme,
but we do ask that you spend more time making sure that your theme meets all the requirements.
Please do not submit your theme until it is complete, tested, and ready for release.
https://make.wordpress.org/themes/handbook/review/required/

You can upload your update here: https://wordpress.org/themes/upload/
Because of a large number of themes waiting for review, we might not be able to follow up immediately.
We will review your update when your theme reaches the top of the review queue.

Fixed Below issues in next Update

  1. Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.

The domains found are creativepress, hybrid-core

Kindly use creativepress your theme domain

Fucntion prefix issue:

  1. Function prefix missing breadcrumb_trail in breadcrumb-trail.php
  1. Function Prefix missing public function gallery_shortcode in cleaner-gallery.php
  1. Function Prefix missing public function set_up_args( $attr ) in cleaner-gallery.php
  1. Fucntion prefix missing public function get_gallery_item( $attachment ) in cleaner-gallery.php
  1. Fucntion Prefix missing public function get_gallery_icon in cleaner-gallery.php
  1. Fucntion prefix missing public function get_gallery_caption( $attachment ) in cleaner-gallery.php
  1. Fucntion prefix missing public function get_gallery_itemtype() in cleaner-gallery.php
  1. Function prefix missing public function attachment_image_attributes( $attr, $attachment ) in cleaner-gallery.php
  1. Fixed all Prefix function issues in get-the-image.php file
  1. Fixed all prefix issues in Class-chat.php

Class prefix issue:

  1. class Breadcrumb_Trail in breadcrumb-trail.php
  1. class Cleaner_Gallery in cleaner-gallery.php
  1. Fixed all prefix issues in get-the-image.php file

Kindly Fixed all prefix issues in your whole theme then update package.

Thanks
Imran Ali

#5 @nextwp
2 months ago

its not an issue, please review this again @rabmalin

#6 @rabmalin
2 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#7 @rabmalin
2 months ago

  • Status changed from reopened to reviewing

#8 @rabmalin
2 months ago

  • Text domain - If framework is used in the theme then, two text domains are allowed. One for theme and another for framework.
  • Prefixing - Framework functions and classes are not supposed to be prefixed. They are supposed to be used as it is.

Reopening ticket as review comments does not have 5+ issues.

@imranaliweb Please continue review.

#9 @nextwp
2 months ago

@rabmalin please change reviewer

#10 @imranaliweb
2 months ago

Hi @rabmalin,

I will not be able to continue the review.

Please Reassign another reviewer.

Thanks
Imran Ali

#11 @rabmalin
2 months ago

  • Owner imranaliweb deleted

Returning ticket back to queue for new reviewer.

#12 @poena
2 months ago

  • Owner set to poena

#13 @poena
2 months ago

Hi
Thank you for submitting your theme. Your theme is nearly ready to go live, please fix the following:

Required

In widgets.php
Remove the creativepress_Ads_Widget, it does the same thing as the image widget, but the default image widget remains when switching themes (The link is added through the media library).
Also: when I try to activate the advertising widget I see the following in the admin:
Notice: Undefined index: image in creativepress/includes/widgets.php on line 943

The other widgets activate without problems.

Line 181, 379, the widgets needs to include wp_link_pages() when the full content is shown.

In menu/primary.php
Line 15, the translation function is missing:
<div class="menu-toggle">Menu</div>

creativepress/menu/footer.php
18 ERROR Strings should have translatable content
creativepress/menu/primary.php
19 ERROR Strings should have translatable content
creativepress/menu/secondary.php
18 ERROR Strings should have translatable content
creativepress/menu/social.php
18 ERROR Strings should have translatable content
creativepress/sidebar/frontpage.php
20 ERROR Strings should have translatable content
creativepress/sidebar/primary.php
21 ERROR Strings should have translatable content
creativepress/sidebar/secondary.php

#14 @poena
2 months ago

Reminder: it has been 6 days, please reply or the ticket will be closed due to inactivity

#15 @poena
2 months ago

Reminder: it has been 6 days, please reply or the ticket will be closed due to inactivity

#16 @nextwp
2 months ago

implementing changes, thanks for the reminder @poena :)

#17 @nextwp
2 months ago

we are fixing other issues and considering feedback given by our beta testers

#18 @poena
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi
It has been another 7 days, so I am closing this as not approved.

Note: See TracTickets for help on using tickets.