WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4533 closed theme (live)

THEME: P2 - 1.3.1

Reported by: automattic Owned by: SeizedPropaganda
Priority: Keywords: theme-p2
Cc: themes@…

Description

P2 - 1.3.1

A group blog theme for short update messages, inspired by Twitter. Featuring: Hassle-free posting from the front page. Perfect for group blogging, or as a liveblog theme. Dynamic page updates. Threaded comment display on the front page. In-line editing for posts and comments. Live tag suggestion based on previously used tags. A show/hide feature for comments, to keep things tidy. Real-time notifications when a new comment or update is posted. Super-handy keyboard shortcuts. Helvetica Neue for you modern font lovers.

Theme URL - http://p2theme.com/
Author URL - http://automattic.com/

SVN - http://themes.svn.wordpress.org/p2/1.3.1
ZIP - http://wordpress.org/extend/themes/download/p2.1.3.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/p2/1.2.3&new_path=/p2/1.3.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-p2&order=priority

https://themes.svn.wordpress.org/p2/1.3.1/screenshot.png

Change History (12)

comment:1 SeizedPropaganda3 years ago

  • Owner set to SeizedPropaganda
  • Status changed from new to assigned

comment:2 follow-up: SeizedPropaganda3 years ago

THEME CHECK - FAILED:

  • REQUIRED: get_users_of_blog found in the file inc/mentions.php. Deprecated since version 3.1. Use get_users() instead.

Line 52: $users = get_users_of_blog();

Other changes look fine, fix the above issue and resubmit.

comment:3 SeizedPropaganda3 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

comment:4 follow-up: cais3 years ago

Harsh, but consistent, as Automattic authored themes are held to the highest standards. Please ping me when this correction is submitted so we can move this "live" as soon as possible.

comment:5 in reply to: ↑ 2 lancewillett3 years ago

Replying to SeizedPropaganda:

THEME CHECK - FAILED:

  • REQUIRED: get_users_of_blog found in the file inc/mentions.php. Deprecated since version 3.1. Use get_users() instead.

Line 52: $users = get_users_of_blog();

If you look closely at the code in the theme you'll see it's there only for backcompat.

comment:6 in reply to: ↑ 4 lancewillett3 years ago

Replying to cais:

Harsh, but consistent, as Automattic authored themes are held to the highest standards. Please ping me when this correction is submitted so we can move this "live" as soon as possible.

Ping!

comment:7 lancewillett3 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

For the Theme Check failure, it's a matter of Theme Check doing automated checks, but as the reviewer you should still look at the context.

In this case, the "deprecated" function call is only used for backcompat, when the new function fails, which is with WP installs older than 3.1.

I'm reopening this ticket because I don't feel I should resubmit; there's nothing to fix here.

comment:8 follow-up: cais3 years ago

Aside from a quick diff review; the previous reviewer's comments; and, given the code is marked as using the deprecated function for backward compatibility, I will resolve this as "approved".

Although this does beg the questions: what is the time line for maintaining this backward compatibility? and, why would Automattic support *not* updating to the most current stable version of WordPress?

comment:9 cais3 years ago

  • Resolution set to approved
  • Status changed from reopened to closed

comment:10 in reply to: ↑ 8 lancewillett3 years ago

Replying to cais:

Although this does beg the questions: what is the time line for maintaining this backward compatibility? and, why would Automattic support *not* updating to the most current stable version of WordPress?

We like to support back two major releases, so right now that's 3.0. We'd love everyone to update to the latest stable, of course. But for many reasons people aren't able or willing to, and we'd like our themes to not break spectacularly.

comment:11 follow-up: valuser3 years ago

Problems with p2 v.1.3.1. See forum at http://wordpress.org/support/topic/p2-v131-can-not-reply-on-front-page?replies=9 and other entries.

comment:12 in reply to: ↑ 11 lancewillett3 years ago

Replying to valuser:

Problems with p2 v.1.3.1. See forum at http://wordpress.org/support/topic/p2-v131-can-not-reply-on-front-page?replies=9 and other entries.

I posted a quick fix on the forums. I'm now waiting for the theme uploader to be fixed so I can upload a properly fixed version.

Note: See TracTickets for help on using tickets.