WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 6 days ago

Last modified 5 days ago

#45337 closed theme (closed-newer-version-uploaded)

THEME: Grid Magazine – 1.0.0

Reported by: gonzomir Owned by: bothera
Priority: new theme Keywords: theme-grid-magazine
Cc: gonzo@…

Description

Grid Magazine - 1.0.0

A magazine / news theme using CSS Grid Layout on the homepage.

Theme URL - https://github.com/gonzomir/grid-magazine
Author URL - http://greatgonzo.net

Trac Browser - https://themes.trac.wordpress.org/browser/grid-magazine/1.0.0

SVN - https://themes.svn.wordpress.org/grid-magazine/1.0.0
ZIP - https://wordpress.org/themes/download/grid-magazine.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#45337 THEME: Grid Magazine – 1.0.0 closed closed-newer-version-uploaded bothera

(this ticket)

#47202 THEME: Grid Magazine – 1.0.2 reviewing bothera


https://themes.svn.wordpress.org/grid-magazine/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Attachments (1)

grid-magazine.zip (9.2 MB) - added by gonzomir 7 days ago.

Change History (13)

#1 @themetracbot
13 days ago

  • Owner set to antonies
  • Status changed from new to reviewing

#2 @antonies
13 days ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

this theme has 6 different problems. Please correct your warning with your hand ns theme check and send it again

https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]

#3 @grapplerulrich
13 days ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#4 @grapplerulrich
13 days ago

  • Owner antonies deleted
  • Status changed from reopened to reviewing

#5 @themetracbot
10 days ago

  • Owner set to bothera

#6 @bothera
10 days ago

Please let me know if you are available @gonzomir so I can start the review

#7 @gonzomir
10 days ago

Yes, I am available.

#8 @bothera
10 days ago

Great @gonzomir ! Lets get your review done then :-)


grid-magazine/comments.php line 31 - Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals


The theme appears to be RTL compatible, please add the tag to your theme.


Please make sure everything is escaped properly, you can do a search with "echo $"

grid-magazine/searchform.php
Line 2: Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
Line 4: Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'

footer.php
Line 20: Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ''
Line 20: Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '
'


I don't see any licensing about the images in your readme files, it is required to credit image authors used on
screenshot.png as well as any included images with their respected license


You must declare the license of your own theme, for example:
MyTheme WordPress Theme, Copyright 2017 by Author
MyTheme is distributed under the terms of the GNU GPL


You have 7 days to correct everything and report back :-)

Last edited 10 days ago by bothera (previous) (diff)

@gonzomir
7 days ago

#9 @gonzomir
7 days ago

I have corrected all escaping issues, updated the readme with licensing information, etc.

#10 @bothera
7 days ago

Hi @gonzomir you have to re-upload the theme here: https://wordpress.org/themes/upload/ instead of attaching it :-)

#11 @rabmalin
6 days ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed

This ticket was mentioned in Slack in #themereview by lighthouseseo. View the logs.


5 days ago

Note: See TracTickets for help on using tickets.