WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 2 weeks ago

Last modified 2 weeks ago

#45511 closed theme (live)

THEME: Mistercorporate – 1.1.3

Reported by: nsthemes Owned by: nmenescardi
Priority: previously reviewed Keywords: theme-mistercorporate
Cc: info@…

Description

Mistercorporate - 1.0.4

Mistercorporate is an awsome one page WordPress theme, with gallery, pricing table, map, contact and much more.

Theme URL - http://mistercorporate.nsthemes.com/
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mistercorporate/1.0.4

SVN - https://themes.svn.wordpress.org/mistercorporate/1.0.4
ZIP - https://wordpress.org/themes/download/mistercorporate.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=mistercorporate/1.0.3&new_path=mistercorporate/1.0.4

History:

Ticket Summary Status Resolution Owner
#43780 THEME: Mistercorporate – 1.0.3 closed not-approved bhavhiranideveloper
#45511 THEME: Mistercorporate – 1.1.3 closed live nmenescardi

(this ticket)

#47939 THEME: Mistercorporate – 1.1.4 closed live themetracbot
#47946 THEME: Mistercorporate – 1.1.5 closed live themetracbot
#47950 THEME: Mistercorporate – 1.1.6 closed live themetracbot
#47957 THEME: Mistercorporate – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/mistercorporate/1.0.4/screenshot.png

Attachments (3)

Copyright Text.jpg (13.9 KB) - added by nmenescardi 6 weeks ago.
Text-not-shown.jpg (263.4 KB) - added by nmenescardi 6 weeks ago.
JavascriptError.jpg (112.7 KB) - added by nmenescardi 6 weeks ago.

Download all attachments as: .zip

Change History (33)

#1 @williampatton
3 months ago

  • Owner set to williampatton
  • Status changed from new to reviewing

Hi @nsthemes,

I feel like your previous ticket was closed without providing adequate reasons for closure. As such I am going to pick up your theme now and continue with the review.

#2 @williampatton
3 months ago

Hi @nsthemes

I have reviewed your theme against the list of requirements https://make.wordpress.org/themes/handbook/review/required/ for a theme to be added to the wordpress.org theme directory. I have not completed a full review yet as I found many required items that need to be resolved.

If you can upload a new version with fixes for as many of the mentioned items as you can and I will continue my review from there.

Summary

During the review I found some issues that need to be looked at. In addition to looking directly at the code in your theme files I also used some plugins to help check certain items. I highly recommend you test your theme with these plugins to spot any blockers from being approved into the .org theme directory.

Required

Taxonomies and Post Types

Themes are not allowed to add CPTs, register taxonomies or modify existing post types. Those are items which are best placed in plugins so they are not locked away on theme switch.

FILE: /var/www/html/wp-content/themes/mistercorporate/functions.php
----------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
 65 | ERROR | Function register_taxonomy_for_object_type() is not allowed because it is plugin territory.
 66 | ERROR | Function register_taxonomy_for_object_type() is not allowed because it is plugin territory.
----------------------------------------------------------------------------------------------------------

Missing Singular Placeholder

To ensure your theme is translatable into as many languages as possible you need to be sure to include a placeholder for the single term in these places.

FILE: /var/www/html/wp-content/themes/mistercorporate/page.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 15 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/mistercorporate/single.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 17 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

Page Templates

Custom page templates should not use page- prefix because it means that WordPress will use this template if a page ever has a slug of mistercorporate. You should change page-mistercorporate.php to something else like template-mistercorporate.php.

Licensing

Theme licence is GPL however there is a LICENCE file that contains the MIT licence text. You should remove that file or replace the text with the corresponding GPL copy.

Additionally all assets used or distributed in the theme need to have a licence statement in the readme.txt file. I see you already have statements there but jqBootstrapValidation, TGMPA and wp_bootstrap_navwalker are not mentioned in the readme. There is also the map-marker.png image not stated.

Translation Issues

All the strings in the theme need to be translated and all of the strings output to the page need escaped. I see many places in the theme which uses non-safe translations functions such as _e() or __(). Those functions do not escape the translations returned and should only be used where strings are sanitized or escaped later. Anytime you are outputting a translation to the page you should use functions like esc_html__(), esc_html_e(), esc_attr__(), esc_attr_e().

You can find translation issues quickly by using the theme sniffer plugin. Here are a few examples but there are some more as well to look at.

FILE: /var/www/html/wp-content/themes/mistercorporate/404.php
-------------------------------------------------------------------------------------------------------------
  9 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 11 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
-------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/mistercorporate/archive.php
--------------------------------------------------------------------------------------------------------------
  9 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 28 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 48 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
--------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/mistercorporate/comments.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
 13 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 39 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
-------------------------------------------------------------------------------------------------------------

Escaping Issues

There are many escaping issues in the theme, many of them will be fixed by escaping translations but there are some others that will need checked as well. Again the theme sniffer can spot these quickly and give warnings where you need to look at and possibly escape.

NOTE: One of the escaping issues is inside the wp_bootstrap_navwalker.php file. I fixed that issue some time ago in the walker so if you update to the latest version from github that specific warning will go away.

Next Steps

If you could make some adjustments and upload a version that deals with items listed above I will review the changes and continue my review.

If you need any help with any of the items noted you can ask in slack or ping me in the ticket and I'll do my best to explain things better.

The standard policy at Theme Review Team is that authors should try to respond within 7 days. If author does not respond within 7 days ticket will get closed. If you are unable to make changes within 7 days post a message in the ticket to ensure that it stays open until you are able to make changes.

#3 @themetracbot
3 months ago

  • Summary changed from THEME: Mistercorporate – 1.0.4 to THEME: Mistercorporate – 1.1.0

Mistercorporate - 1.1.0

Mistercorporate is an awsome one page WordPress theme, with gallery, pricing table, map, contact and much more.

Theme URL - http://mistercorporate.nsthemes.com/
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mistercorporate/1.1.0

SVN - https://themes.svn.wordpress.org/mistercorporate/1.1.0
ZIP - https://wordpress.org/themes/download/mistercorporate.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=mistercorporate/1.0.4&new_path=mistercorporate/1.1.0

History:

Ticket Summary Status Resolution Owner
#43780 THEME: Mistercorporate – 1.0.3 closed not-approved bhavhiranideveloper
#45511 THEME: Mistercorporate – 1.1.3 closed live nmenescardi

(this ticket)

#47939 THEME: Mistercorporate – 1.1.4 closed live themetracbot
#47946 THEME: Mistercorporate – 1.1.5 closed live themetracbot
#47950 THEME: Mistercorporate – 1.1.6 closed live themetracbot
#47957 THEME: Mistercorporate – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/mistercorporate/1.1.0/screenshot.png

#4 @nsthemes
3 months ago

Hi @williampatton thank you so much for your review!

We solved all this issues.

Best regards

#5 @djrmom
3 months ago

@williampatton, are you still able to review this theme?

#6 @williampatton
3 months ago

@nsthemes I am terribly sorry for more delays. I did not see the email notification of your updates.

I will continue the review tomorrow. I apologize for my mistake, I hope it has not inconvenienced you a lot :(

#7 @nsthemes
3 months ago

@williampatton not a big problem. ;)

@djrmom Thanks for the attention you shown to us :)

#8 @rabmalin
3 months ago

  • Owner williampatton deleted

This is being returned to the new queue again, as there has been no response yet from the reviewer. A reviewer should make an initial comment in ticket within 24 hours of being assigned, after which both reviewer and author should always communicate within 7 days.
If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#9 @themetracbot
6 weeks ago

  • Owner set to nmenescardi

#10 @nmenescardi
6 weeks ago

Hi @nsthemes , I will continue the review. I have been reading the last review and I will take things from there.

#11 @nmenescardi
6 weeks ago

Hi @nsthemes ,

Reviewing the theme I found the following problems:

Inside the Customizer:

  • Header Section: The "Big Text" works on the home template, but "Small Text" is not working (not displayed). The same for Gallery text. See image attached.
  • Site Identity: The check option "Display Site Title and Tagline" is not working
  • Mistercorporate Options > Footer section: The copyright text is not working properly. See image attached.

There is a Javascript error. See image attached.

Documentation.
Do you have any documentation for the Customizer options? I couldn't find it. See: https://make.wordpress.org/themes/handbook/review/required/#documentation

Please, fix those issues and we will continue with the review.

This ticket was mentioned in Slack in #themereview by nmenescardi. View the logs.


6 weeks ago

#13 @nsthemes
5 weeks ago

Hi @nmenescardi thank you for your review, we will fix this issues and update new version!

#14 @themetracbot
5 weeks ago

  • Summary changed from THEME: Mistercorporate – 1.1.0 to THEME: Mistercorporate – 1.1.1

Mistercorporate - 1.1.1

Mistercorporate is an awsome one page WordPress theme, with gallery, pricing table, map, contact and much more.

Theme URL - http://mistercorporate.nsthemes.com/
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mistercorporate/1.1.1

SVN - https://themes.svn.wordpress.org/mistercorporate/1.1.1
ZIP - https://wordpress.org/themes/download/mistercorporate.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=mistercorporate/1.1.0&new_path=mistercorporate/1.1.1

History:

Ticket Summary Status Resolution Owner
#43780 THEME: Mistercorporate – 1.0.3 closed not-approved bhavhiranideveloper
#45511 THEME: Mistercorporate – 1.1.3 closed live nmenescardi

(this ticket)

#47939 THEME: Mistercorporate – 1.1.4 closed live themetracbot
#47946 THEME: Mistercorporate – 1.1.5 closed live themetracbot
#47950 THEME: Mistercorporate – 1.1.6 closed live themetracbot
#47957 THEME: Mistercorporate – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/mistercorporate/1.1.1/screenshot.png

#15 @nsthemes
5 weeks ago

Hi @nmenescardi we fix those issues
thank you!

#16 @nmenescardi
5 weeks ago

Hi @nsthemes , I'll continue with the review. Regards!

#17 @nmenescardi
4 weeks ago

Hi @nsthemes ,

Regarding the last review, the only point missed is the Documentation for the Customizer options. Do you have any external URL at least for that? I couldn't find it. See: https://make.wordpress.org/themes/handbook/review/required/#documentation

Let me know that and I'll continue with next points on this review. Regards!

#18 @nsthemes
4 weeks ago

Hi @nmenescardi ,

we are sorry, we put the external link in the readme.txt file but we didn't tell you.
However here the link of the full documentation: http://mistercorporate.nsthemes.com/documentation/.

Regards!

#19 @nmenescardi
4 weeks ago

Hi @nsthemes ,

Don't worry. I'll continue with the review.

Regards!

This ticket was mentioned in Slack in #themereview by nmenescardi. View the logs.


4 weeks ago

#21 @nmenescardi
4 weeks ago

Hi @nsthemes ,

The customizer documentation is very complete. This point is done.

I've completed the review. The only required issue is the following:

On line 45 of footer.php, the default copyright should be translation ready. I asked this issue on Slack and @greenshady recommend a couple of different ways:

<?php printf(
    // Translators: 1 is current year, 2 is theme link.
    esc_html__( 'Copyright &copy; %1$s. Powered by %1$s.', 'theme-textdomain' ),
    date_i18n( 'Y' ),
    // Translators: %s is company name.
    sprintf( '<a href="https://profiles.wordpress.org/nsthemes">%s</a>', __( 'NsThemes', 'theme-textdomain' )
); ?>

Or:

<?php printf(
    // Translators: 1 is current year, 2 is theme link.
    esc_html__( 'Copyright &copy; %1$s. Powered by %2$s WordPress Theme.', 'theme-textdomain' ),
    date_i18n( 'Y' ),
    '<a href="https://profiles.wordpress.org/nsthemes">NsThemes</a>'
); ?>

"The first option is if you want to translate company name. The second option is if you don't."

Please, fix this issue and I'll approve the review. Regards!

#22 @themetracbot
4 weeks ago

  • Summary changed from THEME: Mistercorporate – 1.1.1 to THEME: Mistercorporate – 1.1.2

Mistercorporate - 1.1.2

Mistercorporate is an awsome one page WordPress theme, with gallery, pricing table, map, contact and much more.

Theme URL - http://mistercorporate.nsthemes.com/
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mistercorporate/1.1.2

SVN - https://themes.svn.wordpress.org/mistercorporate/1.1.2
ZIP - https://wordpress.org/themes/download/mistercorporate.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=mistercorporate/1.1.1&new_path=mistercorporate/1.1.2

History:

Ticket Summary Status Resolution Owner
#43780 THEME: Mistercorporate – 1.0.3 closed not-approved bhavhiranideveloper
#45511 THEME: Mistercorporate – 1.1.3 closed live nmenescardi

(this ticket)

#47939 THEME: Mistercorporate – 1.1.4 closed live themetracbot
#47946 THEME: Mistercorporate – 1.1.5 closed live themetracbot
#47950 THEME: Mistercorporate – 1.1.6 closed live themetracbot
#47957 THEME: Mistercorporate – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/mistercorporate/1.1.2/screenshot.png

#23 @nsthemes
4 weeks ago

Hi @nmenescardi ,

done!

Thanks a lot!
And thanks to @greenshady for his raccomendation.

Regards!

#24 @nmenescardi
4 weeks ago

  • Status changed from reviewing to approved

Hi @nsthemes ,

The copyright on the footer is fine.

I'll change the status to approved.

Regards!

#25 @rabmalin
3 weeks ago

  • Status changed from approved to reopened

#26 @rabmalin
3 weeks ago

  • Cc rabmalin added
  • Status changed from reopened to reviewing

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

#27 @themetracbot
2 weeks ago

  • Summary changed from THEME: Mistercorporate – 1.1.2 to THEME: Mistercorporate – 1.1.3

Mistercorporate - 1.1.3

Mistercorporate is an awsome one page WordPress theme, with gallery, pricing table, map, contact and much more.

Theme URL -
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mistercorporate/1.1.3

SVN - https://themes.svn.wordpress.org/mistercorporate/1.1.3
ZIP - https://wordpress.org/themes/download/mistercorporate.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=mistercorporate/1.1.2&new_path=mistercorporate/1.1.3

History:

Ticket Summary Status Resolution Owner
#43780 THEME: Mistercorporate – 1.0.3 closed not-approved bhavhiranideveloper
#45511 THEME: Mistercorporate – 1.1.3 closed live nmenescardi

(this ticket)

#47939 THEME: Mistercorporate – 1.1.4 closed live themetracbot
#47946 THEME: Mistercorporate – 1.1.5 closed live themetracbot
#47950 THEME: Mistercorporate – 1.1.6 closed live themetracbot
#47957 THEME: Mistercorporate – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/mistercorporate/1.1.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#28 @nsthemes
2 weeks ago

Hi @rabmalin ,

thank you for your review, we hope that everything is well!

Regards

#29 @rabmalin
2 weeks ago

  • Cc rabmalin removed
  • Resolution set to live
  • Status changed from reviewing to closed

Approving and setting live. It will take around 1 hour for theme to appear in the directory. In the next update please fix following issues.

Issues

  • REQUIRED: You forgot to remove editor-style tag from style.css.
  • REQUIRED: mrcorporate_styles_method() - Incorrect prefix.

#30 @nsthemes
2 weeks ago

Hi @rabmalin ,

Thank you!

We will fix it!

Regards

Note: See TracTickets for help on using tickets.