WordPress.org

Make WordPress Themes

Opened 7 weeks ago

Last modified 3 weeks ago

#45511 reviewing theme

THEME: Mistercorporate – 1.1.0

Reported by: nsthemes Owned by:
Priority: previously reviewed Keywords: theme-mistercorporate
Cc: info@…

Change History (8)

#1 @williampatton
6 weeks ago

  • Owner set to williampatton
  • Status changed from new to reviewing

Hi @nsthemes,

I feel like your previous ticket was closed without providing adequate reasons for closure. As such I am going to pick up your theme now and continue with the review.

#2 @williampatton
6 weeks ago

Hi @nsthemes

I have reviewed your theme against the list of requirements https://make.wordpress.org/themes/handbook/review/required/ for a theme to be added to the wordpress.org theme directory. I have not completed a full review yet as I found many required items that need to be resolved.

If you can upload a new version with fixes for as many of the mentioned items as you can and I will continue my review from there.

Summary

During the review I found some issues that need to be looked at. In addition to looking directly at the code in your theme files I also used some plugins to help check certain items. I highly recommend you test your theme with these plugins to spot any blockers from being approved into the .org theme directory.

Required

Taxonomies and Post Types

Themes are not allowed to add CPTs, register taxonomies or modify existing post types. Those are items which are best placed in plugins so they are not locked away on theme switch.

FILE: /var/www/html/wp-content/themes/mistercorporate/functions.php
----------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
 65 | ERROR | Function register_taxonomy_for_object_type() is not allowed because it is plugin territory.
 66 | ERROR | Function register_taxonomy_for_object_type() is not allowed because it is plugin territory.
----------------------------------------------------------------------------------------------------------

Missing Singular Placeholder

To ensure your theme is translatable into as many languages as possible you need to be sure to include a placeholder for the single term in these places.

FILE: /var/www/html/wp-content/themes/mistercorporate/page.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 15 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/mistercorporate/single.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 17 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

Page Templates

Custom page templates should not use page- prefix because it means that WordPress will use this template if a page ever has a slug of mistercorporate. You should change page-mistercorporate.php to something else like template-mistercorporate.php.

Licensing

Theme licence is GPL however there is a LICENCE file that contains the MIT licence text. You should remove that file or replace the text with the corresponding GPL copy.

Additionally all assets used or distributed in the theme need to have a licence statement in the readme.txt file. I see you already have statements there but jqBootstrapValidation, TGMPA and wp_bootstrap_navwalker are not mentioned in the readme. There is also the map-marker.png image not stated.

Translation Issues

All the strings in the theme need to be translated and all of the strings output to the page need escaped. I see many places in the theme which uses non-safe translations functions such as _e() or __(). Those functions do not escape the translations returned and should only be used where strings are sanitized or escaped later. Anytime you are outputting a translation to the page you should use functions like esc_html__(), esc_html_e(), esc_attr__(), esc_attr_e().

You can find translation issues quickly by using the theme sniffer plugin. Here are a few examples but there are some more as well to look at.

FILE: /var/www/html/wp-content/themes/mistercorporate/404.php
-------------------------------------------------------------------------------------------------------------
  9 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 11 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
-------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/mistercorporate/archive.php
--------------------------------------------------------------------------------------------------------------
  9 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 28 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 48 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
--------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/mistercorporate/comments.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
 13 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
 39 | WARNING | Expected next thing to be an escaping function (like esc_html_e() or esc_attr_e()), not '_e'
-------------------------------------------------------------------------------------------------------------

Escaping Issues

There are many escaping issues in the theme, many of them will be fixed by escaping translations but there are some others that will need checked as well. Again the theme sniffer can spot these quickly and give warnings where you need to look at and possibly escape.

NOTE: One of the escaping issues is inside the wp_bootstrap_navwalker.php file. I fixed that issue some time ago in the walker so if you update to the latest version from github that specific warning will go away.

Next Steps

If you could make some adjustments and upload a version that deals with items listed above I will review the changes and continue my review.

If you need any help with any of the items noted you can ask in slack or ping me in the ticket and I'll do my best to explain things better.

The standard policy at Theme Review Team is that authors should try to respond within 7 days. If author does not respond within 7 days ticket will get closed. If you are unable to make changes within 7 days post a message in the ticket to ensure that it stays open until you are able to make changes.

#3 @themetracbot
6 weeks ago

  • Summary changed from THEME: Mistercorporate – 1.0.4 to THEME: Mistercorporate – 1.1.0

#4 @nsthemes
6 weeks ago

Hi @williampatton thank you so much for your review!

We solved all this issues.

Best regards

#5 @djrmom
4 weeks ago

@williampatton, are you still able to review this theme?

#6 @williampatton
4 weeks ago

@nsthemes I am terribly sorry for more delays. I did not see the email notification of your updates.

I will continue the review tomorrow. I apologize for my mistake, I hope it has not inconvenienced you a lot :(

#7 @nsthemes
4 weeks ago

@williampatton not a big problem. ;)

@djrmom Thanks for the attention you shown to us :)

#8 @rabmalin
3 weeks ago

  • Owner williampatton deleted

This is being returned to the new queue again, as there has been no response yet from the reviewer. A reviewer should make an initial comment in ticket within 24 hours of being assigned, after which both reviewer and author should always communicate within 7 days.
If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

Note: See TracTickets for help on using tickets.