WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 3 months ago

#45512 closed theme (not-approved)

THEME: Carbon Portfolio – 1.6.2

Reported by: afrothemes Owned by: coderarjun
Priority: new theme Keywords: theme-carbon-portfolio
Cc: afrothemes@…

Description

Carbon Portfolio - 1.1.5

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL - https://rocketr.net/buy/2b1a9cdc0ee7
Author URL - http://myportfoliothemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.1.5

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.1.5
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.1.5.zip?nostats=1

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.1.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (29)

#1 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.1.5 to THEME: Carbon Portfolio – 1.2

Carbon Portfolio - 1.2

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.2

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.2
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.1.5&new_path=carbon-portfolio/1.2

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.2 to THEME: Carbon Portfolio – 1.3

Carbon Portfolio - 1.3

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.3

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.3
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.2&new_path=carbon-portfolio/1.3

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#3 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.3 to THEME: Carbon Portfolio – 1.4

Carbon Portfolio - 1.4

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.4

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.4
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.3&new_path=carbon-portfolio/1.4

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @themetracbot
3 months ago

  • Owner set to wpcoderguy
  • Status changed from new to reviewing

#5 @rabmalin
3 months ago

  • Owner wpcoderguy deleted

#6 @themetracbot
3 months ago

  • Owner set to coderarjun

#7 @coderarjun
3 months ago

I am reviewing your theme.i will come with review. you can just let me know if you want to update themes.

#8 @coderarjun
3 months ago

Hello @afrothemes

  1. Screenshot images must be GPL, or GPL-Compatible . You are using Unflash images which are not GPL-compatile. You must be change screenshot images.

#9 @rabmalin
3 months ago

@coderarjun

When posting comment I would recommend separating comments in required and recommended (and notes if available). Sample format.

Hello,

Thanks for uploading theme. Please check following issues I found while initial review. Re-upload your theme after fixing issues.

== Required ==
* Required 1
* Required 2

== Recommended ==
* Recommended 1
* Recommended 2

== Note ==
* Note 1
* Note 2

Please submit theme update or comment here within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Regards!

#10 @coderarjun
3 months ago

Hello @rabmalin
Thank you For your suggestions.Actually I am new in review .In future i will try to follow Your Instructions.

#11 @coderarjun
3 months ago

Hello @afrothemes
Thanks for uploading theme. Please check following issues I found while initial review. Re-upload your theme after fixing issues.

REQUIRED

  • Screenshot images must be GPL, or GPL-Compatible . You are using Unflash images which are not GPL- compatible. You must be change screenshot images.
  • Remove layout folder, it's not necessary.
  • Create your own pot file. You have default pot file. And pot file name must be carbon-portfolio.pot
  • carbon_portfolio_category() esc_url is missing. Check escaping properly on other files as well.

Test your theme on latest version of WordPress as well. **Tested up to:* WordPress 4.7

NOTES

  • Response within 7 days to remain the ticket open.
  • Maintain changelog and version before submitting the theme.
  • If you have any query, ask here or use #themereview channel on slack.

#12 @afrothemes
3 months ago

I'm sure unsplash is allowed, they changed their license . Please confirm this with other reviewers.
Uploading the other changes right now

#13 @afrothemes
3 months ago

Also there's no need to esc carbon_portfolio_category() , get_the_category() function that this is derived from is already escaped.
So just the .pot and layout folder issues are genuine.

#14 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.4 to THEME: Carbon Portfolio – 1.5

Carbon Portfolio - 1.5

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.5

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.5
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.4&new_path=carbon-portfolio/1.5

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#15 @coderarjun
3 months ago

Hello @rabmalin
can you give your view here for unplash images are gpl or not ?

#16 @coderarjun
3 months ago

hello @afrothemes,

Required

https://wordpress.org/themes/x-portfolio/

NOTES

  • Response within 7 days to remain the ticket open.
  • Maintain changelog and version before submitting the theme.
  • If you have any query, ask here or use #themereview channel on slack.

#17 @rabmalin
3 months ago

Unsplash has recently changed the license from CC0 to Unsplash License and they have added some terms which are not compatible with GPL. So, currently images from Unsplash are not allowed.

#18 @coderarjun
3 months ago

Thank You @rabmalin for your help.

#19 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.5 to THEME: Carbon Portfolio – 1.6

Carbon Portfolio - 1.6

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.6

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.6
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.5&new_path=carbon-portfolio/1.6

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#20 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.6 to THEME: Carbon Portfolio – 1.6.1

Carbon Portfolio - 1.6.1

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.6.1

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.6.1
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.6.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.6&new_path=carbon-portfolio/1.6.1

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.6.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#21 @coderarjun
3 months ago

Hello @afrothemes,
Thanks for uploading theme.

Required

  • You are only changing screenshot images that's fine. There is not fixed all above requirement
    • pot file is not from this theme 'x-portfolio.pot' ,why are you include in your theme ? There was found 2 pot file.
    • "All theme text strings are to be translatable. It is missing on customizer.php" -you are not work on.
    • "Remove layout folder, it's not necessary." -> You did not work on it.
    • "https://developer.wordpress.org/reference/functions/get_the_category/ carbon_portfolio_category() esc_url is missing. Check escaping properly on other files as well."-As well you did not work on it.

Note

  • Please submit theme update or comment here within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Regards!

#22 @afrothemes
3 months ago

are you looking at the correct version? I removed the layout file and escaped the carbon_portfolio_category() in the function it self, not where the function is called, I don't need to do it twice.
Uploading another version with one .pot file
thanks for your review

#23 @coderarjun
3 months ago

Hello @afrothemes,
sorry for that exactly i am checking previous version.

required

  • But there is 1.6.1 , i am finding 2 .pot files, please removes 'x-portfolio.pot' .This pot file is not belongs to this theme.
  • you are missing semicolon in style.css due to this error found, please fixed and update then i will approve your theme.

Thank You

#24 @rabmalin
3 months ago

Other Issues

  • REQUIRED: menu-walker.php L100 - Escape admin_url() with esc_url().
  • REQUIRED: menu-walker.php L100 - Translation issue - Add a menu
  • REQUIRED: functions.php L46 - Image size handle should be prefixed.
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: single-portfolio.php - Custom action/filter hook name should be prefixed.
  • REQUIRED: template-tags.php L152 - Escape $category[0]->name with esc_html().
  • REQUIRED: template-tags.php L152 - Value of title needs escaping also.

#25 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Portfolio – 1.6.1 to THEME: Carbon Portfolio – 1.6.2

Carbon Portfolio - 1.6.2

Responsive WordPress theme for agency, portfolio, photography, studio or anything digital

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-portfolio/1.6.2

SVN - https://themes.svn.wordpress.org/carbon-portfolio/1.6.2
ZIP - https://wordpress.org/themes/download/carbon-portfolio.1.6.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-portfolio/1.6.1&new_path=carbon-portfolio/1.6.2

History:


https://themes.svn.wordpress.org/carbon-portfolio/1.6.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#26 @coderarjun
3 months ago

THank You @rabmalin for your help in review.

#27 @coderarjun
3 months ago

Hello @afrothemes,
Thanks for uploading theme.

Required

  • Still missing semicolon in style.css (Line -770) due to find error in your themes.
  • And please fixed other issues that are mention by @rabmalin.

Note

Please submit theme update or comment here within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Thank You !!!

#28 @rabmalin
3 months ago

@afrothemes Please respond or update theme to keep ticket open. Otherwise ticket will be closed.

#29 @coderarjun
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.