WordPress.org

Make WordPress Themes

Opened 4 months ago

Last modified 5 days ago

#45592 reviewing theme

THEME: Doo – 1.0.27

Reported by: themevs Owned by: WEN Solutions
Priority: previously reviewed Keywords: theme-doo accessibility-ready
Cc: themevscom@…

Description

Doo - 1.0.10

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.10

SVN - https://themes.svn.wordpress.org/doo/1.0.10
ZIP - https://wordpress.org/themes/download/doo.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.9&new_path=doo/1.0.10

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.10/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (27)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.10 to THEME: Doo – 1.0.11

Doo - 1.0.11

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.11

SVN - https://themes.svn.wordpress.org/doo/1.0.11
ZIP - https://wordpress.org/themes/download/doo.1.0.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.10&new_path=doo/1.0.11

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.11/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 follow-up: @williampatton
4 months ago

Hi @themevs

I have done some preliminary checks on your theme to help speed up review process farther down the line.

NOTE: This is not a full review and I am not the assigned reviewer of this theme. It will still be some time before a reviewer is assigned.

I encourage you to test your theme with this plugin: https://github.com/WPTRT/theme-sniffer/releases It was created by theme review team for use in theme building and review.

Theme Issues

There are many escaping issues and translation issues in your theme. You will be able to spot those quickly with the theme sniffer plugin.

Additionally these 3 issues need to be solved.

FILE: /var/www/html/wp-content/themes/doo/comments.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 28 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/doo/inc/extras.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 67 | ERROR | The title tag must not be used. Use add_theme_support( 'title-tag' ) instead.
--------------------------------------------------------------------------------------------

FILE: /var/www/html/wp-content/themes/doo/inc/template-tags.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 215 | ERROR | Overriding WordPress globals is prohibited
----------------------------------------------------------------------

Good luck with the review once you get a reviewer assigned. Try to fix these noted issues before that point - they are all items based on the required items that every theme in the .org repo must follow.

#3 in reply to: ↑ 2 @themevs
4 months ago

Thank you @williampatton

#4 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.11 to THEME: Doo – 1.0.12

Doo - 1.0.12

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.12

SVN - https://themes.svn.wordpress.org/doo/1.0.12
ZIP - https://wordpress.org/themes/download/doo.1.0.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.11&new_path=doo/1.0.12

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.12/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#5 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.12 to THEME: Doo – 1.0.13

Doo - 1.0.13

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.13

SVN - https://themes.svn.wordpress.org/doo/1.0.13
ZIP - https://wordpress.org/themes/download/doo.1.0.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.12&new_path=doo/1.0.13

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.13/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#6 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.13 to THEME: Doo – 1.0.14

Doo - 1.0.14

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.14

SVN - https://themes.svn.wordpress.org/doo/1.0.14
ZIP - https://wordpress.org/themes/download/doo.1.0.14.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.13&new_path=doo/1.0.14

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.14/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.14 to THEME: Doo – 1.0.15

Doo - 1.0.15

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.15

SVN - https://themes.svn.wordpress.org/doo/1.0.15
ZIP - https://wordpress.org/themes/download/doo.1.0.15.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.14&new_path=doo/1.0.15

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.15/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#8 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.15 to THEME: Doo – 1.0.16

Doo - 1.0.16

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.16

SVN - https://themes.svn.wordpress.org/doo/1.0.16
ZIP - https://wordpress.org/themes/download/doo.1.0.16.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.15&new_path=doo/1.0.16

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.16/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are doo, sin

#9 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.16 to THEME: Doo – 1.0.17

Doo - 1.0.17

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.17

SVN - https://themes.svn.wordpress.org/doo/1.0.17
ZIP - https://wordpress.org/themes/download/doo.1.0.17.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.16&new_path=doo/1.0.17

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.17/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#10 @themetracbot
4 months ago

  • Summary changed from THEME: Doo – 1.0.17 to THEME: Doo – 1.0.18

Doo - 1.0.18

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.18

SVN - https://themes.svn.wordpress.org/doo/1.0.18
ZIP - https://wordpress.org/themes/download/doo.1.0.18.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.17&new_path=doo/1.0.18

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.18/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#11 @themetracbot
3 months ago

  • Summary changed from THEME: Doo – 1.0.18 to THEME: Doo – 1.0.19

Doo - 1.0.19

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.19

SVN - https://themes.svn.wordpress.org/doo/1.0.19
ZIP - https://wordpress.org/themes/download/doo.1.0.19.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.18&new_path=doo/1.0.19

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.19/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#12 @WEN Solutions
2 months ago

  • Owner set to WEN Solutions
  • Status changed from new to reviewing

#13 @WEN Solutions
2 months ago

@themevs

Here are the latest observations. Please consider fixing them.

style.css

  • custom-background tag missing in style.css. It appears that your theme supports custom background
  • Sticky post should be visibly distinguished. Your theme supports 'sticky-post' tag
  • Found 'underscrores' instances. Remove them.
  • add 'accessibility' tag if your theme supports Accessibility. I noticed accessibility CSS written in CSS file

License

  • image used in the screenshot should be GPL. License not clear. Also provide the exact image source.

template-functions.php

  • line 94 escaping function esc_attr, not '$custom_css'
  • line 15,32 use escaping function esc_html__ for all translatable strings. Check and maintain this on other instances of the file e.g. customizer.php.

Thanks you.

#14 @themetracbot
2 months ago

  • Keywords accessibility-ready added
  • Summary changed from THEME: Doo – 1.0.19 to THEME: Doo – 1.0.20

Doo - 1.0.20

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.20

SVN - https://themes.svn.wordpress.org/doo/1.0.20
ZIP - https://wordpress.org/themes/download/doo.1.0.20.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.19&new_path=doo/1.0.20

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.20/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#15 @WEN Solutions
2 months ago

@themevs

Thanks for fixing those issues, except the GPL license for image is still not clear.

REQUIRED: The image used in the screenshot https://picjumbo.com/christmas-baking/ does not appears to be a 100% GPL. Can you include the reference to the GPL license declaration of those images on this source https://picjumbo.com?

Reference:

https://make.wordpress.org/themes/handbook/review/required/#licensing
https://make.wordpress.org/themes/handbook/review/resources/#licenses-bundled-resources

#16 @themetracbot
2 months ago

  • Summary changed from THEME: Doo – 1.0.20 to THEME: Doo – 1.0.21

Doo - 1.0.21

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.21

SVN - https://themes.svn.wordpress.org/doo/1.0.21
ZIP - https://wordpress.org/themes/download/doo.1.0.21.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.20&new_path=doo/1.0.21

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.21/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#17 @themetracbot
2 months ago

  • Summary changed from THEME: Doo – 1.0.21 to THEME: Doo – 1.0.22

Doo - 1.0.22

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.22

SVN - https://themes.svn.wordpress.org/doo/1.0.22
ZIP - https://wordpress.org/themes/download/doo.1.0.22.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.21&new_path=doo/1.0.22

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.22/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#18 @themetracbot
8 weeks ago

  • Summary changed from THEME: Doo – 1.0.22 to THEME: Doo – 1.0.23

Doo - 1.0.23

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.23

SVN - https://themes.svn.wordpress.org/doo/1.0.23
ZIP - https://wordpress.org/themes/download/doo.1.0.23.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.22&new_path=doo/1.0.23

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.23/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#19 @themetracbot
8 weeks ago

  • Summary changed from THEME: Doo – 1.0.23 to THEME: Doo – 1.0.24

Doo - 1.0.24

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.24

SVN - https://themes.svn.wordpress.org/doo/1.0.24
ZIP - https://wordpress.org/themes/download/doo.1.0.24.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.23&new_path=doo/1.0.24

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.24/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#20 @WEN Solutions
8 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thanks for resolving all the issues. I have approved and marked the theme "live".

#21 @rabmalin
8 weeks ago

  • Resolution live deleted
  • Status changed from closed to reopened

#22 @rabmalin
8 weeks ago

  • Status changed from reopened to reviewing

This theme needs a11y review.

Ping @poena

#23 @themetracbot
8 weeks ago

  • Summary changed from THEME: Doo – 1.0.24 to THEME: Doo – 1.0.25

Doo - 1.0.25

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.25

SVN - https://themes.svn.wordpress.org/doo/1.0.25
ZIP - https://wordpress.org/themes/download/doo.1.0.25.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.24&new_path=doo/1.0.25

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.25/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#24 @joedolson
12 days ago

Very close to passing - a few items to address.

1) Keyboard Navigation - Pass

2) Controls - Fail

  • Mobile Menu toggle is missing screen reader text [also note that the toggle is not visible in responsive view when logged-in; masked by adminbar)

3) Skip Links - Pass

4) Forms - Fail

  • Comment form is missing labels

5) Headings - Pass

6) ARIA Landmark Roles - Pass

7) Link Text - Pass

8) Contrasts - Fail

  • Link to Top has contrast ratio 3.59:1
  • Search icon has contrast ratio 2.78:1

9) Images - Fail

  • Some Font Awesome icons are missing aria-hidden=true, including the Link to Top image & mobile menu toggle icon

10) Screen Reader Text - Pass

10) Media - None identified; default pass.

11) Not Allowed - Pass

Theme Accessibility Guidelines & Tips:
https://make.wordpress.org/themes/handbook/review/accessibility/required/

#25 @themetracbot
12 days ago

  • Summary changed from THEME: Doo – 1.0.25 to THEME: Doo – 1.0.26

Doo - 1.0.26

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.26

SVN - https://themes.svn.wordpress.org/doo/1.0.26
ZIP - https://wordpress.org/themes/download/doo.1.0.26.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.25&new_path=doo/1.0.26

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.26/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#26 @joedolson
6 days ago

2) Pass

4) Pass - While these pass the literal requirements, I do want to mention that using a placeholder as a visual representation for a label is highly problematic, as it creates a lot of challenges particularly for users with cognitive impairments.

8) Skip to Top link still fails at 4.30:1;

9) Pass

Just need to address the contrast on the Skip to Top link.

Best,
Joe

#27 @themetracbot
5 days ago

  • Summary changed from THEME: Doo – 1.0.26 to THEME: Doo – 1.0.27

Doo - 1.0.27

A beautiful two-columns WordPress theme created by the ThemeVS designers.

Theme URL - http://themevs.com/themes/doo/
Author URL - http://themevs.com/

Trac Browser - https://themes.trac.wordpress.org/browser/doo/1.0.27

SVN - https://themes.svn.wordpress.org/doo/1.0.27
ZIP - https://wordpress.org/themes/download/doo.1.0.27.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=doo/1.0.26&new_path=doo/1.0.27

History:

Ticket Summary Status Resolution Owner
#23134 THEME: Doo – 1.0.9 closed not-approved vladff
#45592 THEME: Doo – 1.0.27 reviewing WEN Solutions

(this ticket)


https://themes.svn.wordpress.org/doo/1.0.27/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
Note: See TracTickets for help on using tickets.