WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 6 weeks ago

Last modified 4 weeks ago

#45694 closed theme (live)

THEME: Adventure Lite – 1.4

Reported by: sonalsinha21 Owned by: Iceable
Priority: new theme Keywords: theme-adventure-lite
Cc: support@…

Description

Adventure Lite - 1.0

Adventure Lite WordPress theme can be used for adventure, sports, hiking, trekking, railing, rafting, games, fun, elking, hunting, military, mountain climbing, skiing, surfing and other such adventure sports. Also can be used for tours and travels, camping, hotel, students, summer camps, skating, motels, service industry, and other corporate, business, photography and personal portfolio websites. Is simple, flexible and multipurpose with having multi industry use. Demo : http://sktperfectdemo.com/demos/adventure/

Theme URL - https://www.sktthemes.net/shop/free-travel-blog-wordpress-theme
Author URL - https://www.sktthemes.net

Trac Browser - https://themes.trac.wordpress.org/browser/adventure-lite/1.0

SVN - https://themes.svn.wordpress.org/adventure-lite/1.0
ZIP - https://wordpress.org/themes/download/adventure-lite.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/adventure-lite/1.0/screenshot.png

Change History (22)

#1 @themetracbot
8 weeks ago

  • Owner set to Iceable
  • Status changed from new to reviewing

#2 @Iceable
8 weeks ago

Hi @sonalsinha21, I just started reviewing this theme. I'll post my feedback here as soon as I can.

Best regards.

#3 @Iceable
8 weeks ago

Hi @sonalsinha21 , here is my review.
The theme is almost good to go but has a few issues that need fixing before being approved.

  • [REQUIRED] issues have to be fixed for the theme to be approved.
  • [Recommended] issues are not mandatory, but it would be nice to look into them.

Please fix at least all required issues and upload an updated version. I'm leaving this ticket open so the review can continue here when you update the theme.

Please note that if you do not post a response within 7 days, the ticket could be closed for inactivity.

REQUIRED

Code

  • [REQUIRED] Sniffer results:
    FILE: comments.php
    --------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------
     29 | ERROR | Missing singular placeholder, needed for some languages. See
        |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
    --------------------------------------------------------------------------------------------------------------
    
    
    FILE: inc/template-tags.php
    ----------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------------------
     64 | ERROR | Overriding WordPress globals is prohibited
     86 | ERROR | Strings should have translatable content
    ----------------------------------------------------------------------------------------------
    
  • [REQUIRED] header.php: pingback <link> should be conditional ( is_singular() && pings_open() )

Setting up and using the theme

  • [REQUIRED] Custom features and options should be explained or documented. Some documentation in readme.txt or inline explanations would be welcome about setting up the slider and "home sections". These are not obvious or self-explanatory, especially for new users.
  • [REQUIRED] Broken / unusable design:
    • If the site title/tagline area and navbar are too wide to fit on a single line, the navbar gets kicked to a second line below the header and becomes invisible (white text on white background) (screenshot)
      • You could make the header area expand to support multiple lines when necessary
      • If this is a limitation (i.e. the theme doesn't support long navbars and users should use short menus) then it should be explicitly documented.

https://i.imgur.com/wmZjmbN.png

  • [REQUIRED] Broken / unusable design:
    • If I set a site title and tagline, then the posts do not clear properly and the sidebar is pushed below the posts area (screenshot)

https://i.imgur.com/wkzOARl.png

Theme Unit test

  • [REQUIRED] Clearing floats: if the last element of a post's content is a floated image, the next element (tags) is not cleared properly. Similar issue in pages, pagination links after a floated element are not cleared.
  • [REQUIRED] (broken design) 404 error page: CSS applied to body.error404 .search-form also affects any search widget in the sidebar which looks broken (screenshot)

https://i.imgur.com/RgwVKD5.png

  • [REQUIRED] Theme URI leads to a 404 error page

Recommended

Code

  • [Recommended] header.php: <div class="header_wrap layer_wrapper"> is closed before the actual header content begins and is empty as a result. I'm pretty sure you it was meant to wrap around the header content. If not it can probably be removed completely.
  • [Recommended] Indentation in your code seems to randomly alternate between tabs, 2-spaces and 4-spaces. Consistent and proper indentation would look much cleaner and make the code easier to read. Also some lines end with a random amount of tabs or spaces, this isn't an actual issue either but really doesn't look clean.

Setting up and using the theme

  • [Recommended] The theme recommends a size of 1600x200px for a header image, but the area it is displayed in has a fixed height of 80px
  • [Recommended] If I set a page without featured image as "slide", it displays as a never ending "loading" icon in the center, with a broken img tag at the top left. It would be better to fail gracefully.

Theme Unit test

  • [Recommended] 404 page says "Dont worry", which should be spelled "Don't worry" instead.
  • [Recommended] Sticky post: You have CSS styles targeting the class .tag-sticky-2, a class specific to the "sticky" tag in the theme unit test. So this styling will not apply to any sticky post without this tag. You should use the .sticky selector instead, which is the class WordPress core gives to posts that are actually sticky. (Note that this class is only given to sticky posts on the index, not in single view.)
  • [Recommended] Gallery: I think the gallery shortcode could use clearing to avoid looking weird next to the floated featured image (screenshot)

https://i.imgur.com/kgYjsh0l.png

  • [Recommended] Videos: $content_width is set to 640px in functions.php, but the post content area is actually 790px (not an actual issue, but videos are embedded in a 640px iframe where they could take more of the available space and look better)

Selling, credits and links

  • [Recommended] The title and description of the page in Appearance > About Theme are "About Theme Info" and "Description Goes Here". You'll probably want to change this
  • [Recommended] Your "Upgrade to pro" button in the customizer points to the pro version of another one of your theme ("Play School"). I think you'll want to update this too :)

#4 @themetracbot
8 weeks ago

  • Summary changed from THEME: Adventure Lite – 1.0 to THEME: Adventure Lite – 1.1

Adventure Lite - 1.1

Adventure Lite WordPress theme can be used for adventure, sports, hiking, trekking, railing, rafting, games, fun, elking, hunting, military, mountain climbing, skiing, surfing and other such adventure sports. Also can be used for tours and travels, camping, hotel, students, summer camps, skating, motels, service industry, and other corporate, business, photography and personal portfolio websites. Is simple, flexible and multipurpose with having multi industry use. Demo : http://sktperfectdemo.com/demos/adventure/

Theme URL - https://www.sktthemes.net/shop/free-travel-blog-wordpress-theme/
Author URL - https://www.sktthemes.net

Trac Browser - https://themes.trac.wordpress.org/browser/adventure-lite/1.1

SVN - https://themes.svn.wordpress.org/adventure-lite/1.1
ZIP - https://wordpress.org/themes/download/adventure-lite.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=adventure-lite/1.0&new_path=adventure-lite/1.1

History:


https://themes.svn.wordpress.org/adventure-lite/1.1/screenshot.png

#5 @sonalsinha21
8 weeks ago

@Iceable : Hi,

Have updated the theme as per your review. Thank you.

#6 @Iceable
8 weeks ago

Hi @sonalsinha21, thank you for uploading a revised version.

All required issues seem fixed, except one small thing:

  • [REQUIRED] Clearing floats: if the last element of a post's content is a floated image, the next element (tags) is not cleared properly.

This is ok for pages now, but not for single posts.
In theme unit tests, you can see it at the end of the "Markup: Image Alignment" post.
Simply adding clear: both; to the .postmeta selector in CSS would fix this.

I also appreciate the fact that you took the time to go through most of the "recommended" issues to further improve the theme.

Please fix this last small thing and I will mark the theme as approved - after which an admin will perform a final review.

#7 @themetracbot
7 weeks ago

  • Summary changed from THEME: Adventure Lite – 1.1 to THEME: Adventure Lite – 1.2

Adventure Lite - 1.2

Adventure Lite WordPress theme can be used for adventure, sports, hiking, trekking, railing, rafting, games, fun, elking, hunting, military, mountain climbing, skiing, surfing and other such adventure sports. Also can be used for tours and travels, camping, hotel, students, summer camps, skating, motels, service industry, and other corporate, business, photography and personal portfolio websites. Is simple, flexible and multipurpose with having multi industry use. Demo : http://sktperfectdemo.com/demos/adventure/

Theme URL - https://www.sktthemes.net/shop/free-travel-blog-wordpress-theme/
Author URL - https://www.sktthemes.net

Trac Browser - https://themes.trac.wordpress.org/browser/adventure-lite/1.2

SVN - https://themes.svn.wordpress.org/adventure-lite/1.2
ZIP - https://wordpress.org/themes/download/adventure-lite.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=adventure-lite/1.1&new_path=adventure-lite/1.2

History:


https://themes.svn.wordpress.org/adventure-lite/1.2/screenshot.png

#8 @sonalsinha21
7 weeks ago

@Iceable : Thank you for your review. Have updated the theme.

#9 @Iceable
7 weeks ago

  • Status changed from reviewing to approved

@sonalsinha21 thanks for the update!

All required issues have been addressed and the theme looks ok to me now so I'll mark it as approved.

It will then go to the final review queue for an admin to double check before going live.

I cannot give you an ETA for this, but you can see how the final queue is going here: https://themes.trac.wordpress.org/report/24

#10 @rabmalin
7 weeks ago

  • Status changed from approved to reopened

#11 @rabmalin
7 weeks ago

  • Cc rabmalin added
  • Status changed from reopened to reviewing

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Can you please explain why do we need this code?
    add_action( 'admin_head', 'admin_header_css' );
    function admin_header_css(){ ?>
    	<style>pre{white-space: pre-wrap;}</style><?php
    }
    
  • REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/
  • REQUIRED: WordPress Features First - Use WordPress functionality and features first, if available. https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features Eg, use the_archive_title() to display archive title in archive templates. Use the_archive_description() for archive description.
  • REQUIRED: style.css - At least one relevant subject tag is required (Max 3 subject tags allowed). https://make.wordpress.org/themes/handbook/review/required/theme-tags/
  • REQUIRED: Inline style found in several places. Please use enqueue approach.
  • REQUIRED: Make sure excerpt_length filter does not affect admin side. See Twenty Seventeen theme for reference.

#12 @themetracbot
7 weeks ago

  • Summary changed from THEME: Adventure Lite – 1.2 to THEME: Adventure Lite – 1.3

Adventure Lite - 1.3

Adventure Lite WordPress theme can be used for adventure, sports, hiking, trekking, railing, rafting, games, fun, elking, hunting, military, mountain climbing, skiing, surfing and other such adventure sports. Also can be used for tours and travels, camping, hotel, students, summer camps, skating, motels, service industry, and other corporate, business, photography and personal portfolio websites. Is simple, flexible and multipurpose with having multi industry use. Demo : http://sktperfectdemo.com/demos/adventure/

Theme URL - https://www.sktthemes.net/shop/free-travel-blog-wordpress-theme/
Author URL - https://www.sktthemes.net

Trac Browser - https://themes.trac.wordpress.org/browser/adventure-lite/1.3

SVN - https://themes.svn.wordpress.org/adventure-lite/1.3
ZIP - https://wordpress.org/themes/download/adventure-lite.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=adventure-lite/1.2&new_path=adventure-lite/1.3

History:


https://themes.svn.wordpress.org/adventure-lite/1.3/screenshot.png

#13 @sonalsinha21
7 weeks ago

@rabmalin : Hey have updated the theme as per your review.

Thanks.

#14 @rabmalin
6 weeks ago

Issues

  • REQUIRED: Inline style found in several places. Please use enqueue approach. eg, customizer.php L14. Please check in other places also.
  • REQUIRED: class-customize.php L94, 96 - Prefixing issue
  • REQUIRED: Remove adventure_lite_admin_header_style() and adventure_lite_admin_header_image(). [Deprecated]
  • REQUIRED: Escape get_header_image() with esc_url().
  • REQUIRED: Use the_archive_title() to display archive title in archive templates. Check category.php
  • REQUIRED: add_editor_style( 'editor-style.css' ); - But you have file adventure-lite-editor-style.css. Have you at least checked whether admin editor style is working or not?
  • REQUIRED: functions.php L142 - Prefixing issue

#15 @themetracbot
6 weeks ago

  • Summary changed from THEME: Adventure Lite – 1.3 to THEME: Adventure Lite – 1.4

Adventure Lite - 1.4

Adventure Lite WordPress theme can be used for adventure, sports, hiking, trekking, railing, rafting, games, fun, elking, hunting, military, mountain climbing, skiing, surfing and other such adventure sports. Also can be used for tours and travels, camping, hotel, students, summer camps, skating, motels, service industry, and other corporate, business, photography and personal portfolio websites. Is simple, flexible and multipurpose with having multi industry use. Demo : http://sktperfectdemo.com/demos/adventure/

Theme URL - https://www.sktthemes.net/shop/free-travel-blog-wordpress-theme/
Author URL - https://www.sktthemes.net

Trac Browser - https://themes.trac.wordpress.org/browser/adventure-lite/1.4

SVN - https://themes.svn.wordpress.org/adventure-lite/1.4
ZIP - https://wordpress.org/themes/download/adventure-lite.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=adventure-lite/1.3&new_path=adventure-lite/1.4

History:


https://themes.svn.wordpress.org/adventure-lite/1.4/screenshot.png

#16 @sonalsinha21
6 weeks ago

@rabmalin: Thank you have updated the theme as per your review.

#17 @rabmalin
6 weeks ago

  • Cc rabmalin removed
  • Resolution set to live
  • Status changed from reviewing to closed

Setting live.

#18 @greenshady
4 weeks ago

It has been brought to our attention that your theme is using the holiday tag but is not a holiday/seasonal theme. You need to remove this tag from your theme.

#19 @sonalsinha21
4 weeks ago

@greenshady : Hi,

The theme is based on adventure sports which I believe happens mostly during holidays. Hence I added that tag.

#20 @greenshady
4 weeks ago

The theme itself should be related to a specific holiday. For example, Christmas.

#21 @sonalsinha21
4 weeks ago

OK tomorrow morning will update the theme. It's almost midnight here in India.

#22 @sonalsinha21
4 weeks ago

@greenshady : Have updated the theme.

Note: See TracTickets for help on using tickets.