WordPress.org

Make WordPress Themes

Opened 4 months ago

Last modified 21 hours ago

#45762 reviewing theme

THEME: Sleekr Lite – 2.0.3

Reported by: Chefopld Owned by: gookaani
Priority: previously reviewed Keywords: theme-sleekr-lite
Cc: chefopld@…

Description

Sleekr Lite - 1.0.2

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience.

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/1.0.2

SVN - https://themes.svn.wordpress.org/sleekr-lite/1.0.2
ZIP - https://wordpress.org/themes/download/sleekr-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/1.0.1&new_path=sleekr-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/1.0.2/screenshot.png

Attachments (3)

Change History (27)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Sleekr Lite – 1.0.2 to THEME: Sleekr Lite – 1.0.3

Sleekr Lite - 1.0.3

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience.

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/1.0.3

SVN - https://themes.svn.wordpress.org/sleekr-lite/1.0.3
ZIP - https://wordpress.org/themes/download/sleekr-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/1.0.2&new_path=sleekr-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/1.0.3/screenshot.png

#2 @themetracbot
4 months ago

  • Summary changed from THEME: Sleekr Lite – 1.0.3 to THEME: Sleekr Lite – 1.0.4

Sleekr Lite - 1.0.4

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience. For questions and feedback <a href="mailto:office@…">office@…</a>

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/1.0.4

SVN - https://themes.svn.wordpress.org/sleekr-lite/1.0.4
ZIP - https://wordpress.org/themes/download/sleekr-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/1.0.3&new_path=sleekr-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/1.0.4/screenshot.png

#3 @poena
2 months ago

Hi
This is not a complete review.
Please make sure that all your text is translation ready. There is some text in the theme that is missing translation functions.

Use WordPress functionality and features first, if available.
This includes using the standard site icon option for the favicon instead of custom code.

#4 @themetracbot
2 months ago

  • Summary changed from THEME: Sleekr Lite – 1.0.4 to THEME: Sleekr Lite – 1.0.5

Sleekr Lite - 1.0.5

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience. For questions and feedback <a href="mailto:office@…">office@…</a>

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/1.0.5

SVN - https://themes.svn.wordpress.org/sleekr-lite/1.0.5
ZIP - https://wordpress.org/themes/download/sleekr-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/1.0.4&new_path=sleekr-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/1.0.5/screenshot.png

#5 @Chefopld
2 months ago

Hey there,

I did remove the custom favicon code but I can't seem to find the text without translating functions you are referring to.

#6 @gookaani
7 weeks ago

  • Owner set to gookaani
  • Status changed from new to reviewing

Hello @Chefopld

Reviewers are now allowed to close the ticket if your theme has more than 5+ distinct issues, so make sure your theme developed based on org's handbook.

https://make.wordpress.org/themes/handbook/review/required/
If you want to update the theme, update within 48 hours, or else I'll start to review the latest version of the theme.

#7 @themetracbot
7 weeks ago

  • Summary changed from THEME: Sleekr Lite – 1.0.5 to THEME: Sleekr Lite – 2.0.0

Sleekr Lite - 2.0.0

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience. For questions and feedback <a href="mailto:office@…">office@…</a>

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/2.0.0

SVN - https://themes.svn.wordpress.org/sleekr-lite/2.0.0
ZIP - https://wordpress.org/themes/download/sleekr-lite.2.0.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/1.0.5&new_path=sleekr-lite/2.0.0

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/2.0.0/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are sleekr-lite, theme-textdomain

#8 @themetracbot
7 weeks ago

  • Summary changed from THEME: Sleekr Lite – 2.0.0 to THEME: Sleekr Lite – 2.0.1

Sleekr Lite - 2.0.1

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience. For questions and feedback <a href="mailto:office@…">office@…</a>

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/2.0.1

SVN - https://themes.svn.wordpress.org/sleekr-lite/2.0.1
ZIP - https://wordpress.org/themes/download/sleekr-lite.2.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/2.0.0&new_path=sleekr-lite/2.0.1

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/2.0.1/screenshot.png

#9 @gookaani
7 weeks ago

Hello @Chefopld

  • Themes need to include license and copyright information for all assets including stylesheets, scripts, fonts and images (even images used in the screenshot and images that comes with the theme).
  • Declare copyright of your theme like the example below in readme.txt file
    == Copyright ==
    
    Theme name WordPress Theme, Copyright 2016 Company
    Theme name is distributed under the terms of the GNU GPL
    
  • Missing changelog records for the latest versions of the theme.
  • Be sure to test and develop your theme with a latest stable version of WordPress to meet the newest requirements. According to theme's readme file, you have tested up to WordPress 4.8.
  • Your approach for enqueueing comment-reply.js is NOT correct and restricted with lots of additional statements! - Remove this one (!is_admin())

For your reference check this example from underscore theme:
https://github.com/Automattic/_s/blob/master/functions.php

  • All theme modification values should be escaped properly before displaying.
  • Remove search-form from add_theme_support( 'html5' ) as you are customizing it by yourself.
  • Remove comment-form from add_theme_support( 'html5' ) as you are customizing it by yourself.
  • Remove comment-list from add_theme_support( 'html5' ) as you are customizing it by yourself.
  • For generating stylesheets, you should add any dynamic styles to wp_add_inline_style since it depends and overrides main styles. - Check functions.php
  • The theme language file needs an update for a newly added string; You need to regenerate it using Poedit.
  • Make sure all the functions are prefixed this includes 3rd party imported class and libraries like Bootstrap_NavWalker
  • The custom-colors tag does not specifically mean that you can change the theme color. That tag says Custom ColorS (PLURAL) - Changing the color of ONE element in ONE place can be done with a simple CSS line. Please modify your tag, because it is misleading.
  • I wasn't able to change the header image through the Customizer; it keeps loading the bundled image only!
  • Check the following error regarding the WordPress gallery shortcode.
    Warning: array_merge(): Argument #2 is not an array in /home/vol6_4/XXXX.com/XXX_19918808/htdocs/wp-content/themes/sleekr-lite/functions/gallery-shortcode.php on line 11
    
  • Consider adding more styles for standard HTML elements like headings, blockquotes, etc.
  • All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation Eg, esc_url() should be used to escape URL, value in HTML attributes should be escaped with esc_attr().

#10 @Chefopld
7 weeks ago

Hey there @gookaani, I have fixed almost everything you mentioned. What I can't find is the custom-colors tags, from what I can see it hasn't been used in any version of the theme, you are referring to the theme tags in the style.css, right?

#11 @gookaani
7 weeks ago

@Chefopld

Sorry, my bad. Take your time to fix the remaining issues and upload a new version of the theme as soon as you finished.

#12 @themetracbot
6 weeks ago

  • Summary changed from THEME: Sleekr Lite – 2.0.1 to THEME: Sleekr Lite – 2.0.2

Sleekr Lite - 2.0.2

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience. For questions and feedback <a href="mailto:office@…">office@…</a>

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/2.0.2

SVN - https://themes.svn.wordpress.org/sleekr-lite/2.0.2
ZIP - https://wordpress.org/themes/download/sleekr-lite.2.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/2.0.1&new_path=sleekr-lite/2.0.2

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/2.0.2/screenshot.png

#13 @gookaani
6 weeks ago

Hello @Chefopld

  • License and license URI declaration on style.css and readme.txt files are NOT valid.

Here is an example of the header part of style.css
https://developer.wordpress.org/themes/basics/main-stylesheet-style-css/#example

  • Missing editor-style.css - Remove the tag and method or add a valid CSS file to style WP editor properly.
  • Remove any HTML tags from theme description content.
  • Themes need to include license and copyright information for all assets including stylesheets, scripts, fonts and images (even images used in the screenshot and images that comes with the theme) - Check popper.js and all other files thoroughly.
  • Missing bundled header image URL.
  • By the time of writing this stable version of WordPress 4.9 is NOT released yet! You should test and develop your theme based on latest stable version.
  • Fancybox handle is NOT correct, modify it to jquery-fancybox OR fancyBox.
  • Check the following error:
    TypeError: undefined is not an object (evaluating 'i.jquery')
    https://XXXX.com/wp-content/themes/sleekr-lite/js/popper.min.js?ver=4.8.3 line 4
    
  • All theme modification values should be escaped properly before displaying.

Install Theme Sniffer plugin and make sure your theme meets all standards required by WPTRT/WordPress-Coding-Standards.
https://github.com/WPTRT/theme-sniffer#option-1-easy
ERRORS need to be fixed and WARNINGS are things that need to be checked manually.

  • Remove any development files from theme including SCSS and LESS files - Theme should be production ready.

You can optionally host these files on a Github repo or someplace else on your website.

  • Your approach to overriding header image control on Customizer is entirely inappropriate.

You are not allowed to override any default (core) WordPress controls by registering it again.
https://codex.wordpress.org/Custom_Headers
Use get_setting to retrieve the current labels and modify it afterward.
https://codex.wordpress.org/Class_Reference/WP_Customize_Manager/get_setting

*IMPORTANT*

Allocate more time to fix all the required issues and take your time to walk through WordPress Handbook with care, since reviewers are now allowed to close the ticket if your theme has more than 5+ distinct issues, so make sure your theme developed based on org's handbook.
https://make.wordpress.org/themes/handbook/review/required/
*So far your theme should have been closed twice***

#14 @gookaani
5 weeks ago

Hello @Chefopld

Theme authors must post an update within 7 days. It has been 7 days since the review. Please post an update.

Last edited 5 weeks ago by gookaani (previous) (diff)

#15 @Chefopld
5 weeks ago

Hey there @gookaani, I was very sick the past 7 days but I'm alright now and I will fix the mentioned issues and upload a new version in the next couple of days, sorry for the delay.

#16 @Chefopld
4 weeks ago

Hey again @gookaani, almost everything you mentioned is fixed. I have a few questions though.

First, for the missing bundled header image URL, should I use a theme relative URL like: sleekr-header.png or an URL from somewhere on the net where the image can be seen?

Secondly, Popper and Glyphicons which I believe you are referencing to when talking about missing copyright information, they are part of the Bootstrap package and that is why I didn't think to list such information for them. Should I add them to the Bootstrap license info like this:

Sleekr Light WordPress Theme incorporates code from Bootstrap, Copyright 2011-2017 Twitter, Inc - http://getbootstrap.com/
Bootstrap is distributed under the terms of The MIT License (MIT) - https://github.com/twbs/bootstrap/blob/master/LICENSE
Popper - /js/popper.js & Glyphicons - /fonts/ are included in the Bootstrap package and as such are distributed under the same license.

or list them separately?

As for the Customizer header image control, the purpose is to have the option for 2 separate header images for the home page and for everything else. The code I use is directly taken from the WordPress Theme Handbook and can be found here:
https://developer.wordpress.org/themes/customize-api/tools-for-improved-user-experience/

Thank you for your time and patience.

#17 @gookaani
4 weeks ago

Hello @Chefopld

  • Include full page URL that you have downloaded the images of.
  • Include proper and detailed credits for any 3rd party resources that you used while developing your theme.
  • Then register a new control and leave default header image control as is.

#18 @Chefopld
4 weeks ago

Thank you @gookaani,

regarding the 3rd issue, a new control is already registered and even if I switch their positions (home page/everything else), I would still need to limit the default header to the home page only with the function from the WP.org's Theme Handbook. Why can't I use it if it is listed in the Handbook?

#19 @gookaani
4 weeks ago

@Chefopld

I'm not sure what you are trying to achieve at this time but try to update your theme ASAP so I can take a look at your approach in details.

#20 @themetracbot
3 weeks ago

  • Summary changed from THEME: Sleekr Lite – 2.0.2 to THEME: Sleekr Lite – 2.0.3

Sleekr Lite - 2.0.3

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience.

Theme URL - https://www.webhostface.com/wordpress-themes/sleekr-lite/
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/2.0.3

SVN - https://themes.svn.wordpress.org/sleekr-lite/2.0.3
ZIP - https://wordpress.org/themes/download/sleekr-lite.2.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/2.0.2&new_path=sleekr-lite/2.0.3

History:

Ticket Summary Status Resolution Owner
#44144 THEME: Sleekr Lite – 1.0.1 closed not-approved codexdemon
#45762 THEME: Sleekr Lite – 2.0.3 reviewing gookaani

(this ticket)


https://themes.svn.wordpress.org/sleekr-lite/2.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#21 @gookaani
2 weeks ago

Hello @Chefopld

  • Theme URI has to be somewhere which provides additional information about the theme itself. Either remove the current theme URI or change it to a standalone page instead.
  • Section labels and formatting of readme file is NOT valid, and some of the essential information like "Stable tag" is missing. See revised readme file:

https://make.wordpress.org/themes/2015/04/29/a-revised-readme/
https://github.com/Automattic/_s/blob/master/readme.txt

  • Bump WordPress tested up version to 4.9.1
  • Found missing changelog record for the latest theme release, besides I don't see enough information regarding your changes and changelog seems too generic to me. Try to add more details as much as you can/recall.
  • Remove PHP closing tag from functions.php file since it can break or freeze the site due to extra whitespace after it. Note that opening tags are REQUIRED, closing tags are ONLY needed if you have other code (HTML, CSS) after them in the same file. See PHP manual:

http://www.php.net/manual/en/language.basic-syntax.phptags.php
https://github.com/Automattic/_s/blob/master/functions.php

  • Remove featured-image-header tag from style.css file since I don't see any outputs of a featured image in place of custom header image on single-post view.
  • I don't see any use of jqBootstrapValidation on your theme since this plugin only affects Bootstrap based forms and required specific class names to function please remove it from your theme files.
  • The WordPress theme should make use of the following inbuilt functions to validate or sanitize content on input or escape any questionable content for output:

CHEK ALL THEME FILES THOROUGHLY - Eg. breadcrumbs.php

For input:

  • wp_filter_nohtml_kses()
  • wp_filter_kses()
  • wp_kses()

For output:

  • esc_attr()
  • esc_html()
  • esc_js()
  • esc_textarea()
  • esc_url()
  • Breadcrumb output prints plain HTML tags on single-post view.
  • Saved settings under Sleekr Theme Options on theme Customizer won't change anything after closing customizer panel. See the screencast (1) below.
  • I am unable to view uploaded header image on Customizer panel. See the screencast (2) below.
  • All of WordPress' default widgets should be styled/display appropriately in all widgetized areas.
  • I can see three existing widgets on sidebar without adding any widget to the "Main Sidebar" widget area.
  • You need to use a localized format of date function based on timestamp. Update date('Y') to date_i18n(__('Y','text-domain')).
  • Bootstrap_NavWalker class needs to be prefixed with the theme slug.
  • Themes must not have any JavaScript notices, warnings, or errors - please develop with errors enabled, and debug bar plugin installed on your end. See the screencast (3) below.

Despite all the issues mentioned above, I'm afraid you are NOT allocating enough time to fix all these problems without missing simple things and doing a quick test of your changes on your own and to prevent turning your ticket into coding school I have no choice to close your ticket if I find more than three distinct issues next time.

#22 @gookaani
9 days ago

Theme authors must post an update within 7 days. Please post an update.

#23 @Chefopld
8 days ago

Hey @gookaani, thanks for all the suggestions, I'm currently fixing them and will upload a new theme update within the next 2 days.

#24 @Chefopld
21 hours ago

Hey again gookaani, I'm terribly sorry for the delay, I'm trying to fix it as soon as possible.

Note: See TracTickets for help on using tickets.