WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 4 months ago

Last modified 3 weeks ago

#46081 closed theme (live)

THEME: OnePress – 1.4.3

Reported by: FameThemes Owned by: themetracbot
Priority: theme update Keywords: theme-onepress
Cc: contact@…

Description

OnePress - 1.4.3

OnePress is an outstanding creative and flexible WordPress one page theme well suited for business website, portfolio, digital agency, product showcase, freelancers and everyone else who appreciate good design. The theme overall is an elegant and classic one, a fine example of Bootstrap 4 WordPress theme which compatibility with latest version of WooCommerce. (Live preview : http://www.famethemes.com/preview/?theme=OnePress)

Theme URL - https://www.famethemes.com/themes/onepress/
Author URL - http://www.famethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/onepress/1.4.3

SVN - https://themes.svn.wordpress.org/onepress/1.4.3
ZIP - https://wordpress.org/themes/download/onepress.1.4.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=onepress/1.4.2&new_path=onepress/1.4.3

History:

Ticket Summary Status Resolution Owner
#27818 THEME: OnePress – 1.0.9 closed live thee17
#30476 THEME: OnePress – 1.1.2 closed live jcastaneda
#30806 THEME: OnePress – 1.1.3 closed live jcastaneda
#30852 THEME: OnePress Transparent – 1.0.0 closed closed-newer-version-uploaded
#30941 THEME: OnePress – 1.1.4 closed live Otto42
#31354 THEME: OnePress – 1.1.5 closed live themetracbot
#31360 THEME: OnePress – 1.1.6 closed live themetracbot
#31437 THEME: OnePress – 1.1.7 closed live themetracbot
#31699 THEME: OnePress – 1.1.8 closed live themetracbot
#32157 THEME: OnePress – 1.1.9 closed live themetracbot
#32237 THEME: OnePress – 1.2.0 closed live themetracbot
#32864 THEME: OnePress – 1.2.1 closed live themetracbot
#33122 THEME: OnePress – 1.2.2 closed live themetracbot
#33557 THEME: OnePress – 1.2.3 closed live themetracbot
#33566 THEME: OnePress – 1.2.4 closed live themetracbot
#36565 THEME: OnePress – 1.2.5 closed live themetracbot
#36879 THEME: OnePress – 1.2.6 closed live themetracbot
#37166 THEME: OnePress – 1.2.7 closed live themetracbot
#37516 THEME: OnePress – 1.2.8 closed live themetracbot
#37709 THEME: OnePress – 1.2.9 closed live themetracbot
#38641 THEME: OnePress – 1.3.0 closed live themetracbot
#40668 THEME: OnePress_Trang – 1.3.1 closed not-approved rabmalin
#40877 THEME: OnePress – 1.3.1 closed live themetracbot
#40886 THEME: OnePress – 1.3.2 closed live themetracbot
#40900 THEME: OnePress – 1.3.3 closed live themetracbot
#41105 THEME: OnePress – 1.3.4 closed live themetracbot
#41223 THEME: OnePress – 1.3.5 closed live themetracbot
#41900 THEME: OnePress – 1.3.6 closed live themetracbot
#43350 THEME: OnePress – 1.3.7 closed live themetracbot
#43424 THEME: OnePress – 1.3.8 closed live themetracbot
#45117 THEME: OnePress – 1.3.9 closed live themetracbot
#45140 THEME: OnePress – 1.4.0 closed live themetracbot
#45184 THEME: OnePress – 1.4.1 closed live themetracbot
#46051 THEME: OnePress – 1.4.2 closed live themetracbot
#46081 THEME: OnePress – 1.4.3 closed live themetracbot

(this ticket)

#48781 THEME: OnePress – 2.0.0 closed live themetracbot
#48833 THEME: OnePress – 2.0.1 closed live themetracbot
#48868 THEME: OnePress – 2.0.2 closed live themetracbot


https://themes.svn.wordpress.org/onepress/1.4.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Change History (8)

#1 @themetracbot
4 months ago

  • Owner set to themetracbot
  • Status changed from new to reviewing

Theme Update for existing Live theme - automatically reviewed

#2 @themetracbot
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Theme Update for existing Live theme - automatically approved

#3 @rabmalin
5 weeks ago

  • Cc rabmalin added

Hello @FameThemes

NOTE: Please fix issues and reupload your theme within 2 days. Mention here if you need more time. If not fixed then, your theme will be suspended from the directory.

  • For upsell in Customizer, injecting HTML through JS is not allowed. You can use like this - https://github.com/justintadlock/trt-customizer-pro Reference - https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#selling-credits-and-links
  • Actions Required - This implies that theme wont work unless those actions are performed. It is not allowed to make plugins or actions required. Please change it to Recommended Actions or similar.
  • Never use wp_reset_query() - To reset custom query, wp_reset_postdata() should be used.
  • Escape get_permalink() with esc_url().
  • Escaping missing in several other places also. Eg, footer.php L73, 74, etc. Check onepress_custom_inline_style(). Please check theme thoroughly.
  • Removing core settings is not allowed. Use appropriate alternative approach if you want to customize core controls.
    $wp_customize->remove_section( 'colors' );
    $wp_customize->remove_section( 'background_image' );
    

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/onepress/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 31 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

FILE: /var/www/review.dev/public_html/wp-content/themes/onepress/inc/template-tags.php
--------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------
 208 | ERROR | Overriding WordPress globals is prohibited
 240 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------

#4 follow-up: @FameThemes
5 weeks ago

Hi, @rabmalin

We're going to fix it.
Maybe we'll need more than 2 days to fix it but not more than 5 days for sure.
We have some questions and maybe we'll add you later.

#5 in reply to: ↑ 4 @rabmalin
5 weeks ago

Replying to FameThemes:

Hi, @rabmalin

We're going to fix it.
Maybe we'll need more than 2 days to fix it but not more than 5 days for sure.
We have some questions and maybe we'll add you later.

Sure, no problem. If any confusion, you can comment here.

#6 @rabmalin
4 weeks ago

@FameThemes Any updates?

#7 @FameThemes
4 weeks ago

Hi @rabmalin,

All issues you mention has been fixed (https://github.com/FameThemes/onepress/issues). However, we are having a hard time to work with other features plus its Black Friday time. So we will try out best to upload the new version next week.

If you require any further information, please let me know.

#8 @rabmalin
3 weeks ago

  • Cc rabmalin removed

Thanks for updating.

Note: See TracTickets for help on using tickets.