WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 2 days ago

#46115 closed theme (live)

THEME: York Lite – 1.1.0

Reported by: themebeans Owned by: ravioza
Priority: previously reviewed Keywords: theme-york-lite
Cc: rich@…, Mirucon

Description

York Lite - 1.0.2

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.2

SVN - https://themes.svn.wordpress.org/york-lite/1.0.2
ZIP - https://wordpress.org/themes/download/york-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.1&new_path=york-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

Change History (39)

#1 @themetracbot
6 weeks ago

  • Owner set to radu.constantin
  • Status changed from new to reviewing

#2 @rabmalin
5 weeks ago

  • Owner radu.constantin deleted

Returning ticket back to review queue for new reviewer.

#3 @themetracbot
5 weeks ago

  • Owner set to wponlinesupport

#4 @wponlinesupport
5 weeks ago

Hello @themebeans,

Its a nice clean theme BUT i have few questions.

1) Have you tested your theme with multilevel menu?
2) Side bar widget got stuck when there are more then 1 widget(no scroll bar)
3) What is the use of front-page.php file?

#5 @themebeans
5 weeks ago

Hi @wponlinesupport! 👋

Appreciate it! Sure:

  1. I have now! I'll have an update here shortly with multi-menu support.
  1. Thanks for pointing that out. I've also resolved this in the update.
  1. The front-page.php file pulls in the portfolio post types, if the theme is set to display a home page (similar to how Twenty Seventeen does it). https://d26dzxoao6i3hh.cloudfront.net/items/2l0I2m0w1u3H0Q2k2k1y/Screen%20Shot%202017-11-15%20at%2010.13.59%20PM.njzR.png

Thanks!
Rich

#6 @themetracbot
5 weeks ago

  • Summary changed from THEME: York Lite – 1.0.2 to THEME: York Lite – 1.0.3

York Lite - 1.0.3

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.3

SVN - https://themes.svn.wordpress.org/york-lite/1.0.3
ZIP - https://wordpress.org/themes/download/york-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.2&new_path=york-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#7 @themetracbot
5 weeks ago

  • Summary changed from THEME: York Lite – 1.0.3 to THEME: York Lite – 1.0.4

York Lite - 1.0.4

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.4

SVN - https://themes.svn.wordpress.org/york-lite/1.0.4
ZIP - https://wordpress.org/themes/download/york-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.3&new_path=york-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#8 @wponlinesupport
5 weeks ago

Hello @themebeans,

Thanks for submitting the theme again BUT still there is an issue in menu bar. All multilevel menu bar drop down showing at the top and not working well.

For portfolio, i am not able to see any post type created. Am i right?

#9 @themebeans
5 weeks ago

Hi @wponlinesupport

Are you not seeing this here (image below)? If not, could you provide a bit more detail. I'm not quite understanding. The post type is not created within the plugin, though users may use the Portfolio Post Type plugin from the repository.

https://d26dzxoao6i3hh.cloudfront.net/items/2s1x0k0g2A3K3r202q2w/Screen%20Shot%202017-11-16%20at%2012.41.06%20PM.nlH5.png

#10 @wponlinesupport
4 weeks ago

Hello @themebeans ,

1) You can see here for menu bar : https://screenshots.firefox.com/UdztHqKJsUjFsYGF/localhost
Here About this Test Page has all sub menus BUT its showing arrows in front of HOME link. That means some position issue :)

2) As your theme based on portfolio, you should recommend a Portfolio plugin because as i can see you are using Post Type = 'post_type' => 'portfolio', and every plugin register their own post type so its very difficult for a new user that is using WordPress 1st time OR used for many time to display the Portfolio.

Make sure all function added in your theme should work properly :)

#11 @themebeans
4 weeks ago

Thanks @wponlinesupport!

  1. I appreciate the detail. I figured out what was going on there with the menus. Thanks for catching that!
  1. Good point. I've added the TGMPA class and recommended the Portfolio Post Type plugin from the WordPress repository.

I'll have an update pushed here shortly. Thanks again!

#12 @themetracbot
4 weeks ago

  • Summary changed from THEME: York Lite – 1.0.4 to THEME: York Lite – 1.0.5

York Lite - 1.0.5

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.5

SVN - https://themes.svn.wordpress.org/york-lite/1.0.5
ZIP - https://wordpress.org/themes/download/york-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.4&new_path=york-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#13 @wponlinesupport
4 weeks ago

Hello @themebeans ,

Still there is issue in your theme.

1) Menu bar : 1st label menu is ok now BUT 2ns label menu is not working fine (If i click on 2nd label menu, its not working)

2) Single.php for portfolio post type displaying :
eddfue_options: a:7:{s:7:"subject";s:0:"";s:11:"sendingUnit";i:2;s:12:"sendingValue";i:2;s:9:"orderType";s:7:"publish";s:13:"productFilter";i:0;s:30:"productFilter_specificProducts";a:0:{}s:32:"productFilter_specificCategories";a:0:{}}


#14 follow-up: @themebeans
3 weeks ago

Hi @wponlinesupport

1) Are you not getting the menu to open? I'm not quite following? This is what I'm getting, if I open both up.

http://cl.ly/nvO3/Screen%20Shot%202017-11-26%20at%204.19.19%20AM.png

2) I'm not understanding what you're getting for the single.php for the portfolio post type. Is that output you're getting on the singular portfolio post view? This is what I'm getting:

http://cl.ly/nvvW/Screen%20Shot%202017-11-26%20at%204.22.18%20AM.png

#15 @rabmalin
3 weeks ago

  • Owner wponlinesupport deleted

Returning ticket back to review queue for new reviewer.

#16 @themetracbot
2 weeks ago

  • Owner set to ravioza

#17 in reply to: ↑ 14 @ravioza
2 weeks ago

Hi @themebeans

  • Required :
  • Multilevel Menu with more then 1 level is not working. To reproduce this, you can try adding 1 more submenu to the submenu item and test. It looks like menu depth issue.
  • I didn't find an option to customize Text color under Customizer > Colors.

#18 @themetracbot
2 weeks ago

  • Summary changed from THEME: York Lite – 1.0.5 to THEME: York Lite – 1.0.6

York Lite - 1.0.6

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.6

SVN - https://themes.svn.wordpress.org/york-lite/1.0.6
ZIP - https://wordpress.org/themes/download/york-lite.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.5&new_path=york-lite/1.0.6

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#19 @themebeans
2 weeks ago

Thanks for the review and feedback @ravioza. I've improved the multi-level support for the navigation, modified the credit to point to the correct URL and added a Customizer color option to modify the text colors.

I really do appreciate your time helping me to make this theme great. Thanks again!

#20 @ravioza
2 weeks ago

@themebeans,

  • Required :
    • Theme URI is still pointing to the York Pro version. changes in style.css is required.
  • Notes :
    • 'depth' => '0' will remove the restriction for the Multilevel Menu level. Right now it shows 2 level of the submenus.
    • Text color change is reflecting on the nav manu, but not the background color.


#21 @themetracbot
2 weeks ago

  • Summary changed from THEME: York Lite – 1.0.6 to THEME: York Lite – 1.0.7

York Lite - 1.0.7

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.7

SVN - https://themes.svn.wordpress.org/york-lite/1.0.7
ZIP - https://wordpress.org/themes/download/york-lite.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.6&new_path=york-lite/1.0.7

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#22 @themebeans
2 weeks ago

@ravioza You're right! Thanks. I've fixed both. 👍

#23 @ravioza
13 days ago

@themebeans

Great!!

  • Note:
    • I wanted to highlight, possible use case of text color customisation. With White text color #fff, your menu items are not usable/ visible for the users. Please refer the screenshot https://imgur.com/a/xnmJW

#24 @themetracbot
13 days ago

  • Summary changed from THEME: York Lite – 1.0.7 to THEME: York Lite – 1.0.8

York Lite - 1.0.8

York Lite is a beautiful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.8

SVN - https://themes.svn.wordpress.org/york-lite/1.0.8
ZIP - https://wordpress.org/themes/download/york-lite.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.7&new_path=york-lite/1.0.8

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#25 follow-up: @themebeans
13 days ago

Thanks again @ravioza!

That was a good catch. So I made the background color control also modify the sidebar/nav background, and extended the text color selector to also modify a icons and such throughout. This way the design of the site will be more cohesive, no matter what colors the user chooses for the background and foreground text elements.

Cheers!

#26 in reply to: ↑ 25 @ravioza
13 days ago

  • Status changed from reviewing to approved

Replying to themebeans:
👍

Thanks again @ravioza!

That was a good catch. So I made the background color control also modify the sidebar/nav background, and extended the text color selector to also modify a icons and such throughout. This way the design of the site will be more cohesive, no matter what colors the user chooses for the background and foreground text elements.

Cheers!

#27 @Mirucon
7 days ago

  • Cc Mirucon added

I will do this final. I'll get back to you within the next few days!

#28 @Mirucon
6 days ago

  • Status changed from approved to reopened

#29 @Mirucon
6 days ago

  • Status changed from reopened to reviewing

Nice well-written theme and compatible with the WordPress Coding Standards :) There are just a few issues that need to be fixed.

  • In your readme file, there should be credits of all the resources you bundled in the theme, including images used in the screenshot.
  • Please declare proper credit for trt-customizer-pro, tgm-plugin-activation in your readme.
  • esc_attr() should be used inside of attributes, inc/customizer/class-york-range-control.php L52

#30 @ravioza
4 days ago

@themebeans,

Make the required changes mentioned by @Mirucon and submit the updated theme.

#31 @themetracbot
4 days ago

  • Summary changed from THEME: York Lite – 1.0.8 to THEME: York Lite – 1.0.9

York Lite - 1.0.9

York Lite is a beautiful portfolio WordPress theme for photographers, creatives, freelancers and agencies alike. York lite features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless and professional website.

Theme URL - https://themebeans.com/themes/york
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.9

SVN - https://themes.svn.wordpress.org/york-lite/1.0.9
ZIP - https://wordpress.org/themes/download/york-lite.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.8&new_path=york-lite/1.0.9

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#32 @themebeans
4 days ago

@ravioza Thanks! I missed the last review comment. I made the recommended changes, as well as a few other minor improvements (mostly PHPCS touch-ups). Thanks!

#33 @Mirucon
3 days ago

Hi @themebeans,

Thanks for the update, mostly looking good. However, the theme uses Unsplash images which are not allowed in the directory, because they are no longer GPL compatible. You will need to change all the images that are from Unsplash.

Once you make these changes, your theme will be available from the directory.

#34 @themebeans
3 days ago

@Mirucon Ok I can do that. I do see that TwentySeventeen does as well. Is that retroactive?

#35 @Mirucon
3 days ago

@themebeans This is what we require for themes, which is Be 100% GPL and/or 100% GPL-compatible licensed.. https://make.wordpress.org/themes/handbook/review/required/#licensing

You can see here for a little bit more information about Unsplash. Its images used to be CC0 which is GPL-compatible, until 8th of June. Now they have a different license, which is not GPL-compatible. Themes that are uploaded the images before the day, they may continue using the images. But any of themes that are uploaded after the license has changed cannot use the images.

#36 @rabmalin
3 days ago

Theme submitted before June 9 can continue using Unsplash images. But your theme was submitted 8/31/17 which is clearly after June 9. :-)

Last edited 3 days ago by rabmalin (previous) (diff)

#37 @themebeans
3 days ago

Ahh, thanks for the information! I'll get the update pushed here in the next few minutes.

#38 @themetracbot
3 days ago

  • Summary changed from THEME: York Lite – 1.0.9 to THEME: York Lite – 1.1.0

York Lite - 1.1.0

York Lite is a beautiful portfolio WordPress theme for photographers, creatives, freelancers and agencies alike. York lite features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless and professional website.

Theme URL - https://themebeans.com/themes/york
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.1.0

SVN - https://themes.svn.wordpress.org/york-lite/1.1.0
ZIP - https://wordpress.org/themes/download/york-lite.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.9&new_path=york-lite/1.1.0

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin
#46115 THEME: York Lite – 1.1.0 closed live ravioza

(this ticket)


https://themes.svn.wordpress.org/york-lite/1.1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#39 @Mirucon
2 days ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good, setting theme live.

Your theme will show up in the directory shortly. Good luck with the theme!

Note: See TracTickets for help on using tickets.