WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 5 weeks ago

#46160 closed theme (live)

THEME: Nora – 1.0.14

Reported by: GeJay Owned by: rabmalin
Priority: previously reviewed Keywords: theme-nora
Cc: social@…

Description

Nora - 1.0.13

Nora is a free ecommerce theme developed for perfectionists’ eye. It is integrated with WooCommerce and compatible with Jetpack Plugin so allows you the flexibility of adding multiple functionalities in your website. Designed using bootstrap, its clarity and templating style will allow emphasizing the content that you have on your site. This theme is best to be used by corporate houses, online shopping stores along with image, text and video bloggers

Theme URL - https://www.styledthemes.com/themes/nora/
Author URL - https://www.styledthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/nora/1.0.13

SVN - https://themes.svn.wordpress.org/nora/1.0.13
ZIP - https://wordpress.org/themes/download/nora.1.0.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=nora/1.0.12&new_path=nora/1.0.13

History:

Ticket Summary Status Resolution Owner
#31531 THEME: Nora – 1.0.2 closed not-approved greenshady
#36364 THEME: Nora – 1.0.3 closed not-approved kevinhaig
#44162 THEME: Nora – 1.0.12 closed not-approved gookaani
#46160 THEME: Nora – 1.0.14 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/nora/1.0.13/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (5)

#1 @rabmalin
6 weeks ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#2 @rabmalin
6 weeks ago

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: global $more - Custom global variable should be prefixed with theme slug.
  • REQUIRED: require_once '/includes/wc-template-functions.php'; - I am not sure why are you adding like this? Can you please explain? Moreover, use get_template_directory() to load non template PHP files.
  • REQUIRED: title="<?php _e( 'My Account', 'nora' ); ?>" - In HTML attributes, use esc_attr_e() instead of _e().
  • REQUIRED: nora-function.php L120 - Escaping missing in href
  • REQUIRED: POT filename should be nora.pot. OR you can remove whole languages folder if you want to take advantage of WordPress Language Pack.
  • REQUIRED: Escape admin_url() with esc_url().
  • REQUIRED: Nora WordPress Theme, Copyright 2016 WordPress.org - I guess copyright is not correct. Copyright owner should be you.
  • REQUIRED: Unminified version of jquery.isotope.min.js missing.
  • REQUIRED: Isotope library before 2.2.0 is not GPL compatible. Check https://github.com/metafizzy/isotope/releases

#3 @themetracbot
5 weeks ago

  • Summary changed from THEME: Nora – 1.0.13 to THEME: Nora – 1.0.14

Nora - 1.0.14

Nora is a free ecommerce theme developed for perfectionists’ eye. It is integrated with WooCommerce and compatible with Jetpack Plugin so allows you the flexibility of adding multiple functionalities in your website. Designed using bootstrap, its clarity and templating style will allow emphasizing the content that you have on your site. This theme is best to be used by corporate houses, online shopping stores along with image, text and video bloggers

Theme URL - https://www.styledthemes.com/themes/nora/
Author URL - https://www.styledthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/nora/1.0.14

SVN - https://themes.svn.wordpress.org/nora/1.0.14
ZIP - https://wordpress.org/themes/download/nora.1.0.14.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=nora/1.0.13&new_path=nora/1.0.14

History:

Ticket Summary Status Resolution Owner
#31531 THEME: Nora – 1.0.2 closed not-approved greenshady
#36364 THEME: Nora – 1.0.3 closed not-approved kevinhaig
#44162 THEME: Nora – 1.0.12 closed not-approved gookaani
#46160 THEME: Nora – 1.0.14 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/nora/1.0.14/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @GeJay
5 weeks ago

Hi,

Thank You for reviewing our theme. We have uploaded new version of Nora WordPress theme.

REQUIRED: global $more - Custom global variable should be prefixed with theme slug.

Done

REQUIRED: require_once '/includes/wc-template-functions.php'; - I am not sure why are you adding like this? Can you please explain? Moreover, use get_template_directory() to load non template PHP files.

Done

REQUIRED: title="<?php e( 'My Account', 'nora' ); ?>" - In HTML attributes, use esc_attr_e() instead of e().

Done

REQUIRED: nora-function.php L120 - Escaping missing in href

Done

REQUIRED: POT filename should be nora.pot. OR you can remove whole languages folder if you want to take advantage of WordPress Language Pack.

Done removed the whole language folder.

REQUIRED: Escape admin_url() with esc_url().

Done

REQUIRED: Nora WordPress Theme, Copyright 2016 WordPress.org - I guess copyright is not correct. Copyright owner should be you.

Done

REQUIRED: Unminified version of jquery.isotope.min.js missing.
REQUIRED: Isotope library before 2.2.0 is not GPL compatible. Check https://github.com/metafizzy/isotope/releases

Done

If there are any additional issues please send us.

Thanks

#5 @rabmalin
5 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Setting live.

Note: See TracTickets for help on using tickets.