WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 2 days ago

#46202 closed theme (live)

THEME: The Journal – 1.0.11

Reported by: themefusecom Owned by: mkronenfeld
Priority: previously reviewed Keywords: theme-the-journal
Cc: hello@…

Description

The Journal - 1.0.8

The Journal is a clean cut, modern WordPress theme perfect for bloggers, an online magazine or publishers in general. Visually interesting and stylish, while also letting the content shine, this is a hidden gem. The back end is powered by our popular <a href="https://wordpress.org/plugins/unyson/">Unyson framework plugin</a> that comes with a bunch of features that will make your live easier like a visual page builder, automated back-ups, styling &amp; typography settings and much more.

Theme URL - https://demo.themefuse.com/journal/
Author URL - https://themefuse.com/

Trac Browser - https://themes.trac.wordpress.org/browser/the-journal/1.0.8

SVN - https://themes.svn.wordpress.org/the-journal/1.0.8
ZIP - https://wordpress.org/themes/download/the-journal.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=the-journal/1.0.1&new_path=the-journal/1.0.8

History:

Ticket Summary Status Resolution Owner
#28961 THEME: The Journal – 1.0.1 closed not-approved swetashrestha
#46202 THEME: The Journal – 1.0.11 closed live mkronenfeld

(this ticket)


https://themes.svn.wordpress.org/the-journal/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

Attachments (3)

the-journal.zip (2.0 MB) - added by themefusecom 5 weeks ago.
the-journal.2.zip (2.0 MB) - added by themefusecom 5 weeks ago.
the-journal.3.zip (2.0 MB) - added by themefusecom 5 weeks ago.
fixed issues

Change History (23)

#1 @rabmalin
6 weeks ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#2 @rabmalin
6 weeks ago

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/
  • REQUIRED: In TGM configuration, is_automatic should be false and dismissable should be true.
  • REQUIRED: Remove unused files.
  • REQUIRED: Update readme file to keep credits and license info of all third party resources (like scripts, styles, libraries, images, etc). Sample format: https://make.wordpress.org/themes/2015/04/29/a-revised-readme/
  • REQUIRED: Escape get_permalink() with esc_url().
  • REQUIRED: FW_Extension_ThemeFuse_Update - This is plugin territory. Custom updater is not allowed in theme.

Theme looks pretty heavy, Please re-upload your theme and I will review in more depth.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/the-journal/comments-template.php
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
 14 | ERROR | Overriding WordPress globals is prohibited
-----------------------------------------------------------------------------------------

Time: 25170420 mins, 51.14 secs; Memory: 2Mb

FILE: ...l/framework-customizations/extensions/forms/extensions/contact-forms/shortcodes/contact-form/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
 93 | ERROR | Strings should have translatable content
 94 | ERROR | Strings should have translatable content
 95 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 51.41 secs; Memory: 4Mb

FILE: ...es/the-journal/framework-customizations/extensions/media/extensions/slider/shortcodes/slider/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 52.2 secs; Memory: 2Mb

FILE: ...ntent/themes/the-journal/framework-customizations/extensions/shortcodes/shortcodes/accordion/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 26 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 52.64 secs; Memory: 2Mb

FILE: ...-content/themes/the-journal/framework-customizations/extensions/shortcodes/shortcodes/button/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 28 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 52.81 secs; Memory: 2Mb

FILE: ...wp-content/themes/the-journal/framework-customizations/extensions/shortcodes/shortcodes/icon/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 30 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 53.27 secs; Memory: 2Mb

FILE: .../wp-content/themes/the-journal/framework-customizations/extensions/shortcodes/shortcodes/map/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 100 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 53.78 secs; Memory: 4Mb

FILE: ...content/themes/the-journal/framework-customizations/extensions/shortcodes/shortcodes/section/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------
 45 | ERROR | Strings should have translatable content
 72 | ERROR | Strings should have translatable content
 79 | ERROR | Strings should have translatable content
 91 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 54.59 secs; Memory: 4Mb

FILE: ...ent/themes/the-journal/framework-customizations/extensions/shortcodes/shortcodes/widget-area/options.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 8 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 55.87 secs; Memory: 2Mb

FILE: ...view.dev/public_html/wp-content/themes/the-journal/framework-customizations/theme/options/customizer.php
--------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------------------------------------------
  49 | ERROR | Strings should have translatable content
 159 | ERROR | Strings should have translatable content
 165 | ERROR | Strings should have translatable content
 642 | ERROR | Strings should have translatable content
 652 | ERROR | Strings should have translatable content
 658 | ERROR | Strings should have translatable content
 666 | ERROR | Strings should have translatable content
 691 | ERROR | Strings should have translatable content
 835 | ERROR | Strings should have translatable content
 842 | ERROR | Strings should have translatable content
 849 | ERROR | Strings should have translatable content
 856 | ERROR | Strings should have translatable content
--------------------------------------------------------------------------------------------------------------

Time: 25170420 mins, 56.27 secs; Memory: 14Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/the-journal/theme-includes/helpers.php
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 1284 | ERROR | Strings should have translatable content
----------------------------------------------------------------------------------------------

Time: 25170421 mins, 0.01 secs; Memory: 14Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/the-journal/theme-includes/hooks.php
--------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
  552 | ERROR | [ ] Silencing errors is forbidden
  583 | ERROR | [ ] Silencing errors is forbidden
 1200 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s, %3$s, %4$s', but got %s,
      |       |     %s, %s, %s.
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

#3 follow-up: @themefusecom
5 weeks ago

REQUIRED: Remove unused files.

  • we use less files here, I don’t know what you mean here, can you give us more details?

#4 in reply to: ↑ 3 ; follow-up: @rabmalin
5 weeks ago

Replying to themefusecom:

REQUIRED: Remove unused files.

  • we use less files here, I don’t know what you mean here, can you give us more details?

Eg, sub-includes.php, posts.php, etc

@themefusecom
5 weeks ago

fixed issues

#5 in reply to: ↑ 4 @themefusecom
5 weeks ago

Replying to rabmalin:

Hi,

can you check now pls.

#6 @rabmalin
5 weeks ago

Please upload your theme from here. https://wordpress.org/themes/upload/

#7 @themetracbot
5 weeks ago

  • Summary changed from THEME: The Journal – 1.0.8 to THEME: The Journal – 1.0.9

The Journal - 1.0.9

The Journal is a clean cut, modern WordPress theme perfect for bloggers, an online magazine or publishers in general. Visually interesting and stylish, while also letting the content shine, this is a hidden gem. The back end is powered by our popular <a href="https://wordpress.org/plugins/unyson/">Unyson framework plugin</a> that comes with a bunch of features that will make your live easier like a visual page builder, automated back-ups, styling &amp; typography settings and much more.

Theme URL - https://demo.themefuse.com/journal/
Author URL - https://themefuse.com/

Trac Browser - https://themes.trac.wordpress.org/browser/the-journal/1.0.9

SVN - https://themes.svn.wordpress.org/the-journal/1.0.9
ZIP - https://wordpress.org/themes/download/the-journal.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=the-journal/1.0.8&new_path=the-journal/1.0.9

History:

Ticket Summary Status Resolution Owner
#28961 THEME: The Journal – 1.0.1 closed not-approved swetashrestha
#46202 THEME: The Journal – 1.0.11 closed live mkronenfeld

(this ticket)


https://themes.svn.wordpress.org/the-journal/1.0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

#8 @rabmalin
4 weeks ago

Prvious Issues Not Fixed

Issues

  • REQUIRED: Theme URL is invalid. https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links
  • REQUIRED: Never use wp_reset_query(). Function wp_reset_postdata() should be used to reset custom query.
  • REQUIRED: Screenshot - What Parent Theme is screenshot? Is that part of theme? It is not allowed to add logo or extra mockup in the screenshot.
  • REQUIRED: Escape admin_url() with esc_url().
  • REQUIRED: add_image_size( 'fw-theme-blog-full', 1228, 691, true ); - Image size handle should be prefixed with theme slug. Please check other also.
  • REQUIRED: the_journal_action_theme_generate_styles() - CSS compiling is plugin territory. Please remove it.
  • REQUIRED: global $color_settings; - Custom global variables should be prefixed. Please check other also.
  • REQUIRED: the_journal_action_theme_count_post_visits() - Post views feature is plugin territory. Please remove it.
  • REQUIRED: define('WP_THEME_PREFIX', 'journal'); - Incorrect prefix of define variable. It should be prefixed with theme slug.
  • REQUIRED: update_option( 'dismissed-' . $type, TRUE ); - Custom option name should be prefixed.
  • REQUIRED: function get_the_archive_title() - Please remove it. This function is already available in core.
  • REQUIRED: Rather than creating custom pagination function the_journal_paging_nav(), please use the_posts_pagination().
  • REQUIRED: helpers.php L688, 695 - Escaping missing. Please check other also.
  • REQUIRED: the_journal_header_search() - Remove custom search form. Creating custom search form is not allowed. Use get_search_form() for search form. If you want to customize search form, you can use searchform.php.
  • REQUIRED: backend-static.php - Custom style handle should be prefixed. Check line 13, 21, etc.

There may more issues because above issues are only from half of your theme files. Please check your theme thoroughly.

Last edited 4 weeks ago by rabmalin (previous) (diff)

#9 @themetracbot
4 weeks ago

  • Summary changed from THEME: The Journal – 1.0.9 to THEME: The Journal – 1.0.10

The Journal - 1.0.10

The Journal is a clean cut, modern WordPress theme perfect for bloggers, an online magazine or publishers in general. Visually interesting and stylish, while also letting the content shine, this is a hidden gem. The back end is powered by our popular <a href="https://wordpress.org/plugins/unyson/">Unyson framework plugin</a> that comes with a bunch of features that will make your live easier like a visual page builder, automated back-ups, styling &amp; typography settings and much more.

Theme URL - https://themefuse.com/wp-themes-shop/journal/
Author URL - https://themefuse.com/

Trac Browser - https://themes.trac.wordpress.org/browser/the-journal/1.0.10

SVN - https://themes.svn.wordpress.org/the-journal/1.0.10
ZIP - https://wordpress.org/themes/download/the-journal.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=the-journal/1.0.9&new_path=the-journal/1.0.10

History:

Ticket Summary Status Resolution Owner
#28961 THEME: The Journal – 1.0.1 closed not-approved swetashrestha
#46202 THEME: The Journal – 1.0.11 closed live mkronenfeld

(this ticket)


https://themes.svn.wordpress.org/the-journal/1.0.10/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#10 @rabmalin
3 weeks ago

  • Owner rabmalin deleted

I will not be able to continue review. Returning ticket back to queue for new reviewer.

#11 @themefusecom
3 weeks ago

Hi,

can I know the reason? And how long will it take take?

#12 @themetracbot
2 weeks ago

  • Owner set to mkronenfeld

#13 @mkronenfeld
2 weeks ago

Hi @themefusecom

my name is Marvin and I am a Dev from Germany. I will continue with your theme review.

Previous Issues Not Fixed

  • REQUIRED: Custom option name should be prefixed. (theme-includes/helpers.php L1135, theme-includes/hooks.php L843)
  • REQUIRED: function get_the_archive_title() - You removed the class, but still call it in theme-includes/helpers.php L767
  • REQUIRED: Rather than creating custom pagination function the_journal_paging_nav(), please use the_posts_pagination().

Further Issues

  • REQUIRED: Localize your theme. Several strings for example in the post header or the footer are not translatable.
  • OPTIONAL: The menu button appears in the mobile version, even if you have not assigned a menu.

Theme Check Sniffs

No Errors, but 400+ of Warnings.

Code Check Sniffs

Duplicate array keys

  • framework-customizations/extensions/shortcodes/shortcodes/latest-posts/options.php L23 - L25
  • framework-customizations/extensions/shortcodes/shortcodes/team-member/views/view.php L18
  • framework-customizations/extensions/shortcodes/shortcodes/media-image/views/view.php L28
  • framework-customizations/theme/options/customizer.php L267 - L269

Incompatible return types

  • framework-customizations/extensions/portfolio/helpers.php L85
  • theme-includes/helpers.php L926
  • theme-includes/helpers.php L1079

Unused

  • Unused local variable $content_position_style

Conclusion

I really like the way your theme looks, but I had a hard time checking it.

Every Sniff returns literally hundreds of Warnings. This doesn't necessarily have to be a bad thing. However it is nearly impossible for a single reviewer to check them all.

I will not approve this theme in its current state. Please run the following checks and reduced the number of Warnings noticeable (vendor libraries and assets not included).

  1. Check your translations, f.e. with https://wordpress.org/plugins/piglatin/
  2. Check your theme, f.e. with https://github.com/WPTRT/theme-sniffer
  3. Check your code style, f.e. with the phpStorm Code Inspector.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Best regards
Marvin

Last edited 2 weeks ago by mkronenfeld (previous) (diff)

#14 @mkronenfeld
2 weeks ago

@rabmalin I hope I continued the review in your interest. Feel free to share advices from your past reviews of this theme with us.

#15 @themetracbot
11 days ago

  • Summary changed from THEME: The Journal – 1.0.10 to THEME: The Journal – 1.0.11

The Journal - 1.0.11

The Journal is a clean cut, modern WordPress theme perfect for bloggers, an online magazine or publishers in general. Visually interesting and stylish, while also letting the content shine, this is a hidden gem. The back end is powered by our popular <a href="https://wordpress.org/plugins/unyson/">Unyson framework plugin</a> that comes with a bunch of features that will make your live easier like a visual page builder, automated back-ups, styling &amp; typography settings and much more.

Theme URL - https://themefuse.com/wp-themes-shop/journal/
Author URL - https://themefuse.com/

Trac Browser - https://themes.trac.wordpress.org/browser/the-journal/1.0.11

SVN - https://themes.svn.wordpress.org/the-journal/1.0.11
ZIP - https://wordpress.org/themes/download/the-journal.1.0.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=the-journal/1.0.10&new_path=the-journal/1.0.11

History:

Ticket Summary Status Resolution Owner
#28961 THEME: The Journal – 1.0.1 closed not-approved swetashrestha
#46202 THEME: The Journal – 1.0.11 closed live mkronenfeld

(this ticket)


https://themes.svn.wordpress.org/the-journal/1.0.11/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

#16 @themefusecom
11 days ago

Hi Marvin,

we fixed all things that you say in the message, for clarification we will put here only the tasks that need more explanations.

Hope now the theme was accepted and we are open to discussion or clarification.

  • REQUIRED: function get_the_archive_title() - You removed the class, but still call it in theme-includes/helpers.php L767

— fixed, this function was added in WordPress core and the previous reviewer says to remove the “rewritet function” from our theme

  • REQUIRED: Rather than creating custom pagination function the_journal_paging_nav(), please use the_posts_pagination(). — fixed (we use the wp function now, but the previous custom function we forgot to remove, now we removed).

Further Issues

  • REQUIRED: Localize your theme. Several strings for example in the post header or the footer are not translatable.

— This words come from dashboard and are category or post title:

https://static.md/5add6d2f697eecc10e8674e397f21dd1.png

https://static.md/232cf9f8f1f34a21c6b61d9f8a0ffd8f.png

#17 @mkronenfeld
8 days ago

  • Status changed from reviewing to approved

Hi @themefusecom

thanks for your efforts.

For my flavor the code base is a bit too large, but you have solved every of our issues in the past. I can clearly see your willingess to improve your Theme step by step so will approve it right now.

Best regards
Marvin

#18 @themefusecom
7 days ago

Thanks Marvin for approving the theme. We'll do our best to improve it and be in line with the high quality standard you guys are keeping.

We've looked over and didn't see the theme in the WordPress repository? Does it take a while to appear there?

Have a great day.

#19 @benlumia007
2 days ago

@themefusecom

Please note that I will be doing the final review for this theme. Please give 24 hours to look through the theme

Thanks
@benlumia007

#20 @benlumia007
2 days ago

  • Resolution set to live
  • Status changed from approved to closed

@themefusecom

Congratulations, theme is now live, please wait for an hour to two hours for theme to be live in the repo.

Note: See TracTickets for help on using tickets.