WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 5 weeks ago

Last modified 5 weeks ago

#46322 closed theme (live)

THEME: MedZone Lite – 1.0.5

Reported by: machothemes Owned by: greenshady
Priority: new theme Keywords: theme-medzone-lite
Cc: office@…

Description

MedZone Lite - 1.0

MedZone Lite is a multipurpose WordPress medical theme that’s perfect for doctors, dentists, clinics, hospitals, medical research facilities, and any other medical institution under the sun!

Theme URL - https://www.machothemes.com/theme/medzone-lite
Author URL - https://www.machothemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/medzone-lite/1.0

SVN - https://themes.svn.wordpress.org/medzone-lite/1.0
ZIP - https://wordpress.org/themes/download/medzone-lite.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#46322 THEME: MedZone Lite – 1.0.5 closed live greenshady

(this ticket)

#48186 THEME: MedZone Lite – 1.0.6 closed live themetracbot
#48316 THEME: MedZone Lite – 1.0.7 closed live themetracbot
#48609 THEME: MedZone Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/medzone-lite/1.0/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are medzone-lite, epsilon-framework

Change History (13)

#1 @acosmin
3 months ago

@machothemes hi guys, would you like me to review this theme and speed things up?

I'm interested in the outcome.

#2 @themetracbot
2 months ago

  • Summary changed from THEME: MedZone Lite – 1.0 to THEME: MedZone Lite – 1.0.1

MedZone Lite - 1.0.1

MedZone Lite is a multipurpose WordPress medical theme that’s perfect for doctors, dentists, clinics, hospitals, medical research facilities, and any other medical institution under the sun! Beyond a style that’s perfectly suited for medical institutions, MedZone Lite also lets you quickly build your frontpage with unlimited, easy-to-use content sections. In addition to that, it also includes plenty of helpful sections like doctor listings, contact forms, hero sections, and call to action sections. And finally, MedZone Lite makes use of the real-time WordPress Customizer so that you can make detailed changes to your site in real-time, including helpful typography controls to let you change up the text on your site to fit your aesthetic. If you want to build a medicine-related website, MedZone Lite’s features and responsive design are perfectly suited to help you get up and running with a beautiful site in no time.

Theme URL - https://www.machothemes.com/theme/medzone-lite
Author URL - https://www.machothemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/medzone-lite/1.0.1

SVN - https://themes.svn.wordpress.org/medzone-lite/1.0.1
ZIP - https://wordpress.org/themes/download/medzone-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=medzone-lite/1.0&new_path=medzone-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#46322 THEME: MedZone Lite – 1.0.5 closed live greenshady

(this ticket)

#48186 THEME: MedZone Lite – 1.0.6 closed live themetracbot
#48316 THEME: MedZone Lite – 1.0.7 closed live themetracbot
#48609 THEME: MedZone Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/medzone-lite/1.0.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are medzone-lite, epsilon-framework

#3 @themetracbot
2 months ago

  • Summary changed from THEME: MedZone Lite – 1.0.1 to THEME: MedZone Lite – 1.0.2

MedZone Lite - 1.0.2

MedZone Lite is a multipurpose WordPress medical theme that’s perfect for doctors, dentists, clinics, hospitals, medical research facilities, and any other medical institution under the sun! Beyond a style that’s perfectly suited for medical institutions, MedZone Lite also lets you quickly build your frontpage with unlimited, easy-to-use content sections. In addition to that, it also includes plenty of helpful sections like doctor listings, contact forms, hero sections, and call to action sections. And finally, MedZone Lite makes use of the real-time WordPress Customizer so that you can make detailed changes to your site in real-time, including helpful typography controls to let you change up the text on your site to fit your aesthetic. If you want to build a medicine-related website, MedZone Lite’s features and responsive design are perfectly suited to help you get up and running with a beautiful site in no time.

Theme URL - https://www.machothemes.com/theme/medzone-lite
Author URL - https://www.machothemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/medzone-lite/1.0.2

SVN - https://themes.svn.wordpress.org/medzone-lite/1.0.2
ZIP - https://wordpress.org/themes/download/medzone-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=medzone-lite/1.0.1&new_path=medzone-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#46322 THEME: MedZone Lite – 1.0.5 closed live greenshady

(this ticket)

#48186 THEME: MedZone Lite – 1.0.6 closed live themetracbot
#48316 THEME: MedZone Lite – 1.0.7 closed live themetracbot
#48609 THEME: MedZone Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/medzone-lite/1.0.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are medzone-lite, epsilon-framework

#4 @themetracbot
2 months ago

  • Summary changed from THEME: MedZone Lite – 1.0.2 to THEME: MedZone Lite – 1.0.3

MedZone Lite - 1.0.3

MedZone Lite is a multipurpose WordPress medical theme that’s perfect for doctors, dentists, clinics, hospitals, medical research facilities, and any other medical institution under the sun! Beyond a style that’s perfectly suited for medical institutions, MedZone Lite also lets you quickly build your frontpage with unlimited, easy-to-use content sections. In addition to that, it also includes plenty of helpful sections like doctor listings, contact forms, hero sections, and call to action sections. And finally, MedZone Lite makes use of the real-time WordPress Customizer so that you can make detailed changes to your site in real-time, including helpful typography controls to let you change up the text on your site to fit your aesthetic. If you want to build a medicine-related website, MedZone Lite’s features and responsive design are perfectly suited to help you get up and running with a beautiful site in no time.

Theme URL - https://www.machothemes.com/theme/medzone-lite
Author URL - https://www.machothemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/medzone-lite/1.0.3

SVN - https://themes.svn.wordpress.org/medzone-lite/1.0.3
ZIP - https://wordpress.org/themes/download/medzone-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=medzone-lite/1.0.2&new_path=medzone-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#46322 THEME: MedZone Lite – 1.0.5 closed live greenshady

(this ticket)

#48186 THEME: MedZone Lite – 1.0.6 closed live themetracbot
#48316 THEME: MedZone Lite – 1.0.7 closed live themetracbot
#48609 THEME: MedZone Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/medzone-lite/1.0.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are medzone-lite, epsilon-framework

#5 @themetracbot
6 weeks ago

  • Summary changed from THEME: MedZone Lite – 1.0.3 to THEME: MedZone Lite – 1.0.4

MedZone Lite - 1.0.4

MedZone Lite is a multipurpose WordPress medical theme that’s perfect for doctors, dentists, clinics, hospitals, medical research facilities, and any other medical institution under the sun! Beyond a style that’s perfectly suited for medical institutions, MedZone Lite also lets you quickly build your frontpage with unlimited, easy-to-use content sections. In addition to that, it also includes plenty of helpful sections like doctor listings, contact forms, hero sections, and call to action sections. And finally, MedZone Lite makes use of the real-time WordPress Customizer so that you can make detailed changes to your site in real-time, including helpful typography controls to let you change up the text on your site to fit your aesthetic. If you want to build a medicine-related website, MedZone Lite’s features and responsive design are perfectly suited to help you get up and running with a beautiful site in no time.

Theme URL - https://www.machothemes.com/theme/medzone-lite
Author URL - https://www.machothemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/medzone-lite/1.0.4

SVN - https://themes.svn.wordpress.org/medzone-lite/1.0.4
ZIP - https://wordpress.org/themes/download/medzone-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=medzone-lite/1.0.3&new_path=medzone-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#46322 THEME: MedZone Lite – 1.0.5 closed live greenshady

(this ticket)

#48186 THEME: MedZone Lite – 1.0.6 closed live themetracbot
#48316 THEME: MedZone Lite – 1.0.7 closed live themetracbot
#48609 THEME: MedZone Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/medzone-lite/1.0.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are medzone-lite, epsilon-framework

#6 @greenshady
6 weeks ago

  • Owner set to greenshady
  • Status changed from new to reviewing

#7 @themetracbot
5 weeks ago

  • Summary changed from THEME: MedZone Lite – 1.0.4 to THEME: MedZone Lite – 1.0.5

MedZone Lite - 1.0.5

MedZone Lite is a multipurpose WordPress medical theme that’s perfect for doctors, dentists, clinics, hospitals, medical research facilities, and any other medical institution under the sun! Beyond a style that’s perfectly suited for medical institutions, MedZone Lite also lets you quickly build your frontpage with unlimited, easy-to-use content sections. In addition to that, it also includes plenty of helpful sections like doctor listings, contact forms, hero sections, and call to action sections. And finally, MedZone Lite makes use of the real-time WordPress Customizer so that you can make detailed changes to your site in real-time, including helpful typography controls to let you change up the text on your site to fit your aesthetic. If you want to build a medicine-related website, MedZone Lite’s features and responsive design are perfectly suited to help you get up and running with a beautiful site in no time.

Theme URL - https://www.machothemes.com/theme/medzone-lite
Author URL - https://www.machothemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/medzone-lite/1.0.5

SVN - https://themes.svn.wordpress.org/medzone-lite/1.0.5
ZIP - https://wordpress.org/themes/download/medzone-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=medzone-lite/1.0.4&new_path=medzone-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#46322 THEME: MedZone Lite – 1.0.5 closed live greenshady

(this ticket)

#48186 THEME: MedZone Lite – 1.0.6 closed live themetracbot
#48316 THEME: MedZone Lite – 1.0.7 closed live themetracbot
#48609 THEME: MedZone Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/medzone-lite/1.0.5/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are medzone-lite, epsilon-framework

#8 @greenshady
5 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good to go. Great work!

#9 @williampatton
5 weeks ago

Hi @machothemes,

Firstly thank you for providing your theme to the .org repository :) When themes like this one (speaking mostly about how page content is stored and handled) go live it paves the way for other themes to do similar things. With that being the case I would really like to be sure that other guidelines are followed so that when this theme is used as reference other authors do not borrow ideas that won't necessarily fit with the guidelines.

I had a quick look at this theme yesterday and spotted a few things that should be taken care if if you don't mind.

  • Theme creates 'headers already sent' notices, a lot of the AJAX actions are broken because of it but it likely causes issues elsewhere too. Whitespace added to the output from line 13 of functions.php.
  • Upsell in the customizer - there should only be 1 top level item added for upsell, in this theme there are 2 (3 if including the recommended actions section) items added.
    • Additionally all customizer items are required to be functional, one of the links in the upsell buttons is broken.
  • Themes should include unminified versions of any minified javascript that is bundled so that there is at least 1 copy that's somewhat human readable. In the epsilon framework there are some files that contain minified JS without any non-minified variants available. \inc\libraries\epsilon-framework\assets\js

I'm also not 100% comfortable saying that the upsell (and constant reminds of what free version users are missing) spread throughout the theme is ok. To me if feels very obtrusive. Themes at .org are not supposed to be advertisements for the pro version, they should function fine as-is and you should not be constantly reminding people what they are missing out on if they don't pay for the pro version. This kind of obtrusive upsell has been discussed several times in the TRT slack channel. Here is a link to one particular comment which indicates that such upsell is frowned upon: https://wordpress.slack.com/archives/C02RP4Y3K/p1452712288006414

If you need any clarification on these points or would like additional opinions let me know and I'll try to explain better or get another reviewer to provide additional opinions.

#10 @machothemes
5 weeks ago

Hi @williampatton,

first off - thank you for taking the time to review our theme. I'm glad that you feel it paves the way for future theme shops, it's an honour to hear that!

  • AJAX issues: we'll look into this, we weren't aware they were broken. Could you please tell me the exact steps you took or what AJAX requests you saw as being broken? Was anything not working for you, in particular?
  • Upsells: There is only one upsell in the customizer. I think there's might be a slight confusion here, since we're using the same custom control that @greenshady built for adding upsells to add a link to our theme's documentation page. The recommendations box was approved as-is and is considered fine as it can be collapsed or hidden from the user's view. I can agree that sometimes it can feel a bit obtrusive, but this has actually given me an idea. We'll add a 3rd filter to our framework to make this go away - thanks for the idea. Highly appreciated!
  • Minified JS files: I knew about this rule but I probably missed it. We'll make sure to add the unminified JS files to our next update. Sorry about that, I don't know how it slipped past me.

I also wanted to thank you for your concerns regarding our theme upsells. You've raised a valid point and I'll look into it with the rest of our team and see what we can do about it.

This is currently not very public, but we do include two filters in our framework that allow the users to hide all of the theme's upsells from the Customizer as well as hide the LITE vs PRO comparison page in the theme's "About Page" panel. Your point made me realise that we should have made this more public for the user. I'll make sure to add something in our documentation regarding this, maybe others will want to follow our example then as well.

Thank you for taking the time to review our theme and bringing up all these points. We'll be working on making MedZone an even better product, with the community's help.

Have a great one,
Cristian.

Last edited 5 weeks ago by machothemes (previous) (diff)

#11 @williampatton
5 weeks ago

Hey again Christian,

I appreciate you being receptive to my points. I'm just wanting to be sure that when I reference this theme as an example that everything in it (not just the handling of the custom homepage) can be used for as a good example of doing it right. I do not believe anything I mentioned was done intentionally :)

  • The AJAX issues seem to be in relation to the headers already sent messages created in line 13 of functions.php (there's a single line of whitespace between a closing php tag on line 12 and another opening one on line 14). It causes issues with things like activating plugins, swapping between themes and adding/updating pages and posts. It probably affects some other things too which I didn't notice.
  • Upsells: If these are pre-approved by someone else I can let this go (with the caveat that personally I feel that it's too much). I did not see that there are filters to hide these. I'm a massive fan of that idea. Anyone who decides to dig into the code will find a nice surprise when they spot those :D
    • As a side note the links to in-theme documentation still point to 'medzone' instead of 'medzone-lite' which is why the links in customizer are broken.
  • Minified JS: yep I figured this was just overlooked because it's part of the framework and probably included as part of your theme scaffolding :)

The headers already sent message I see:

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/themes/medzone-lite/functions.php:13) in /var/www/html/wp-admin/includes/misc.php on line 1114

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/themes/medzone-lite/functions.php:13) in /var/www/html/wp-includes/option.php on line 919

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/themes/medzone-lite/functions.php:13) in /var/www/html/wp-includes/option.php on line 920

For reference my test setup uses PHP7.1 and is configured with mostly default upstream settings for apache and php. It's built from this exact dockerfile: https://raw.githubusercontent.com/pattonwebz/wordpress-php7-1-apache-memcached/2f6db3253dd4304bfa75f55f754c5191efaba021/Dockerfile and the script I use to reset and install the theme is this: https://gist.github.com/pattonwebz/8e4f40adb4516f6226270a7257385dfc (if you use this for reset you will only need to update the --url to match the url of your test install and user/password on line 7.

Feel free to keep in touch via the ticket or by posting in slack. My DMs are always open on slack if you wanted to DM me instead :)

#12 @machothemes
5 weeks ago

@williampatton - MedZone Lite version 1.0.6 has been uploaded. It has a fix for the AJAX issue you've reported as well as the new privacy tab that allows a user to disable the theme upsell and recommended plugins section that's being displayed inside the Customizer.

More so, I misspoke when I said that the un-minified source files aren't already bundled with the framework. You can find them in: assets/vendor/epsilon-framework.

Thanks,
Cristian.

#13 @williampatton
5 weeks ago

Hey @machothemes,

Glad the feedback was useful for you.

The privacy tab is something I am a big fan of so keep ideas like that coming.

Also I missed where the origin of the JS files was coming from when I first looked. I now see the source is included in that directory.

Looks good to me :)

Note: See TracTickets for help on using tickets.