WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 29 hours ago

#46375 reviewing theme

THEME: Fotopress – 1.0.0

Reported by: desirepress Owned by: wpstart
Priority: new theme Keywords: theme-fotopress
Cc: info@…

Description

Fotopress - 1.0.0

Fotopress is a flexible, fully responsive, SEO-friendly WordPress business theme made for creative use and to promote your corporate identity to engage more clients.

Theme URL - https://desirepress.com/themes/fotopress
Author URL - https://desirepress.com

Trac Browser - https://themes.trac.wordpress.org/browser/fotopress/1.0.0

SVN - https://themes.svn.wordpress.org/fotopress/1.0.0
ZIP - https://wordpress.org/themes/download/fotopress.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/fotopress/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Change History (16)

#1 @imranaliweb
4 weeks ago

  • Owner set to imranaliweb
  • Status changed from new to reviewing

#2 @desirepress
4 weeks ago

Hello @imranaliweb,

Can you please let us know that till when we can get your valuable feedback on our FotoPress Theme.

Regards,
Desirepress

#3 @imranaliweb
4 weeks ago

Hi @desirepress ,

I will post my feedback for your theme as soon as I complete my review.
Please give me few days.

Thanks
Imran ali

#4 @imranaliweb
3 weeks ago

Hi @desirepress ,

Your theme has been reviewed against this Theme Review Guideline.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

ISSUES

  • REQUIRED: Please implement proper sanitization for values when saved to database. https://codex.wordpress.org/Data_Validation#Input_Validation Eg, sanitize_text_field() should be used to sanitize text field, esc_url_raw for URL field, for sanitizing field with HTML tags, use wp_kses_post() for sanitization, use absint() to sanitize positive integer.
  • REQUIRED: Logo feature is not working.
  • Remove all default value with get_theme_mod in Home Page Template.
  • REQUIRED: In readme file, please declare your theme copyright in following format.

"Fred WordPress Theme, Copyright 2012 Joe Smith
Fred is distributed under the terms of the GNU GPL"

  • REQUIRED: Translation strings in HTML attribute needs escaping also. Please check thoroughly. Eg, inside placeholder, <?php printf( ( 'Search Results for : %s', 'fotopress' ) ?> should be <?php esc_attr_e('Search Results for : %s', 'fotopress'); ?>

Thanks

#5 @desirepress
3 weeks ago

Hello @imranaliweb,

I have solved maximum of your points, but having some issue in some....

1)REQUIRED: Logo feature is not working.
-- I have checked this, and its working, can you please elaborate this in detail.

2)REQUIRED: Translation strings in HTML attribute needs escaping also. Please check thoroughly. Eg, inside placeholder, <?php printf( ( 'Search Results for : %s', 'fotopress' ) ?> should be <?php esc_attr_e('Search Results for : %s', 'fotopress'); ?>

-- For this point, i have replace the code for printf like this....
<?php esc_attr_e( 'Category Archives : '.single_cat_title( , false ), 'fotopress' );?>

and this giving me warning on theme check:

Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.
The domains found are fotopress

Can you please explain me above points, so that i can resolve this.

Please let me know.

Thanks

Last edited 2 weeks ago by desirepress (previous) (diff)

#6 @desirepress
2 weeks ago

Hello @imranaliweb,

Can you please reply us for above comments, so that we can resolve these issue asap and resubmit the theme.

Regards,
Desirepress

This ticket was mentioned in Slack in #themereview by desirepress. View the logs.


5 days ago

#8 @kafleg
5 days ago

  • Owner imranaliweb deleted

Hello @desirepress,
You can check your theme by using the below two plugins,

https://wordpress.org/plugins/theme-check/
https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]
Hope all the issues mentioned by the previous reviewer is fixed in this version.

This plugin will help to know the issues mentioned by the reviewers.

Make sure your theme is developed based on the guidelines. https://make.wordpress.org/themes/handbook/review/required/
Before re-submitting themes, please check Theme Review Guidelines very thoroughly.

#9 @themetracbot
5 days ago

  • Owner set to wpstart

#10 @rabmalin
3 days ago

  • Owner wpstart deleted

#11 @desirepress
3 days ago

Hello @rabmalin,

Can you please help us to know about the reviewer who will review our theme.

Regards,
Desirepress

#12 @rabmalin
3 days ago

It is moved back to review queue. New reviewer will be assigned soon. Check queue here - https://themes.trac.wordpress.org/report/2

#13 @wpstart
2 days ago

@rabmalin I thought reviewer had given 3days to review the theme and we are just 2 days at the moment. I wonder why I was deleted. :)

you can assign it to me again and the feedback will place shortly.

thanks

#14 @rabmalin
2 days ago

  • Owner set to wpstart

@wpstart I moved ticket back to queue as you did not post first comment within 2 days. In the future review, at least make a hello comment within 2 days that you are going to review :-)

#15 @wpstart
2 days ago

@rabmalin noted :)

#16 @wpstart
29 hours ago

@desirepress

here are couple issues:

Front-end

  • on archives: -- https://content.screencast.com/users/Gio_28/folders/Jing/media/49d07387-a227-40e3-8881-dab95dd28cc8/2017-12-15_0332.png

Codes:

  • searchform.php --> remove Form ID to ovoid issue when user put multiple search form in a page
  • header.php --> syntax error on line 94


Other than that theme looks great

Note: See TracTickets for help on using tickets.