WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 2 months ago

#46380 closed theme (live)

THEME: shopstudio – 1.0.4

Reported by: dots Owned by: kevinhaig
Priority: new theme Keywords: theme-shopstudio
Cc: wordpress@…

Description

shopstudio - 1.0.0

shopstudio is a new theme that allows you to create woocommerce store easily.

Theme URL -
Author URL - https://profiles.wordpress.org/dots

Trac Browser - https://themes.trac.wordpress.org/browser/shopstudio/1.0.0

SVN - https://themes.svn.wordpress.org/shopstudio/1.0.0
ZIP - https://wordpress.org/themes/download/shopstudio.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/shopstudio/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (13)

#1 @themetracbot
3 months ago

  • Summary changed from THEME: shopstudio – 1.0.0 to THEME: shopstudio – 1.0.1

shopstudio - 1.0.1

shopstudio is a new theme that allows you to create woocommerce store easily.

Theme URL -
Author URL - https://profiles.wordpress.org/dots

Trac Browser - https://themes.trac.wordpress.org/browser/shopstudio/1.0.1

SVN - https://themes.svn.wordpress.org/shopstudio/1.0.1
ZIP - https://wordpress.org/themes/download/shopstudio.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shopstudio/1.0.0&new_path=shopstudio/1.0.1

History:


https://themes.svn.wordpress.org/shopstudio/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#2 @themetracbot
2 months ago

  • Owner set to walksteve
  • Status changed from new to reviewing

#3 @Mirucon
2 months ago

  • Owner walksteve deleted

@walksteve You should post the initial review within 48 hours since you are assigned to a ticket. If you want to get assigned back to this ticket, feel free to dm me in Slack.

The ticket is returning back to the queue.

#4 @kevinhaig
2 months ago

  • Owner set to kevinhaig

#5 @kevinhaig
2 months ago

Theme Review - shopstudio Version 1.0.1

  • Hi I am @kevinhaig and I have completed the initial review of your theme.
  • The review process follows procedures found in the theme handbook.
  • ref: https://make.wordpress.org/themes/handbook/review/
  • If you do not understand or agree with something in the review, please comment in the ticket.
  • I can then help you, or if I am not sure of something I will certainly seek a second opinion from another key reviewer.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Automated Review File Based Report

  • ERROR items must be fixed.
  • WARNING items may be required to be fixed and must be checked.
  • This is an automated checking system and some false positives may occur.
  • If you do not agree with an ERROR or WARNING, please indicate so in the ticket.

FILE: ...\xampp\htdocs\wptesta\wp-content\themes\shopstudio\functions.php

  • line 127, ERROR, Theme support for comment-reply found, threaded-comments must be added to your tags list in style.css
  • line 129, WARNING, wp_enqueue_script() handle is script. Handles should be prefixed with shopstudio. However if this is a bundled script it has not been edited, it should not be prefixed.
  • line 135, WARNING, wp_enqueue_style() handle is media-css. Handles should be prefixed with shopstudio.However bundled styles that have not been edited should not be prefixed.
  • line 144, ERROR, Found add_editor_style(), editor-style must be added to your tags list in style.css
  • If you are going to use add_editor_style(), you must have a valid editor-style.css file and ensure you include editor-style in the style.css tag list.
  • line 397, ERROR, This function name should be prefixed. Please use shopstudio.
  • line 417, ERROR, This function name should be prefixed. Please use shopstudio.
  • line 423, ERROR, This function name should be prefixed. Please use shopstudio.

FILE: ...tdocs\wptesta\wp-content\themes\shopstudio\inc\template-tags.php

  • line 26, ERROR, Strings should have translatable content

FILE: C:\xampp\htdocs\wptesta\wp-content\themes\shopstudio\style.css

  • line 10, ERROR, custom-logo exists in the style.css tags list but it appears this feature is not supported.

Requirements not picked up by the automated review

Licensing

Any copyright statements on the front end should display the user’s copyright, not the theme author’s copyright.
  • Do not put your copyright in the footer. It implies that all websites that use your theme are copyright by you and I don't think you want that. Typically theme authors grab the site title for this. Even if it is a default, if the user does not change the default you do not want to suggest that the website is copyright by you!
Declare licenses of any resources included such as fonts or images, including screenshot images
  • For resources please include: declaration (ex Copyright 2015, by John Smith), resource download link, license type, and license download
  • Below is an example of a resource declaration specifying resource name, resource download link, copyright declaration, license type, license link:
    jQuery Nivo Slider v3.2, http://nivo.dev7studios.com
    Copyright 2012, Dev7studios, MIT License, http://www.opensource.org/licenses/mit-license.php
    
    • you have not declared bootstrap
  • For images please provide download links and license type for images(including any images used in your screenshot) so licensing can be confirmed.
    • Below is an example of how an image should be declared.
      Image description/use : CC0 by author, http://www.imageprovider.com/imagelink
      
    • you need to declare all images in your screenshot as described above

Core Functionality and Features

The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design. (See: Theme Tag List)

#6 @themetracbot
2 months ago

  • Summary changed from THEME: shopstudio – 1.0.1 to THEME: shopstudio – 1.0.2

shopstudio - 1.0.2

shopstudio is a new theme that allows you to create woocommerce store easily.

Theme URL -
Author URL - https://profiles.wordpress.org/dots

Trac Browser - https://themes.trac.wordpress.org/browser/shopstudio/1.0.2

SVN - https://themes.svn.wordpress.org/shopstudio/1.0.2
ZIP - https://wordpress.org/themes/download/shopstudio.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shopstudio/1.0.1&new_path=shopstudio/1.0.2

History:


https://themes.svn.wordpress.org/shopstudio/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#7 @kevinhaig
2 months ago

@rabmalin

The theme author says you have OK'd the way he licensed the screenshot. Author has licensed the screenshot as one item when each image needs to be declared.

Can you please clarify for the author?

#8 @rabmalin
2 months ago

@dots Declaration is needed for each images used in the screenshot and the theme, not the main screenshot. 9 images are used in the screenshot. Please list all.

#9 @themetracbot
2 months ago

  • Summary changed from THEME: shopstudio – 1.0.2 to THEME: shopstudio – 1.0.3

shopstudio - 1.0.3

shopstudio is a new theme that allows you to create woocommerce store easily.

Theme URL -
Author URL - https://profiles.wordpress.org/dots

Trac Browser - https://themes.trac.wordpress.org/browser/shopstudio/1.0.3

SVN - https://themes.svn.wordpress.org/shopstudio/1.0.3
ZIP - https://wordpress.org/themes/download/shopstudio.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shopstudio/1.0.2&new_path=shopstudio/1.0.3

History:


https://themes.svn.wordpress.org/shopstudio/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#10 @dots
2 months ago

Hello @kevinhaig,
Thanks, @rabmalin for the information.

We have declared all images which are used in the screenshot on the latest version.

Thanks,
Multidots.

Last edited 2 months ago by dots (previous) (diff)

#11 @kevinhaig
2 months ago

Theme Review - shopstudio Version 1.0.3

  • Below is the review of the latest update of your theme.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Automated Review File Based Report

  • ERROR items must be fixed.
  • WARNING items may be required to be fixed and must be checked.
  • This is an automated checking system and some false positives may occur.
  • If you do not agree with an ERROR or WARNING, please indicate so in the ticket.

FILE: ...\xampp\htdocs\wptesta\wp-content\themes\shopstudio\functions.php

  • line 43, ERROR, add_theme_support() for post-thumbnails used but neither featured-images or featured-image-header were found in tags list in style.css
  • line 63, ERROR, add_theme_support() for custom-background used but not found in tags list in style.css

FILE: C:\xampp\htdocs\wptesta\wp-content\themes\shopstudio\header.php

  • line 76, ERROR, When wp_nav_menu() or register_nav_menu() are used custom-menu must be added to your tags list in style.css

FILE: ...tdocs\wptesta\wp-content\themes\shopstudio\inc\custom-header.php

  • line 20, ERROR, add_theme_support() for custom-header used but not found in tags list in style.css

FILE: ...p\htdocs\wptesta\wp-content\themes\shopstudio\inc\customizer.php

  • line 44, ERROR, add_theme_support() for custom-header used but not found in tags list in style.css

Core Functionality and Features

The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design. (See: Theme Tag List)
  • *Not done properly, many tags you pulled out are required* see above comments

FILE: C:\xampp\htdocs\wptesta\wp-content\themes\shopstudio\style.css

  • line 1, WARNING, Theme URI in style.css is not required but is recommended.
  • line 10, ERROR, No subject tags were found. Please select no more then 3 subject tags that reflect your theme.

Licensing * Not Done

Any copyright statements on the front end should display the user’s copyright, not the theme author’s copyright.
  • Do not put your copyright in the footer. It implies that all websites that use your theme are copyright by you and I don't think you want that. Typically theme authors grab the site title for this. Even if it is a default, if the user does not change the default you do not want to suggest that the website is copyright by you!
Declare licenses of any resources included such as fonts or images, including screenshot images

#12 @themetracbot
2 months ago

  • Summary changed from THEME: shopstudio – 1.0.3 to THEME: shopstudio – 1.0.4

shopstudio - 1.0.4

shopstudio is a new theme that allows you to create woocommerce store easily.

Theme URL -
Author URL - https://profiles.wordpress.org/dots

Trac Browser - https://themes.trac.wordpress.org/browser/shopstudio/1.0.4

SVN - https://themes.svn.wordpress.org/shopstudio/1.0.4
ZIP - https://wordpress.org/themes/download/shopstudio.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shopstudio/1.0.3&new_path=shopstudio/1.0.4

History:


https://themes.svn.wordpress.org/shopstudio/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#13 @kevinhaig
2 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Approving and setting live.

The WooCommerce images are licensed fine, but normally images are not licensed as GPL.

In your next update change the license for the Pixaby image to CC0, it is not GPL.

Note: See TracTickets for help on using tickets.