WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 60 minutes ago

#46419 reopened theme

THEME: Structural – 1.0.7

Reported by: webulous Owned by: Iceable
Priority: new theme Keywords: theme-structural
Cc: venkat@…

Description

Structural - 1.0.1

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.1

SVN - https://themes.svn.wordpress.org/structural/1.0.1
ZIP - https://wordpress.org/themes/download/structural.1.0.1.zip?nostats=1

History:


https://themes.svn.wordpress.org/structural/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (26)

#1 @themetracbot
6 weeks ago

  • Summary changed from THEME: Structural – 1.0.1 to THEME: Structural – 1.0.2

Structural - 1.0.2

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.2

SVN - https://themes.svn.wordpress.org/structural/1.0.2
ZIP - https://wordpress.org/themes/download/structural.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=structural/1.0.1&new_path=structural/1.0.2

History:


https://themes.svn.wordpress.org/structural/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are structural, equity

#2 @themetracbot
5 weeks ago

  • Summary changed from THEME: Structural – 1.0.2 to THEME: Structural – 1.0.3

Structural - 1.0.3

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.3

SVN - https://themes.svn.wordpress.org/structural/1.0.3
ZIP - https://wordpress.org/themes/download/structural.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=structural/1.0.2&new_path=structural/1.0.3

History:


https://themes.svn.wordpress.org/structural/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#3 @themetracbot
4 weeks ago

  • Owner set to mazeheld
  • Status changed from new to reviewing

#4 @mazeheld
4 weeks ago

Hello @webulous,
Thank you for submitting your theme and making the WordPress Community larger.

1) Please do not include a screenshot that has "Pro Only" features advertised.

2) Also your help documentation features content from two different themes, none of which are "Structural".

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Thank you!

This ticket was mentioned in Slack in #themereview by premakumar. View the logs.


4 weeks ago

#6 @rabmalin
4 weeks ago

Hello @mazeheld

Please do not include a screenshot that has "Pro Only" features advertised.

You should mention section shown in screenshot which is not available in the theme, so that theme author can fix the issue.

Also your help documentation features content from two different themes, none of which are "Structural".

I am also not getting this comment clearly. Can you please explain?

#7 @webulous
4 weeks ago

@rabmalin @mazeheld Thanks for the review. I'm waiting to hear some comments from @mazeheld .

#8 @webulous
4 weeks ago

@rabmalin,

@mazeheld is a new reviewer. I don't know whether he continues or not. Kindly let me know the status of this ticket.

This ticket was mentioned in Slack in #themereview by suganya. View the logs.


3 weeks ago

#10 @rabmalin
3 weeks ago

  • Owner mazeheld deleted

#11 @themetracbot
2 weeks ago

  • Owner set to Iceable

#12 @Iceable
2 weeks ago

Hi @webulous, I am starting to review this theme now and will post my feedback as soon as I can in the next couple of hours or days.

#13 @Iceable
2 weeks ago

Hi @webulous, here is my feedback after reviewing the theme against the Theme Review Guidelines.

Please check all issues very carefully and make sure to fix ALL of them before uploading a revised version.

Feel free to ask if you have any question or need any clarification. You may reply in this ticket or ask on the Slack #themereview channel.


Licensing

  • Declare licenses and copyright of any resources included.
    • [REQUIRED] Please mention the origin (URL), and license and copyright info for all included images, as well as the images used in the screenshot (all must be GPL compatible).
    • (Recommended) Even though license and copyright info are present in some files for font-awesome, flexslider and other included resources, it would be a lot better to list all of these resources along with their license and copyright info in one place (for example in style.css or readme.txt)

Theme tags

  • The translation-ready tag is used twice in the list of tags in style.css

Code

  • [REQUIRED] Customizer.php line 46: use sanitize_hex_color() instead of esc_html() to sanitize color values.
  • In several files, you use get_sidebar('left'), but there is no sidebar-left.php template file. If sidebar.php is the template file to use, then remove the 'left' parameter. See get_sidebar()
  • functions.php lines 404-407: please hook this function to init instead of wp_head (as suggested in WooCommerce's documentation). wp_head is not an appropriate hook for this.
add_action( 'wp_head', 'structural_remove_wc_breadcrumbs' );
function structural_remove_wc_breadcrumbs() {
	remove_action( 'woocommerce_before_main_content', 'woocommerce_breadcrumb', 20, 0 );
}
  • [REQUIRED] Please use the date format set by the user in Settings > General ( get_option( 'date_format' ) ) instead of an arbitrary, hardcoded date format in:
    • /template-parts/content-search.php line 17-21
    • includes/template-tags.php line 241-243
    • includes/template-tags.php line 479
  • [REQUIRED] functions.php line 108 needs to be translatable; at least this part: Mon - Sat:09.00-18.00

Options and Settings

[REQUIRED]: All included options and settings are required to be usable and to work properly.

  • Home Options > Page Content > Checkbox. If I check this box and uncheck all other sections, the page content is not shown. It seems to only appear if I check at least another section. What if I want to display only my page content?
  • Home Options > Section: Service. The Icons settings do not seem to be saved properly. I cannot get any icon to display on the page. If I select icons and save changes and come back to the customizer, the icon selection is empty again.
  • (Recommended) If I set an image in Header Media > Header Image (and no video), then the header image is displayed twice: once at the very top, above the header, and a second time as a background of the header area. Is this really the expected behavior?
  • (Recommended) If I only check "Recent Blog" and "Page content", both are shown, but there is also an empty wrapper above the page content that cause a huge gap.

Documentation

  • (Recommended) The documentation about some special features and settings on your site is quite thin.

Theme Unit Test

I tested the theme using the standard Theme Unit Test data.

  • (Recommended) Comments: Gravatars are loaded with the default size of 32x32px, but the theme displays them at 100x100px. As a result they appear very pixelated and ugly. You could fix it by setting the 'avatar_size' arg to your wp_list_comments() call in comments.php on line 43 (Reference: wp_list_comment())
  • (Recommended) Template: Comments: headings (h1, h2 etc.) in comments are the same color (dark blue) as the comment background, which makes them invisible.
  • (Recommended) On a large screen, the width of posts content (with a sidebar) is 780px. $content_width to 640 in functions.php, so elements relying on this value (like embedded videos) do not actually use the available width. (This is not a real issue, but you may want to look into it)
  • (Recommended) Post with no title: The breadcrumbs look a bit broken if the post has no title.
  • (Recommended) Categories do not seem to be displayed anywhere for posts (either on index or single). On single post page, only one category is visible in the breadcrumbs.
  • (Recommended) Template: Comments Disabled: On blog index, this post still has a "leave a comment" link, even though comments are disabled.

Please reply within 7 days, otherwise this ticket may be closed for inactivity.

#14 @themetracbot
13 days ago

  • Summary changed from THEME: Structural – 1.0.3 to THEME: Structural – 1.0.4

Structural - 1.0.4

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.4

SVN - https://themes.svn.wordpress.org/structural/1.0.4
ZIP - https://wordpress.org/themes/download/structural.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=structural/1.0.3&new_path=structural/1.0.4

History:


https://themes.svn.wordpress.org/structural/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#15 @webulous
13 days ago

Hi @Iceable,

Thanks for reviewing our theme.
I changed everything as you mentioned on the ticket.
Let me know if everything is okay.
Thank you!!

#16 @Iceable
10 days ago

Hi @webulous , thank you for updating your theme and sorry I had to keep you waiting for a couple of days while I was away.

All issues seem to be fixed, except for this:

  • At the end of readme.txt: Those Image are licensed under CC0 Public Domain License GPLv3.

Are these images "CC0 public domain" or "GPLv3"? It cannot be both at the same time!
Please edit this line to make it clear.

I know this seems like a detail, but licensing is a very serious topic and a theme cannot go live if licensing matters are not properly sorted out.


Additional notes (no required issue here):

  • I took note that you decided not to change the date format in includes/template-tags.php line 241-243 (in breadcrumbs) after a theme admin clarified that this was not required for breadcrumbs. Date format seems to be properly updated in other places.
  • About this recommendation:

    (Recommended) If I set an image in Header Media > Header Image (and no video), then the header image is displayed twice: once at the very top, above the header, and a second time as a background of the header area. Is this really the expected behavior?

Hiding the img with CSS while it is still there in the markup is a pretty dirty way to fix this.
This is not a required issue but you could consider implementing a cleaner fix in a future update :)


Please fix this licensing issue and I'll mark the theme as approved. Then an experienced reviewer will double check it in case I missed anything and will proceed to setting it live.

#17 @themetracbot
9 days ago

  • Summary changed from THEME: Structural – 1.0.4 to THEME: Structural – 1.0.5

Structural - 1.0.5

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.5

SVN - https://themes.svn.wordpress.org/structural/1.0.5
ZIP - https://wordpress.org/themes/download/structural.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=structural/1.0.4&new_path=structural/1.0.5

History:


https://themes.svn.wordpress.org/structural/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#18 @webulous
9 days ago

Hi @Iceable,

Thanks for your time.
We modified the readme.txt file and uploaded the latest version.
Thank you!!

#19 @Iceable
9 days ago

  • Status changed from reviewing to approved

Looks good to go, I'm marking this ticket as approved and it will go to the final review queue.

You can see how this queue is going here: https://themes.trac.wordpress.org/report/24

#20 @poena
3 days ago

  • Status changed from approved to reopened

#21 @poena
3 days ago

Hi!
Please solve these minor problems before your theme can go live:

The option "Show Comments", needs to be removed because this is an existing core setting that themes should not override. It can already be changed per post or page basis or under Settings -> Discussion.

Do not use existing domains like mail.com in demo content/starter content/as default values, use example.com.

Missing translation functions:
options-config.php:
<img src="<?php echo get_template_directory_uri(); ?>/screenshot.png" alt="Theme Screenshot" />
template-tags.php:
<span class="tag-title">Tags</span>

In template-tags.php, this thumbnail size does not exist?
418: the_post_thumbnail('recent-work');

The tgm file says:

  • @version 2.6.1 for parent theme Style Outlet for publication on WordPress.org

Declare licenses of any resources included. Include the theme name, license and copyright for "Style Outlet" in the same way you have for underscores.

#22 @themetracbot
3 days ago

  • Summary changed from THEME: Structural – 1.0.5 to THEME: Structural – 1.0.6

Structural - 1.0.6

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.6

SVN - https://themes.svn.wordpress.org/structural/1.0.6
ZIP - https://wordpress.org/themes/download/structural.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=structural/1.0.5&new_path=structural/1.0.6

History:


https://themes.svn.wordpress.org/structural/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#23 @webulous
3 days ago

Hi @poena,

Thanks for the review.
I changed the files as you mentioned on the ticket.
Thank you!

#24 @poena
25 hours ago

mail dot com is an existing site. I am not sure what main dot com is.

Please use example.com or example.org, that's their purpose: https://www.iana.org/domains/reserved

#25 @themetracbot
62 minutes ago

  • Summary changed from THEME: Structural – 1.0.6 to THEME: Structural – 1.0.7

Structural - 1.0.7

Structural is a constrcution based theme. It is an attractive, modern, easy to use and responsive WordPress theme with colorful design and stunning flexibility. There is no theme options panel, instead uses Customizer, core feature of WordPress and comes with lots of options to customize. Some of the available options are awesome slider section, header options, footer options, layout design options, widget options and lots of other available options will allow you to create unique website as you want.

Theme URL - http://www.webulousthemes.com/structural/
Author URL - http://www.webulousthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/structural/1.0.7

SVN - https://themes.svn.wordpress.org/structural/1.0.7
ZIP - https://wordpress.org/themes/download/structural.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=structural/1.0.6&new_path=structural/1.0.7

History:


https://themes.svn.wordpress.org/structural/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#26 @webulous
60 minutes ago

Hi @poena,

Sorry for that mistake. I correct that data content.
and Upload the theme again.
Thank you!!

Note: See TracTickets for help on using tickets.