WordPress.org

Make WordPress Themes

Opened 5 weeks ago

Closed 5 weeks ago

#46473 closed theme (not-approved)

THEME: Feathery – 0.1

Reported by: Milap Owned by: poena
Priority: new theme Keywords: theme-feathery
Cc: cemilap.88@…

Description

Feathery - 0.1

Feathery is a lightweight, modern, trendy and stylish WordPress Theme. We have created Feathery as simple as possible with a highly user experience. Demo Link: http://demo.wpretro.com/

Theme URL - http://demo.wpretro.com/
Author URL - http://wpretro.com/

Trac Browser - https://themes.trac.wordpress.org/browser/feathery/0.1

SVN - https://themes.svn.wordpress.org/feathery/0.1
ZIP - https://wordpress.org/themes/download/feathery.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#46473 THEME: Feathery – 0.1 closed not-approved poena

(this ticket)


https://themes.svn.wordpress.org/feathery/0.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'feathery'

Change History (2)

#1 @poena
5 weeks ago

  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
5 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!
Thank you for submitting your theme.
Your theme has been partially reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.
This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. -We want you to resubmit your theme,
but we do ask that you spend more time making sure that your theme meets all the requirements.
Please do not submit your theme until it is complete, tested, and ready for release.
https://make.wordpress.org/themes/handbook/review/required/
You can upload your update here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately.
We will review your update when your theme reaches the top of the review queue.

If you have questions you can ask them here or in the #themereview channel on Slack
channel.

Required:

Please remove any and all code, files or folders that is not used by the theme.
The rtl.css file is commented out?

No hard coding of script and style files.
Remove the stylesheets from header.php and enqueue them instead.

No minification of scripts or files unless you provide original files.
There are several js and css files that are missing the human readable, non minified version ( It looks like some of them might be duplicated? ).

Themes are required to use core-bundled scripts rather than including their own version of that script.
List of included scripts:
https://developer.wordpress.org/reference/functions/wp_enqueue_script/#default-scripts-included-and-registered-by-wordpress

There should be no PHP or JS notices. When I try to activate the theme, I see the following:

Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'wr_feathery_fields' not found or invalid function name in /app/public/wp-includes/class-wp-hook.php on line 298
Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'register_portfolio_taxonomy' not found or invalid function name in /app/public/wp-includes/class-wp-hook.php on line 298

When I then try to view the front end, there are several more notices:

Use of undefined constant FEATHERY_CACHE - assumed 'FEATHERY_CACHE' in feathery/functions.php on line 643
Use of undefined constant FEATHERY_MINIFIED - assumed 'FEATHERY_MINIFIED' in feathery/header.php on line 25
Warning: array_keys() expects parameter 1 to be array, null given in feathery/functions.php on line 598
Warning: array_flip() expects parameter 1 to be array, null given in feathery/functions.php on line 598
Warning: array_replace(): Argument #1 is not an array in feathery/functions.php on line 598
Warning: Invalid argument supplied for foreach() in feathery/functions.php on line 599

Because of these errors, it was not possible for me to do a complete review.
I'm afraid I'm not 100% sure of what you are trying to do, partly because of the errors, but a theme may not create content like inserting posts, post meta, categories etc without permission and without notice. You can use starter content instead.

Caching is plugin territory. Themes are meant to present content, not add functionality that is lost when the user switches themes.

"This theme requires the following plugins: Contact Form 7, Redux Framework and Register Custom Post Types and Taxonomies."
Themes cannot require plugins to work. Themes may only recommend plugins that are available in the WordPress.org Plugin Directory.

You need to remove the .tar file. Themes are allowed to integrate libraries and to have support for plugins, but not include plugins in the theme folder this way.
Reference: https://make.wordpress.org/themes/handbook/review/required/#plugins

It looks like there is two versions of TGMPA? Please make sure that you use the latest version. Use the download form on http://tgmpluginactivation.com/download/ and select the version that is intended for distribution on WordPress.org.

In others.php and template-tags.php
Themes may be backwards compatible, but only for 3 major WordPress versions (version 4.5 if 4.8 is latest).
Please remove the fallbacks for WordPress 4.1 and 4.3.

The screenshot should be a reasonable representation of what the theme can look like.
The screenshot should not be a logo or mockup.

All theme text strings are to be translatable.
There is text in the theme that is missing translation functions.

Remove any lorem ipsum or similar dummy texts, instead, use texts that are helpful to the user.
Demo content may be used to show the user how the options work. Use starter content, existing content,
or installation instructions instead of placeholder content. Installation instructions should only be visible to users with the edit_theme_options capability, not to visitors.

You cannot have your own social links as defaults for options. There is no scenario where the user would want to use your links, surely they want to use their own.
They shouldn't need to remove the default values in order to use the theme.

Any copyright statements on the front end should display the user’s copyright, not the theme author’s copyright.

Theme URI is optional. If used, it must be about the theme we’re hosting on WordPress.org.
If the URI is a demo site, the content must be about the theme itself and not test data.

Author URI is optional. If used it is required to link to an author’s personal website or project/development website. Not a coming soon page.

I believe the logo option is only avaialable if redux is active, but themes are required to use WordPress functionality when available, add support for the custom logo instead.


Recommended reading:

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/

https://developer.wordpress.org/themes/

https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data
https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

The coding standards are not required to pass the review, but they can be helpful when developing your theme.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods.
It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

Note: See TracTickets for help on using tickets.