WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 8 days ago

#46570 closed theme (live)

THEME: Excel Business – 1.0.3

Reported by: exceltheme Owned by: kafleg
Priority: new theme Keywords: theme-excel-business
Cc: themeexcel@…

Description

Excel Business - 1.0.0

Excel Business is a business theme from Excel Theme.

Theme URL -
Author URL - http://exceltheme.com/

Trac Browser - https://themes.trac.wordpress.org/browser/excel-business/1.0.0

SVN - https://themes.svn.wordpress.org/excel-business/1.0.0
ZIP - https://wordpress.org/themes/download/excel-business.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/excel-business/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'excel-business'

Change History (17)

#1 @rabmalin
4 weeks ago

  • Owner set to kafleg
  • Status changed from new to reviewing

#2 @kafleg
4 weeks ago

Hello @exceltheme,
I am going to review this theme. If you want to update this theme update within 24 hours otherwise I will continue review on this. Reviewers are now allowed to close the ticket if the theme has 3+ distinct issues. https://make.wordpress.org/themes/2017/11/16/meeting-notes-for-2017-november-14/ Make sure your theme is developed based on the guidelines. https://make.wordpress.org/themes/handbook/review/required/
Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.
https://wordpress.org/plugins/theme-check/
https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]
Hope all the issues mentioned by the previous reviewer is fixed in this version.
Regards
@kafleg

#3 @exceltheme
4 weeks ago

Hi @kafleg,

The theme itself is complete and we're working on companion plugin that integrates with this theme and it is going live tomorrow. So, can you give us a day to update and resubmit the theme?

Also, was this theme assigned before cause I don't see any issues posted in this ticket?

Thanks

#4 @kafleg
4 weeks ago

@exceltheme,
Okay, you can do it.
Thank you

#5 @themetracbot
4 weeks ago

  • Summary changed from THEME: Excel Business – 1.0.0 to THEME: Excel Business – 1.0.1

Excel Business - 1.0.1

Excel Business is a business theme from Excel Theme.

Theme URL -
Author URL - http://exceltheme.com/

Trac Browser - https://themes.trac.wordpress.org/browser/excel-business/1.0.1

SVN - https://themes.svn.wordpress.org/excel-business/1.0.1
ZIP - https://wordpress.org/themes/download/excel-business.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=excel-business/1.0.0&new_path=excel-business/1.0.1

History:


https://themes.svn.wordpress.org/excel-business/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#6 @exceltheme
4 weeks ago

@kafleg

We've uploaded the latest version. Please proceed with the review.

Thanks

#7 @rabmalin
3 weeks ago

@kafleg Have you checked the update?

#8 @kafleg
3 weeks ago

Hello @exceltheme,
Sorry for the late reply. I was quite busy last week.
Here are some findings on your theme.

Required

  • Remove 'comment-list' from add_theme_support, you are customizing comment list.
  • Remove 'comment-form' from add_theme_support, you are customizing comment form.
  • Provide dual license of font awesome, * Font-Awesome https://github.com/FortAwesome/Font-Awesome FontAwesome 4.7.0 Copyright 2012 Dave Gandy Font License: SIL OFL 1.1 Code License: MIT License http://fontawesome.io/license/

Thank you

#9 @exceltheme
3 weeks ago

Hi @kafleg,

Is there any more issues that you may have found besides above mentioned issues? So that we can fix all and resubmit the theme.

Thanks

#10 @kafleg
3 weeks ago

Yes, this is only for now. I will check another version after the update and will let you know if the theme has issues.

#11 @exceltheme
2 weeks ago

HI @kafleg

We've finished what you have asked and trying to upload but there is a error while uploading. It seems trac problem. So, we're gonna upload it tomorrow.

Thanks

#12 @kafleg
10 days ago

@exceltheme
Can you please try uploading the update file?

#13 @exceltheme
10 days ago

@kafleg

I've tried to upload the updated file but couldn't. Here is the screenshot http://prntscr.com/hkv393
I've also reported to themes@…. What could it be causing this?

Thanks

#14 @rabmalin
9 days ago

Bump the version and upload again.

#15 @themetracbot
9 days ago

  • Summary changed from THEME: Excel Business – 1.0.1 to THEME: Excel Business – 1.0.3

Excel Business - 1.0.3

Excel Business is a business theme from Excel Theme.

Theme URL -
Author URL - http://exceltheme.com/

Trac Browser - https://themes.trac.wordpress.org/browser/excel-business/1.0.3

SVN - https://themes.svn.wordpress.org/excel-business/1.0.3
ZIP - https://wordpress.org/themes/download/excel-business.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=excel-business/1.0.1&new_path=excel-business/1.0.3

History:


https://themes.svn.wordpress.org/excel-business/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#16 @exceltheme
9 days ago

Hi @kafleg

We've uploaded the latest version. Please check.

Thanks

#17 @kafleg
8 days ago

  • Resolution set to live
  • Status changed from reviewing to closed

No More issues found, setting live. Thank you so much for your coordination while reviewing theme.

Note: See TracTickets for help on using tickets.