WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 3 days ago

#46681 reviewing theme

THEME: Dan – 1.0.7

Reported by: yochix2 Owned by: DipenDahal
Priority: new theme Keywords: theme-dan accessibility-ready
Cc: yochi@…

Description

Dan - 1.0.0

Dan is a simple theme suitable for blogs and corporate sites. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.0

SVN - https://themes.svn.wordpress.org/dan/1.0.0
ZIP - https://wordpress.org/themes/download/dan.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (21)

#1 @themetracbot
3 months ago

  • Keywords changed from theme-dan, accessibility-ready to theme-dan accessibility-ready
  • Summary changed from THEME: Dan – 1.0.0 to THEME: Dan – 1.0.1

Dan - 1.0.1

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.1

SVN - https://themes.svn.wordpress.org/dan/1.0.1
ZIP - https://wordpress.org/themes/download/dan.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.0&new_path=dan/1.0.1

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#2 @themetracbot
3 months ago

  • Summary changed from THEME: Dan – 1.0.1 to THEME: Dan – 1.0.2

Dan - 1.0.2

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.2

SVN - https://themes.svn.wordpress.org/dan/1.0.2
ZIP - https://wordpress.org/themes/download/dan.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.1&new_path=dan/1.0.2

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#3 @themetracbot
2 months ago

  • Summary changed from THEME: Dan – 1.0.2 to THEME: Dan – 1.0.3

Dan - 1.0.3

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.3

SVN - https://themes.svn.wordpress.org/dan/1.0.3
ZIP - https://wordpress.org/themes/download/dan.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.2&new_path=dan/1.0.3

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#4 @themetracbot
6 weeks ago

  • Summary changed from THEME: Dan – 1.0.3 to THEME: Dan – 1.0.4

Dan - 1.0.4

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.4

SVN - https://themes.svn.wordpress.org/dan/1.0.4
ZIP - https://wordpress.org/themes/download/dan.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.3&new_path=dan/1.0.4

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#5 @themetracbot
4 weeks ago

  • Owner set to DipenDahal
  • Status changed from new to reviewing

#6 @DipenDahal
4 weeks ago

Hello,

I am reviewing your theme and soon i will update you.

#7 @yochix2
4 weeks ago

Hello, @DipenDahal
I am looking forward to your theme review.
Best regards,
Yochi

#8 @DipenDahal
4 weeks ago

Hello @yochix2,
Thanks for uploading theme. Please check following issues I found while initial review. Re-upload your theme after fixing issues.

Required

  • footer.php line 43 , missing language translations,Theme must be translation ready. All string need to be translatable. 'Yochi' must be translated.
  • front-page.php ,line 39, need to be add prefix .Prefix theme functions, classes, global variables, image size name, script and style handles, etc with the theme slug.

Please submit theme update or comment here within 7 days. If there is no response for 7 days, the ticket will be closed as not-approved.

Regards!
@DipenDahal

#9 @themetracbot
4 weeks ago

  • Summary changed from THEME: Dan – 1.0.4 to THEME: Dan – 1.0.5

Dan - 1.0.5

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.5

SVN - https://themes.svn.wordpress.org/dan/1.0.5
ZIP - https://wordpress.org/themes/download/dan.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.4&new_path=dan/1.0.5

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#10 @yochix2
4 weeks ago

Hello @DipenDahal,
Thank you for theme review.
I fixed some issues you found.

Best regards,
Yochi

#11 @themetracbot
4 weeks ago

  • Summary changed from THEME: Dan – 1.0.5 to THEME: Dan – 1.0.6

Dan - 1.0.6

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.6

SVN - https://themes.svn.wordpress.org/dan/1.0.6
ZIP - https://wordpress.org/themes/download/dan.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.5&new_path=dan/1.0.6

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#12 @DipenDahal
3 weeks ago

  • Status changed from reviewing to approved

No issues found, marking as approve.

#13 @rabmalin
3 weeks ago

  • Status changed from approved to reopened

#14 @rabmalin
3 weeks ago

  • Status changed from reopened to reviewing

This theme needs accessibility review before approval.
Ping @joedolson @davidakennedy @poena

#15 @yochix2
3 weeks ago

Thank you for the theme check.
I will wait for accessibility review.

#16 @joedolson
13 days ago

It's basically in good shape, but there are a number of contrast issues to address. I also suggest creating a stronger :focus state.

1) Keyboard Navigation - Pass

2) Controls - Pass

3) Skip Links - Pass

4) Forms - Pass

5) Headings - Pass

6) ARIA Landmark Roles - Pass

7) Link Text - Pass

8) Contrasts - Fail

  • Skip to Content link = 2.99:1
  • Image caption text - 4.41:1
  • Comment notes - 4.41:1
  • Comment labels - 4.41:1
  • "Powered by WordPress" - 3.97:1
  • Post meta date/time/byline/categories/tags, etc. - 4.41:1
  • table cell links: 2.87:1
  • regular content links: 2.99:1

9) Images - Pass

10) Screen Reader Text - Pass

10) Media - None identified; default pass.

11) Not Allowed - Pass

Theme Accessibility Guidelines & Tips:
https://make.wordpress.org/themes/handbook/review/accessibility/required/

#17 @themetracbot
12 days ago

  • Summary changed from THEME: Dan – 1.0.6 to THEME: Dan – 1.0.7

Dan - 1.0.7

Dan is a simple two-columns theme. On the front page, you can use a header image and multiple page sections. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/dan/1.0.7

SVN - https://themes.svn.wordpress.org/dan/1.0.7
ZIP - https://wordpress.org/themes/download/dan.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dan/1.0.6&new_path=dan/1.0.7

History:

Ticket Summary Status Resolution Owner
#15436 THEME: Dancing In The Moonlight - 1.0.0 closed live rohitink
#25151 THEME: Daniela – 1.0.5 closed live tinkerbelly
#26568 THEME: Daniela – 1.0.6 closed live rabmalin
#34458 THEME: Dandy – 1.0.8 closed live DannyCooper
#34626 THEME: DankSpangle – 0.0.3 closed not-approved rabmalin
#34707 THEME: DankSpangle – 0.0.5 closed not-approved poena
#40579 THEME: Dandy – 1.0.9 closed live themetracbot
#41019 THEME: Dandy – 1.1 closed live themetracbot
#41037 THEME: Dandy – 1.1.1 closed live themetracbot
#41227 THEME: Dandy – 1.1.2 closed live themetracbot
#41595 THEME: Danielle – 17.01 closed not-approved acosmin
#41936 THEME: Dandy – 1.1.3 closed live themetracbot
#42002 THEME: Daniels Bootstrap 4 – 1.0.0 closed not-approved kafleg
#42204 THEME: Dandy – 1.1.4 closed live themetracbot
#42230 THEME: Dandy – 1.1.5 closed live themetracbot
#42623 THEME: Dandy – 1.1.6 closed live themetracbot
#43458 THEME: Dandy – 1.1.7 closed live themetracbot
#44314 THEME: Dandy – 1.1.8 closed live themetracbot
#45459 THEME: Dandy – 1.1.9 closed live themetracbot
#46439 THEME: Dandy – 1.2 closed live themetracbot
#46681 THEME: Dan – 1.0.7 reviewing DipenDahal

(this ticket)

#47748 THEME: Dandy – 1.3 closed live themetracbot
#48145 THEME: Dandy – 1.4 closed live themetracbot
#49139 THEME: Dandy – 1.4.1 closed live themetracbot


https://themes.svn.wordpress.org/dan/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#18 @yochix2
12 days ago

I fixed some contrast issues.

Thank you,
Yochi

#19 @joedolson
6 days ago

These changes look good to me - approved for accessibility-ready. Thanks!

#20 @yochix2
5 days ago

Thank you for accessibility review.
I hope the theme will be approved.

#21 @rabmalin
3 days ago

@DipenDahal Please approve the ticket if theme is good from your side.

Note: See TracTickets for help on using tickets.