WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 11 days ago

#46716 approved theme

THEME: Digital Products – 1.0.2

Reported by: wpdigipro Owned by: jainnidhi
Priority: new theme Keywords: theme-digital-products
Cc: support@…

Description

Digital Products - 1.0

Digital Products is a WordPress theme to help you in selling your Digital Products. This theme is optimized for selling digital products. So, if you would like to sell softwares or PDFs or graphics or any type of membership then Digital Products WordPress theme is for you.

Theme URL - https://wpdigipro.com/wordpress-themes/digital-products
Author URL - https://wpdigipro.com

Trac Browser - https://themes.trac.wordpress.org/browser/digital-products/1.0

SVN - https://themes.svn.wordpress.org/digital-products/1.0
ZIP - https://wordpress.org/themes/download/digital-products.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/digital-products/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (17)

#1 @themetracbot
3 months ago

  • Summary changed from THEME: Digital Products – 1.0 to THEME: Digital Products – 1.0.1

Digital Products - 1.0.1

Digital Products is a WordPress theme to help you in selling your Digital Products. This theme is optimized for selling digital products. So, if you would like to sell softwares or PDFs or graphics or any type of membership then Digital Products WordPress theme is for you. Step by step getting started documentation and dummy data is here: https://wpdigipro.com/documentation/digital-products-wordpress-theme/

Theme URL - https://wpdigipro.com/wordpress-themes/digital-products
Author URL - https://wpdigipro.com

Trac Browser - https://themes.trac.wordpress.org/browser/digital-products/1.0.1

SVN - https://themes.svn.wordpress.org/digital-products/1.0.1
ZIP - https://wordpress.org/themes/download/digital-products.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=digital-products/1.0&new_path=digital-products/1.0.1

History:


https://themes.svn.wordpress.org/digital-products/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @themetracbot
3 weeks ago

  • Owner set to jainnidhi
  • Status changed from new to reviewing

#3 @jainnidhi
3 weeks ago

Hello @wpdigipro
I will start reviewing the theme, and I will get back to you shortly.

#4 @jainnidhi
3 weeks ago

Hello @wpdigipro,
This is my review:
Running the NS Theme Check plugin I found this errors:

digital-products/header.php
10 ERROR The title tag must not be used. Use add_theme_support( 'title-tag' ) instead.

digital-products/inc/class-tgm-plugin-activation.php
526 ERROR Silencing errors is forbidden

digital-products/inc/custom-header.php
41 ERROR Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.

RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme.

RECOMMENDED: No reference to add_editor_style() was found in the theme.

Please upload an update in the next 7 days or let me know if you need more time.

Regards,
Nidhi

#5 @jrf
3 weeks ago

Also: please download a fresh copy of TGMPA using the correct settings - i.e choose "wordpress.org" as distribution channel in the Custom TGMPA Generator.
You are now using the generic version in which you have clearly done a manual search & replace for the text domain. This search & replace has been done incorrectly and will cause fatal errors for users of your theme in its current state.
If you download the correct version, there is no need for the manual search & replace as the text-domain will have been automagically adjusted for you (correctly).

REQUIRED: includes/admin/tgmpa/class-tgm-plugin-activation.php L478 - Silencing errors is forbidden.

This will also take care of the "Silencing errors is forbidden" warning.

Last edited 2 weeks ago by jrf (previous) (diff)

#6 @Mirucon
2 weeks ago

@wpdigipro have you seen the review? Remember, ticket has no activity from the author for 7 days will be closed due to inactivity.

#7 @wpdigipro
2 weeks ago

Hi There.
We'll update the theme today or max tomorrow.
Team has been on Weekend leave hence the delay.
Apologies.

#8 @themetracbot
2 weeks ago

  • Summary changed from THEME: Digital Products – 1.0.1 to THEME: Digital Products – 1.0.2

Digital Products - 1.0.2

Digital Products is a WordPress theme to help you in selling your Digital Products. This theme is optimized for selling digital products. So, if you would like to sell softwares or PDFs or graphics or any type of membership then Digital Products WordPress theme is for you. Step by step getting started documentation and dummy data is here: https://wpdigipro.com/documentation/digital-products-wordpress-theme/

Theme URL - https://wpdigipro.com/wordpress-themes/digital-products
Author URL - https://wpdigipro.com

Trac Browser - https://themes.trac.wordpress.org/browser/digital-products/1.0.2

SVN - https://themes.svn.wordpress.org/digital-products/1.0.2
ZIP - https://wordpress.org/themes/download/digital-products.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=digital-products/1.0.1&new_path=digital-products/1.0.2

History:


https://themes.svn.wordpress.org/digital-products/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#9 @wpdigipro
2 weeks ago

@jainnidhi updated theme has been uploaded.
Please check and let me know if there's anything which needs to be changed.
Thanks.

Version 0, edited 2 weeks ago by wpdigipro (next)

#10 @jrf
2 weeks ago

The TGMPA file has still been manually edited (incorrectly). Please use an official version as per the instructions above.

#11 @wpdigipro
2 weeks ago

Hi @jrf If we don't make custom changes then it throws SPRINTF error. You can check that.

#12 @jrf
2 weeks ago

@wpdigipro But you've made more changes than just fixing that.

#13 @wpdigipro
2 weeks ago

@jrf Could you please share the file with the required changes so that SPRINT warning doesn't appear. We did it as per our understanding not sure why do you think it's wrong! Hence request you to please help or accept the way it's been done.
Appreciate your understanding.

#14 @wpdigipro
2 weeks ago

@jainnidhi please review the theme and let us know if there's anything else which we need to look at.
Many thanks for your time.

#15 @jainnidhi
13 days ago

Hello @wpdigipro

I found some issues.

digital-products/header.php
10 ERROR The title tag must not be used. Use add_theme_support( ‘title-tag’ ) instead.

digital-products/inc/class-tgm-plugin-activation.php
526 ERROR Silencing errors is forbidden

digital-products/inc/custom-header.php
41 ERROR Found usage of constant “HEADER_TEXTCOLOR”. Use add_theme_support( ‘custom-header’ ) instead.

Regards,
Nidhi

#16 @wpdigipro
11 days ago

Hi @jainnidhi,
Are you sure you're checking version 1.0.2 of the theme?
Please confirm as we've fixed these issues in 1.0.2 version.
Thanks.

#17 @jainnidhi
11 days ago

  • Status changed from reviewing to approved

Hi @wpdigipro,

I apologize for that because I got the old version when downloaded the theme before.

Thank you for the update. Everything seems ok now. I'll mark the theme as approved.

Regards,
Nidhi

Note: See TracTickets for help on using tickets.