WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 28 minutes ago

#46818 reviewing theme

THEME: Perk – 2.1

Reported by: corporatezen222 Owned by:
Priority: new theme Keywords: theme-perk
Cc: jeremy@…

Description

Perk - 2.0

Perk provides a clean and beautiful website template that comes fully responsive out of the box. That means you can create your website and know that everything you build will look great on desktop, tablets, and on mobile devices. It is highly recommended to use Perk’s helper plugins so you can quickly and easily create “zen pages” and contact pages and menus and more.

Theme URL -
Author URL - http://www.corporatezen.com/

Trac Browser - https://themes.trac.wordpress.org/browser/perk/2.0

SVN - https://themes.svn.wordpress.org/perk/2.0
ZIP - https://wordpress.org/themes/download/perk.2.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21482 THEME: Perkins - 1.0.2 closed live alex27
#43666 THEME: Perkz – 1.9.1 closed not-approved rabmalin
#46818 THEME: Perk – 2.1 reviewing

(this ticket)


https://themes.svn.wordpress.org/perk/2.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

Attachments (1)

perk.zip (3.3 MB) - added by corporatezen222 4 weeks ago.
Perk Theme with issues from reviewer fixed

Change History (13)

#1 @themetracbot
4 weeks ago

  • Owner set to remo.sometimes
  • Status changed from new to reviewing

#2 @remo.sometimes
4 weeks ago

Hi! Thank you for your submission.
I'm reviewing your theme, here is what i found:

Some Theme Check's Recommendation:

  • No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Theme URI: is missing from your style.css header.

Fonts:

  • Google Fonts should be enqueued through wp_enqueue_style instead of added using the <link> tag

Responsive behaviour:

  • Very small issue when a page has a table and the screen width is lower than 370px circa, the table doesn't resize properly due to the <td> padding.

"zen_page" Custom Post Type

  • Publishing or Updating a zen_page's custom post when the page is reloaded you get "Not found" error if WordPress is installed in a subdirectory. The custom post is saved properly, just the returning url is wrong.
  • Sometimes after clicking the “clear form” button in the "zen builder tool" you get a js error:
    Uncaught TypeError: Cannot read property 'setContent' of null
    

If I will find something else I'll keep you posted!

#3 follow-up: @corporatezen222
4 weeks ago

Thank you for your time and help!

For the few things you mentioned, should I fix them and re-upload the theme? Or should I wait until you are done reviewing?

#4 in reply to: ↑ 3 @remo.sometimes
4 weeks ago

Hi! You can already start to fix and re-upload.
I have not found other significant errors to be fixed, at the moment.
Bests

@corporatezen222
4 weeks ago

Perk Theme with issues from reviewer fixed

#5 @corporatezen222
4 weeks ago

  • Google fonts are now enqueued through wp_enqueue_style()
  • <td> padding has been removed for screens under 400px wide
  • In the helper plugin, I have created a javascript variable using wp_localize_script() that contains the site url, so the issue with the sub directory installation won't cause that error anymore. I will roll out this update to the plugin ASAP.
  • I first check if the editor is initialized before attempting to "setContent()"

#7 @themetracbot
3 weeks ago

  • Summary changed from THEME: Perk – 2.0 to THEME: Perk – 2.1

Perk - 2.1

Perk provides a clean and beautiful website template that comes fully responsive out of the box. That means you can create your website and know that everything you build will look great on desktop, tablets, and on mobile devices. It is highly recommended to use Perk&#8217;s helper plugins so you can quickly and easily create &#8220;zen pages&#8221; and contact pages and menus and more.

Theme URL -
Author URL - http://www.corporatezen.com/

Trac Browser - https://themes.trac.wordpress.org/browser/perk/2.1

SVN - https://themes.svn.wordpress.org/perk/2.1
ZIP - https://wordpress.org/themes/download/perk.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=perk/2.0&new_path=perk/2.1

History:

Ticket Summary Status Resolution Owner
#21482 THEME: Perkins - 1.0.2 closed live alex27
#43666 THEME: Perkz – 1.9.1 closed not-approved rabmalin
#46818 THEME: Perk – 2.1 reviewing

(this ticket)


https://themes.svn.wordpress.org/perk/2.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#8 follow-up: @Mirucon
2 weeks ago

@remo.sometimes Have you checked the update?

#9 in reply to: ↑ 8 @remo.sometimes
13 days ago

Replying to Mirucon:

@remo.sometimes Have you checked the update?

Sorry, very busy at work, I hope to find the time during the weekend.

#10 @rabmalin
5 days ago

  • Owner remo.sometimes deleted

#11 @themetracbot
3 days ago

  • Owner set to Giancarlo Piccinini

#12 @rabmalin
28 minutes ago

  • Owner Giancarlo Piccinini deleted

Returning ticket back to review queue for new reviewer.

Note: See TracTickets for help on using tickets.