WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 34 hours ago

#46878 closed theme (live)

THEME: Interserver Platinum – 1.1.2

Reported by: InterServer.Net Web Hosting Owned by: audrasjb
Priority: new theme Keywords: theme-interserver-platinum
Cc: accounts@…

Description

Interserver Platinum - 0.1

Interserver Platinum is a multipurpose theme for various type of businesses. It is highly custoomizable and easy to use.

Theme URL -
Author URL - https://profiles.wordpress.org/interservernet-web-hosting

Trac Browser - https://themes.trac.wordpress.org/browser/interserver-platinum/0.1

SVN - https://themes.svn.wordpress.org/interserver-platinum/0.1
ZIP - https://wordpress.org/themes/download/interserver-platinum.0.1.zip?nostats=1

History:


https://themes.svn.wordpress.org/interserver-platinum/0.1/screenshot.jpg

Attachments (2)

long_title_doesnt_works_well.png (161.1 KB) - added by audrasjb 4 weeks ago.
iframe_video_inserts_are_breaking_your_design.png (879.6 KB) - added by audrasjb 4 weeks ago.

Download all attachments as: .zip

Change History (15)

#1 @themetracbot
4 weeks ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#2 @audrasjb
4 weeks ago

Hi @InterServer.Net Web Hosting ,

I'll be reviewing your theme *Interserver Platinum* in the following days. I’m already on it.
Since this is my second theme review, I will try to be consistent with the guidelines.

Cheers,
Jb

#3 @audrasjb
4 weeks ago

Hi,

I reviewed your theme with the following tools:

  • Unit Test Data from https://codex.wordpress.org/Theme_Unit_Test
  • WP_DEBUG mode
  • Theme Check plugin
  • Theme Sniffer plugin
  • Query Monitor plugin
  • Debug Bar plugin
  • Log Deprecated Notices plugin
  • Monster Widget plugin
  • WordPress Beta Tester plugin
  • Regenerate Thumbnails plugin

My review is based on WordPress Theme review handbook: https://make.wordpress.org/themes/handbook/get-involved/become-a-reviewer/

Your theme was reviewed against WordPress Theme Guidelines and using Unit Test Data. I also run all specific stuff you included in your theme like Template Pages, Widgets, Menus, Customizer options and so on.

On the following points, you'll find 3 sections:

  • Required items: needs to be checked and fixed.
  • Recommended items: best practices for themes but not essential. No theme will be resolved as not approved because they do not meet a recommended item.
  • Reviewer notes: my personal notes on things which are not listed in Required or Recommended items.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Required

  • template-tags.php + init.php + inc/customizer.php + /lib/tgm/class-tgm-plugin-activation.php - Remove the_posts_navigation(), the_archive_title(), the_archive_description() because these are already available in core (your file mention « remove this when WordPress 4.3 is released » so please remove it. There is a lot of require_once, too, please check these files and sorry for not mentioning them all :)
  • inc/extras.php (L.69): The title tag must not be used. Use add_theme_support( 'title-tag' ) instead.
  • /js/jquery.min.js: File appears to be minified and cannot be processed. The non-minified file must be included too. In this particular case, do you really need to include jQuery since it’s included by default in WordPress?
  • /lib/tgm/class-tgm-plugin-activation.php: missing several sanitization for $_GET or $_POST:
  • Credits: there is no credit in your readme.txt file for the pictures used in the /image folder.
  • lib/tgm/class-tgm-plugin-activation.php: Many gettext calls containing placeholders were found, but were not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
  • Title should not overflow the content area: with (very) long titles, your design break. You should use -ms-word-wrap: break-word; word-wrap: break-word; on text that can break if there is a too Lon word. See screenshot below.
  • JS errors: out of the box, we have the following JS error: custom.js:90 Uncaught ReferenceError: header_style is not defined at custom.js:90 & at custom.js:108
  • Iframe insertion: YouTube video insertion (without oEmbed method) is breaking your design (See screenshot below). It can be resolved quickly with appropriate short CSS rule.
  • You have a reference to add_editor_style() in the theme. But this stylesheet seems to be unused in you theme. You call editor-style.css instead of /css/editor-style.css in functions.php.
  • Clearing floats: when I use a floating picture in a post, the pagination link is floating instead of appearing under the floating image. You need a CSS rule to clear floating elements.
  • Displays "Read More" link properly: read more links seems to not be displayed as links to the full content in posts.
  • Displaying dates: For output based on the user setting, use the_time( get_option( 'date_format' ) ). At a first glance, you are not using internationalized time output, specifically in interserver_platinum_posted_on function. Ca you check it deeply please?
  • WordPress CSS Best Practices: words are not always separated with a dash. E.g: header_info

Reviewer notes

  • You styled abbr HTML tags which is great, thanks! However I'll recommend you to add text-decoration: none CSS declaration to avoid browser default override (seen in Chrome/OSX).
  • Semantics: tag cloud should output a HTML unordered list of items to be more accessible to screen reader users (then, item count is available, etc). But not mandatory for you theme validation.
  • About HTML Validation errors:
  • Error: Duplicate ID slidecaption1. <div id="slidecaption1" class="nivo-html-caption">
  • Error: Bad value designer for attribute rel on element a: The string designer is not a registered keyword. <a target="_blank" rel="designer" href="https://www.interserver.net/">


Feel free to ask about anything you need. I hope everything is clear and precise in this review.

Cheers,
Jb

#4 @themetracbot
3 weeks ago

  • Summary changed from THEME: Interserver Platinum – 0.1 to THEME: Interserver Platinum – 1.1.0

Interserver Platinum - 1.1.0

Interserver Platinum is a latest portfolio theme for various type of businesses. It is easily customizable and have various options in the admin section for the pages and the layouts. Follow these steps to manage Home page :1. Create a new page and choose the Front Page Template for this page. 2. Go to Appearancs &gt; Customize &gt; Static Front Page and set the above page as a static page for front page displays. 3. The slider on the homepage is the post slider so you have to create posts to make the slider work. The other sections of the home page can be managed from Appearancs &gt; Customize &gt; Home Page Sections.

Theme URL -
Author URL - https://profiles.wordpress.org/interservernet-web-hosting

Trac Browser - https://themes.trac.wordpress.org/browser/interserver-platinum/1.1.0

SVN - https://themes.svn.wordpress.org/interserver-platinum/1.1.0
ZIP - https://wordpress.org/themes/download/interserver-platinum.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=interserver-platinum/0.1&new_path=interserver-platinum/1.1.0

History:


https://themes.svn.wordpress.org/interserver-platinum/1.1.0/screenshot.jpg

#5 @audrasjb
3 weeks ago

Thanks for the update.
I will review this in the next couple of days.

#6 @audrasjb
3 weeks ago

Hi,

Thank you for the corrections.
There are some errors found in your new version. They are all classified as required, so please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

  • Custom template files should be called using get_template_part() or locate_template()
  • interserver-platinum/inc/customizer.php (L. 21, 24, 27)
  • interserver-platinum/inc/init.php (L. 10, 15, 20, 25, 30, 33, 39, 44, 45, 46, 52, 57, 62)
  • Escaping issues:
  • interserver-platinum/inc/template-tags.php (L. 71, 87): __( ) function should be escaped properly.
  • File appears to be minified and cannot be processed. The non-minified file must be included too:
  • interserver-platinum/js/jquery.min.js (I guess you dont need jQuery as it is part of WordPress. Please remove this file and use WordPress's one).
  • Having a POT file accorded to your theme. The only Filename you should use must be interserver-platinum.pot (you have other filenames in this folder) OR you can remove the whole languages folder if you want to take advantage of WordPress Language Pack (translate.w.org), which I recommend.

Have a nice day,
Jb

Version 0, edited 3 weeks ago by audrasjb (next)

#7 @themetracbot
3 weeks ago

  • Summary changed from THEME: Interserver Platinum – 1.1.0 to THEME: Interserver Platinum – 1.1.1

Interserver Platinum - 1.1.1

Interserver Platinum is a latest portfolio theme for various type of businesses. It is easily customizable and have various options in the admin section for the pages and the layouts. Follow these steps to manage Home page :1. Create a new page and choose the Front Page Template for this page. 2. Go to Appearancs &gt; Customize &gt; Static Front Page and set the above page as a static page for front page displays. 3. The slider on the homepage is the post slider so you have to create posts to make the slider work. The other sections of the home page can be managed from Appearancs &gt; Customize &gt; Home Page Sections.

Theme URL -
Author URL - https://profiles.wordpress.org/interservernet-web-hosting

Trac Browser - https://themes.trac.wordpress.org/browser/interserver-platinum/1.1.1

SVN - https://themes.svn.wordpress.org/interserver-platinum/1.1.1
ZIP - https://wordpress.org/themes/download/interserver-platinum.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=interserver-platinum/1.1.0&new_path=interserver-platinum/1.1.1

History:


https://themes.svn.wordpress.org/interserver-platinum/1.1.1/screenshot.jpg

#8 @audrasjb
3 weeks ago

  • Status changed from reviewing to approved

Hi,

There are still some warnings reported by Theme Sniffer and during my manual review but the required elements seem to be fixed, thanks.

I will now move the ticket to approved status.

As this is only my second review, that does not mean that the theme will be live right now. An experienced reviewer will now take the ticket and perform a final review to eventually raise additional points that I may not have seen.

You will hear about this in few days.

Cheers,
Jb

#9 @poena
3 days ago

  • Status changed from approved to reopened

#10 @poena
3 days ago

Hi!
I have completed the second review.
The following needs to be fixed before your theme can go live:

Required
Themes may have a single footer credit link, which is restricted to the Theme URI or Author URI defined in style.css.

In inc\customizer\defaults.php
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
"default" is not unique enough.

Line 25: please do not use xyz@… as default, cc.com is an existing site, please use example.com instead.

In inc\customizer\controls.php, there is also a function that is not prefixed: flag_is_custom_slider_height.

Themes are required to use WordPress functionality if available, this includes using the WordPress custom logo instead of a custom option. See https://developer.wordpress.org/reference/functions/the_custom_logo/

In basic.php, interserver_platinum_get_image_alt, do not use guid to identify the file.
The guid is not updated if for example the site is moved so it will not always be the correct url for the image you want.
See: https://codex.wordpress.org/Changing_The_Site_URL#Important_GUID_Note

In structure.php, interserver_platinum_head,
<link rel="pingback" href="<?php bloginfo( 'pingback_url' ); ?>">
should be conditional since pingbacks can be closed.

In inc\customizer\styles.php, The options for body font and the heading font are not escaped on output?

Your readme.txt file refers to "Solon". If your theme is based on Solon or if you have borrowed code from the theme,
you need to provide attribution (Include a reference such as theme name, license and copyright).

Front:
Pages does not show page titles.


Please reply within 7 days.

Last edited 3 days ago by poena (previous) (diff)

#11 @themetracbot
2 days ago

  • Summary changed from THEME: Interserver Platinum – 1.1.1 to THEME: Interserver Platinum – 1.1.2

Interserver Platinum - 1.1.2

Interserver Platinum is a latest portfolio theme for various type of businesses. It is easily customizable and have various options in the admin section for the pages and the layouts. Follow these steps to manage Home page :1. Create a new page and choose the Front Page Template for this page. 2. Go to Appearancs &gt; Customize &gt; Static Front Page and set the above page as a static page for front page displays. 3. The slider on the homepage is the post slider so you have to create posts to make the slider work. The other sections of the home page can be managed from Appearancs &gt; Customize &gt; Home Page Sections.

Theme URL - https://www.interserver.net
Author URL - https://profiles.wordpress.org/interservernet-web-hosting

Trac Browser - https://themes.trac.wordpress.org/browser/interserver-platinum/1.1.2

SVN - https://themes.svn.wordpress.org/interserver-platinum/1.1.2
ZIP - https://wordpress.org/themes/download/interserver-platinum.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=interserver-platinum/1.1.1&new_path=interserver-platinum/1.1.2

History:


https://themes.svn.wordpress.org/interserver-platinum/1.1.2/screenshot.jpg

#12 @poena
34 hours ago

  • Status changed from reopened to reviewing

#13 @poena
34 hours ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi!
Thank you, most of the issues have been fixed, so I will set the theme live.

But you must re-add the attribution to Underscores and Solon, it is required by the GPL.

Remove if ( function_exists( 'the_custom_logo'
themes may be backwards compatible for 3 versions, the_custom_logo was added in 4.5.0.

Note: See TracTickets for help on using tickets.