WordPress.org

Make WordPress Themes

Opened 2 months ago

Closed 2 months ago

#46879 closed theme (live)

THEME: Headstart – 0.9.1

Reported by: writerstheme Owned by: rabmalin
Priority: previously reviewed Keywords: theme-headstart
Cc: writerthemehelp@…

Description

Headstart - 0.9

Headstart is a stylish, clean and elegant multipurpose WordPress theme. Clean design is perfect for almost every blog or magazine – fashion & beauty, food & health, travel, parenting and more. Configuring the theme is very easy. The max menu depth is 2.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/headstart/0.9

SVN - https://themes.svn.wordpress.org/headstart/0.9
ZIP - https://wordpress.org/themes/download/headstart.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=headstart/0.8&new_path=headstart/0.9

History:

Ticket Summary Status Resolution Owner
#44939 THEME: Headstart – 0.8 closed closed-newer-version-uploaded Mahesh901122
#46879 THEME: Headstart – 0.9.1 closed live rabmalin

(this ticket)

#46990 THEME: Headstart – 1.1 closed live themetracbot
#46991 THEME: Headstart – 1.2 closed live themetracbot
#46994 THEME: Headstart – 1.3 closed live themetracbot
#47264 THEME: Headstart – 1.4 closed live themetracbot
#47288 THEME: Headstart – 1.5 closed live themetracbot
#47294 THEME: Headstart – 1.6 closed live themetracbot
#47469 THEME: Headstart – 1.7 closed live themetracbot
#47470 THEME: Headstart – 1.8 closed live themetracbot
#47472 THEME: Headstart – 1.9 closed live themetracbot
#48819 THEME: Headstart – 2.0 closed live themetracbot
#48822 THEME: Headstart – 2.1 closed live themetracbot
#48834 THEME: Headstart – 2.2 closed live themetracbot
#48886 THEME: Headstart – 2.3 closed live themetracbot
#48888 THEME: Headstart – 2.4 closed live themetracbot
#48889 THEME: Headstart – 2.5 closed live williampatton
#48891 THEME: Headstart – 2.6 closed live themetracbot
#48892 THEME: Headstart – 2.7 closed live themetracbot
#48897 THEME: Headstart – 2.8 closed live themetracbot
#48901 THEME: Headstart – 2.9 closed live themetracbot
#48936 THEME: Headstart – 3.0 closed live themetracbot
#49137 THEME: Headstart – 3.1 closed live themetracbot


https://themes.svn.wordpress.org/headstart/0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (7)

#1 @rabmalin
2 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#2 follow-up: @writerstheme
2 months ago

Always scary when you do the review @rabmalin :) Let me know if I can do anything to ease up the process, and thank you for doing this <3

#3 @rabmalin
2 months ago

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: functions.php L182 - Change handle script foundation-js to foundation. There wont be conflict even if handle is same for style and script.
  • REQUIRED: functions.php L207 - In style or script handle, do not use _. Use - to separate words. Also, use handle like this jquery-slick
  • REQUIRED: readme.txt - Headstart WordPress Theme, Copyright 2017. Copyright owner is missing. Use following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: http://madeforwriters.com/wp-content/uploads/2017/09/free-for-commercial-use.png - I dont find the license declaration of this image in the site. Can you please point me to correct link where license is declared?
  • REQUIRED: front-clients.php L11 - Inside HTML attributes, use esc_attr__() rather than esc_html__(). Please check in other templates also.
  • REQUIRED: front-clients.php L13 - PHP tags missing.
  • REQUIRED: href="<?php echo wp_kses_post(get_theme_mod('header_left_button_link')) ?>" - Always use esc_url() to escape value inside href. Do not use wp_kses_post() for URL value. Please check in other places also.
  • REQUIRED: Please remove this as the_posts_pagination() is already available in core. You dont need to define it in the theme.
    if ( ! function_exists( 'the_posts_pagination' ) ) :
    /**
     * Display navigation to next/previous set of posts when applicable.
     *
     * @since Twenty Fourteen 1.0
     *
     * @global WP_Query   $wp_query   WordPress Query object.
     * @global WP_Rewrite $wp_rewrite WordPress Rewrite object.
     */
    function the_posts_pagination() {
            the_posts_pagination( array(               
                'mid_size'      => 3,
                'prev_text' => __( 'Previous', 'headstart' ),
                'next_text' => __( 'Next', 'headstart' ),
                'type'      => 'list',
            ));
    }
    endif;
    

#4 in reply to: ↑ 2 @rabmalin
2 months ago

Replying to writerstheme:

Always scary when you do the review @rabmalin :) Let me know if I can do anything to ease up the process, and thank you for doing this <3

No need to be scared. I just follow the guidelines. Thats it :-)

#5 @themetracbot
2 months ago

  • Summary changed from THEME: Headstart – 0.9 to THEME: Headstart – 0.9.1

Headstart - 0.9.1

Headstart is a stylish, clean and elegant multipurpose WordPress theme. Clean design is perfect for almost every blog or magazine – fashion &amp; beauty, food &amp; health, travel, parenting and more. Configuring the theme is very easy. The max menu depth is 2.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/headstart/0.9.1

SVN - https://themes.svn.wordpress.org/headstart/0.9.1
ZIP - https://wordpress.org/themes/download/headstart.0.9.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=headstart/0.9&new_path=headstart/0.9.1

History:

Ticket Summary Status Resolution Owner
#44939 THEME: Headstart – 0.8 closed closed-newer-version-uploaded Mahesh901122
#46879 THEME: Headstart – 0.9.1 closed live rabmalin

(this ticket)

#46990 THEME: Headstart – 1.1 closed live themetracbot
#46991 THEME: Headstart – 1.2 closed live themetracbot
#46994 THEME: Headstart – 1.3 closed live themetracbot
#47264 THEME: Headstart – 1.4 closed live themetracbot
#47288 THEME: Headstart – 1.5 closed live themetracbot
#47294 THEME: Headstart – 1.6 closed live themetracbot
#47469 THEME: Headstart – 1.7 closed live themetracbot
#47470 THEME: Headstart – 1.8 closed live themetracbot
#47472 THEME: Headstart – 1.9 closed live themetracbot
#48819 THEME: Headstart – 2.0 closed live themetracbot
#48822 THEME: Headstart – 2.1 closed live themetracbot
#48834 THEME: Headstart – 2.2 closed live themetracbot
#48886 THEME: Headstart – 2.3 closed live themetracbot
#48888 THEME: Headstart – 2.4 closed live themetracbot
#48889 THEME: Headstart – 2.5 closed live williampatton
#48891 THEME: Headstart – 2.6 closed live themetracbot
#48892 THEME: Headstart – 2.7 closed live themetracbot
#48897 THEME: Headstart – 2.8 closed live themetracbot
#48901 THEME: Headstart – 2.9 closed live themetracbot
#48936 THEME: Headstart – 3.0 closed live themetracbot
#49137 THEME: Headstart – 3.1 closed live themetracbot


https://themes.svn.wordpress.org/headstart/0.9.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#6 @writerstheme
2 months ago

Hehe of course @rabmalin
I've edited everything you have mentioned so we should be good to go!

#7 @rabmalin
2 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
  • REQUIRED: Inside HTML attributes, use esc_attr__() rather than esc_html__(). - I think you missed the part Inside HTML attributes in my comment. Eg, title, alt, etc. You were not supposed to replace all esc_html__(). :-)

Setting theme live. Please scan your theme again and fix accordingly in next update as soon as possible.

Note: See TracTickets for help on using tickets.