WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 2 months ago

Last modified 2 months ago

#46939 closed theme (live)

THEME: Qusq Lite – 1.0.5

Reported by: ishyoboy Owned by: scorpionthemes
Priority: previously reviewed Keywords: theme-qusq-lite
Cc: hello@…, Mirucon

Description

Qusq Lite - 1.0.1

Qusq Lite is a unique colourful portfolio theme, perfectly suitable for designers, freelancers & all kind of artist who want to show off their creative work with style. It covers all the necessary pages such a portfolio website might need.

Theme URL - https://ishyoboy.com/themes/qusq-pro/
Author URL - http://ishyoboy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/qusq-lite/1.0.1

SVN - https://themes.svn.wordpress.org/qusq-lite/1.0.1
ZIP - https://wordpress.org/themes/download/qusq-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=qusq-lite/1.0&new_path=qusq-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#45866 THEME: Qusq Lite – 1.0 closed not-approved poena
#46939 THEME: Qusq Lite – 1.0.5 closed live scorpionthemes

(this ticket)


https://themes.svn.wordpress.org/qusq-lite/1.0.1/screenshot.png

Change History (23)

#1 @ishyoboy
4 months ago

@poena Any chance to have a look? We made a lot of changes after #45866

#2 follow-up: @poena
4 months ago

Hi
Without checking the code, I can tell that the screen shot does not follow the requirements.

The waiting time for a full review is 8 weeks. You can reduce this by starting to review themes.

Last edited 4 months ago by poena (previous) (diff)

#3 @themetracbot
4 months ago

  • Summary changed from THEME: Qusq Lite – 1.0.1 to THEME: Qusq Lite – 1.0.2

Qusq Lite - 1.0.2

Qusq Lite is a unique colourful portfolio theme, perfectly suitable for designers, freelancers & all kind of artist who want to show off their creative work with style. It covers all the necessary pages such a portfolio website might need.

Theme URL - https://ishyoboy.com/themes/qusq-pro/
Author URL - http://ishyoboy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/qusq-lite/1.0.2

SVN - https://themes.svn.wordpress.org/qusq-lite/1.0.2
ZIP - https://wordpress.org/themes/download/qusq-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=qusq-lite/1.0.1&new_path=qusq-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#45866 THEME: Qusq Lite – 1.0 closed not-approved poena
#46939 THEME: Qusq Lite – 1.0.5 closed live scorpionthemes

(this ticket)


https://themes.svn.wordpress.org/qusq-lite/1.0.2/screenshot.png

#4 in reply to: ↑ 2 @ishyoboy
4 months ago

Replying to poena:

Hi
Without checking the code, I can tell that the screen shot does not follow the requirements.

The waiting time for a full review is 8 weeks. You can reduce this by starting to review themes.

Thank you very much for your feedback! It is much appreciated. It's our first theme in here and we're trying our best.
Speaking of reviewing themes, I've been playing with this idea for a very long time, but have the feeling that I am still too unsure about the quality of the review I could provide. Don't want to mess up.

#5 @poena
4 months ago

Themes that are approved by new reviewers are checked by a moderator before they go live.

So if you miss something it will hopefully be spotted in the final review.

All reviews are public so you can even read some old completed reviews to learn.

#6 @themetracbot
3 months ago

  • Owner set to scorpionthemes
  • Status changed from new to reviewing

#7 @scorpionthemes
3 months ago

Dear @ishyoboy

Please fix the following things

  1. Install Required Plugins not allowed but you can recommend

2.Credit to Images Used in Screenshot and JS/CSS as well they must be GPL

  1. Content Creation is not allowed, what you have used in side nav area and footer better do it with text widget
  2. Functionality - > Color functions not working in customiser
  3. No feature should be behind the paywal, in your case page template, color, animation while creating pages
  4. Screnshot should be obtained by few click but I am unable to get like screenshot
  5. Encoded script is. not allowed

Please Fix the above issue and reply within a 7 days . if you have any question you can ask here

thank you

Last edited 3 months ago by scorpionthemes (previous) (diff)

#8 @themetracbot
3 months ago

  • Summary changed from THEME: Qusq Lite – 1.0.2 to THEME: Qusq Lite – 1.0.3

Qusq Lite - 1.0.3

Qusq Lite is a unique colourful portfolio theme, perfectly suitable for designers, freelancers & all kind of artist who want to show off their creative work with style. It covers all the necessary pages such a portfolio website might need.

Theme URL - https://ishyoboy.com/themes/qusq-pro/
Author URL - http://ishyoboy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/qusq-lite/1.0.3

SVN - https://themes.svn.wordpress.org/qusq-lite/1.0.3
ZIP - https://wordpress.org/themes/download/qusq-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=qusq-lite/1.0.2&new_path=qusq-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#45866 THEME: Qusq Lite – 1.0 closed not-approved poena
#46939 THEME: Qusq Lite – 1.0.5 closed live scorpionthemes

(this ticket)


https://themes.svn.wordpress.org/qusq-lite/1.0.3/screenshot.png

#9 @ishyoboy
3 months ago

Dear @scorpionthemes,

We just uploaded a new version 1.0.3

1.) Install Required Plugins not allowed but you can recommend

We don't install any plugins automatically. We only used TGMPA class ( http://tgmpluginactivation.com/ ) which recommends to install Jetpack plugin to include portfolio functionality of theme. We believe this is allowed as it is only recommendation.

2.) Credit to Images Used in Screenshot and JS/CSS as well they must be GPL
We replaced the images with GPL images from Pixabay. Do we explicitly have to specify the license somewhere? If yes then where?

3.) Content Creation is not allowed, what you have used in side nav area and footer better do it with text widget
We have removed these sections from customiser. The users can easily use PO/MO files or override the templates in a child theme.

4.) Functionality - > Color functions not working in customiser
Thank you very much for pointing this out. It got broken after awe did modification to pass the approval in a previous rejection. Now it should work like charm ;)

5.) No feature should be behind the paywal, in your case page template, color, animation while creating pages
We have removed all mentioned features as you suggested.

6.) Screnshot should be obtained by few click but I am unable to get like screenshot
Screenshot was taken from portfolio page which can be set as homepage. It is very easy to achieve the same page as you can see on screenshot. Install Jetpack plugin, create one or more portfolio products and then insert custom title and subtitle. You can then see result under "portfolio" slug. plus if you create a page, set it as homepage and choose the "Homepage - Portfolio" template for it you will have it on front.

7.) Encoded script is. not allowed
We removed our minimisation of scripts and are using only the original vendor scripts. We believe using the original ".min.js" versions is much more suitable as 99% of users never touch those and if they do, the scripts are freely available in min and non-min versions. We see that original minified versions from 3rd party modules are used on many of the recently approved themes. Hope it is ok like used right now.

Thanks again for your time!

#10 @scorpionthemes
3 months ago

This is just a reply for your answer I will review again

  1. replace the word required with recommended
  2. image url and license links should be specified follow following format * https://pixabay.com/en/entrepreneur-startup-start-up-man-593358/, [CC0] https://creativecommons.org/publicdomain/zero/1.0/
  3. control it with post or pages , so featured image can be used as image and title and excerpt for other , rest you can do anything in pro version
  4. great
  5. great
  6. Provide documentation link for that so that easy for reviewer too
  7. you can use min version but have to provide unminified version too in theme file

Please follow these thing , there is always some exception case who is reviewing it , but as I am theme developer . so I am just following the point when I was rejected :D

thank you

#11 @themetracbot
3 months ago

  • Summary changed from THEME: Qusq Lite – 1.0.3 to THEME: Qusq Lite – 1.0.4

Qusq Lite - 1.0.4

Qusq Lite is a unique colourful portfolio theme, perfectly suitable for designers, freelancers & all kind of artist who want to show off their creative work with style. It covers all the necessary pages such a portfolio website might need.

Theme URL - https://ishyoboy.com/themes/qusq-pro/
Author URL - http://ishyoboy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/qusq-lite/1.0.4

SVN - https://themes.svn.wordpress.org/qusq-lite/1.0.4
ZIP - https://wordpress.org/themes/download/qusq-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=qusq-lite/1.0.3&new_path=qusq-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#45866 THEME: Qusq Lite – 1.0 closed not-approved poena
#46939 THEME: Qusq Lite – 1.0.5 closed live scorpionthemes

(this ticket)


https://themes.svn.wordpress.org/qusq-lite/1.0.4/screenshot.png

#12 @ishyoboy
3 months ago

Dear @scorpionthemes,

1.) replace the word required with recommended
Done! ;)

2.) Credit to Images Used in Screenshot and JS/CSS as well they must be GPL
We used these images for generating screenshot of Qusq theme:
https://pixabay.com/en/passenger-vehicle-transportation-2159409/ , [CC0]
https://pixabay.com/en/space-travel-rocket-porthole-window-1784461/ , [CC0]
https://pixabay.com/en/aircraft-paper-blue-background-1314333/ , [CC0]

3.) Content Creation is not allowed, what you have used in side nav area and footer better do it with text widget

We have removed these sections from customiser and user can simple use standard WordPress functionality to translate these strings. We are not sure what exactly you mean in your answer under this point. But we believe, this solution is sufficient and "WordPress" enough ;)

6.) Provide documentation link for that so that easy for reviewer too

https://themes.ishyoboy.com/qusq/doc/#Portfolio
Here is documentation link where you can find how to achieve the same page as you can see on screenshot.
Link to documentation is also available in "Appearance -> Qusq Lite", tab "Getting Started" and point 3. "Read The Documentation".

7.) you can use min version but have to provide unminified version too in theme file
Unminified files were also attached.

#13 @scorpionthemes
3 months ago

Dear @ishyoboy

I am approving this theme at the moment , wait for the final review from admin

thank you

#14 @scorpionthemes
3 months ago

  • Status changed from reviewing to approved

#15 @ishyoboy
3 months ago

@scorpionthemes Thank you very much for your time and help! Looking forward to see the result!

#16 @Mirucon
2 months ago

  • Cc Mirucon added
  • Status changed from approved to reopened

I will do this final. I'll get back to you as soon as I completed the review :)

#17 @Mirucon
2 months ago

  • Status changed from reopened to reviewing

@ishyoboy Here are some issues that need to be addressed. I like your theme because it uses modern features and management systems :)

Required:

  • URLs should be escaped with esc_url() rather than esc_attr(). For example, on footer.php L66,
    href="https://' . esc_attr( 'ishyoboy.com' ) . '/"
    

Should be:

href="' . esc_url( 'https://ishyoboy.com/' ) . '"

However, there is no need to make URLs escaped unless you make these translatable. So in that case like footer.php, you can simply write URL.

  • If you'd like to change the length of excerpt content, you should use the hook excerpt_length, and use the_excerpt() instead of implementing your own function. If you have a reason that the function is needed and cannot be replaced with the core function, please let me know why.
  • I am not sure how the function qusq_lite_remove_tile_replacement_from_content works, but it seems like modifying user's content. Which is not allowed here, themes should not remove/modify users' content. Also, make sure that qusq_lite_the_content_without_shortcode is not modifying the content.
  • You should declare ALL the credits that you bundle in your theme, including packages that are coming from bower, and the images used in the screenshot as well.

Notes:

Here are just some notes for you. Not necessary to fix, but they would be best practices for the theme.

I love your code which is mostly compatible with WPCS. However, there are some mistakes in these rules.

I would recommend using the tool called PHPCBF which bundled in PHPCS. The tool will automatically fix basic coding standards errors.

Here is a super minor issue that cannot be detected with PHPCS :D

#18 @themetracbot
2 months ago

  • Summary changed from THEME: Qusq Lite – 1.0.4 to THEME: Qusq Lite – 1.0.5

Qusq Lite - 1.0.5

Qusq Lite is a unique colourful portfolio theme, perfectly suitable for designers, freelancers & all kind of artist who want to show off their creative work with style. It covers all the necessary pages such a portfolio website might need.

Theme URL - https://ishyoboy.com/themes/qusq-pro/
Author URL - http://ishyoboy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/qusq-lite/1.0.5

SVN - https://themes.svn.wordpress.org/qusq-lite/1.0.5
ZIP - https://wordpress.org/themes/download/qusq-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=qusq-lite/1.0.4&new_path=qusq-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#45866 THEME: Qusq Lite – 1.0 closed not-approved poena
#46939 THEME: Qusq Lite – 1.0.5 closed live scorpionthemes

(this ticket)


https://themes.svn.wordpress.org/qusq-lite/1.0.5/screenshot.png

#19 @ishyoboy
2 months ago

Hi @Mirucon,

Thank you very much for the review and your very friendly comments and remarks. We went through all of them and addressed each one. Here is our outcome:

1. URLs should be escaped

Fixed! And thank you for the explanation. Still used the "esc_url" to avoid the Theme Check "info" line :) I like everything clean.

2. the_excerpt and excerpt_length

Fixed! The main reason was to use the same length of characters as opposed to how WordPress handles it - 55 words. If we use character the layout looks much cleaner and uniform, but I do agree keeping the original way is much wiser.

3. qusq_lite_remove_tile_replacement_from_content function

In order to make the headers much more visually attractive, we give the users the ability to use h1, h2 and additional text and even highlight the words within it. See our documentation https://themes.ishyoboy.com/qusq/doc/#AdvancedHeaderTitles. So basically we are only using this function to take the headlines out of the content and place them in the header and not in the content.

The content always remains there for the user, even if they switch to a different theme and if the "Advanced Titles" are used they are always displayed. If not, this function does nothing. As mentioned, this feature is absolutely optional and it is up to the user to decide if they want to use the Title as is or invest a little more energy to make it look super nice ;)

4. qusq_lite_the_content_without_shortcode function

The only use for this function is to extract the gallery & contact shortcodes from the content and display them in a different place within the template. This is only happens if the right template is used.

So in our case, instead of requiring the user to use additional HTML or special "GRID" shortcodes to achieve a multi column layout. We provide them with a static template which uses the regular content and just displays it in a nicer way. The main reason is to let the content be the content and the template to handle the layout. https://themes.ishyoboy.com/qusq/doc/#Contact

Again this is only used in a Page Template file which the user can chose so otherwise the content remains untouched.

We really believe this is ideologically correct. Keeping the content a content.

5. Credits & License

Fixed! All changed added as per the article.

6. The additional notes ;)

We fixed the package underscores. And left the WPCS errors as they come from external JS file which we do not want to update as they are being loaded automatically via bower. The check used to be clean when we were using the minified versions of the JS files but we were forced to also add unminified versions which again made the errors appear.

7. THANK YOU

Thank you for your very personal remarks and we are very glad to see new technology and tools are actually welcomed as we had the impression that everything should pass in a very shaped way and nothing new is considered as added value and were afraid it would actually be a problem. Very glad to see that you guys are open to different approaches as well!

This ticket was mentioned in Slack in #themereview by ithemer. View the logs.


2 months ago

This ticket was mentioned in Slack in #themereview by ithemer. View the logs.


2 months ago

#22 @Mirucon
2 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @ishyoboy,

Your theme is now live, it will show up in the repository shortly!

I can see that these two functions are keeping the users' data, so they would be fine for me. It is really nice to have theme documentation.

Here are some issues that need to be fixed in the next update.

  • If you use esc_url(), it should include an URL protocol, such as http:// and https://. Otherwise the function will add a protocol automatically. I saw it in several places like inc/mu-modules/customizer-enhancement.php L116.

#23 @ishyoboy
2 months ago

Hi @Mirucon,

Thank you very much for this Christmas surprise ;) You are right, we will definitely resolve the mentioned issues!
For now we wish you a very peaceful time spent with your family & friends and mary mary Christmas.

Cheer,
Vlad & the whole IshYoBoy Team

Note: See TracTickets for help on using tickets.