WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 9 days ago

#46969 closed theme (live)

THEME: Blossom Feminine – 1.0.2

Reported by: blossomthemes Owned by: rodicaelena
Priority: new theme Keywords: theme-blossom-feminine
Cc: info@…

Description

Blossom Feminine - 1.0.0

Blossom Feminine is a free theme for female bloggers.

Theme URL -
Author URL - http://blossomthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blossom-feminine/1.0.0

SVN - https://themes.svn.wordpress.org/blossom-feminine/1.0.0
ZIP - https://wordpress.org/themes/download/blossom-feminine.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/blossom-feminine/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'blossom-feminine'

Change History (11)

#1 @rodicaelena
4 weeks ago

  • Owner set to rodicaelena
  • Status changed from new to reviewing

#2 @rodicaelena
4 weeks ago

Hi @blossomthemes ,

I'm Rodica and I'm gonna review your theme.
Here is my review:

Theme check results that need to be fixed:
WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'blossom-feminine'
WARNING: .idea Hidden Files or Folders found.

NS Theme check results that need to be fixed:
blossom-feminine/inc/custom-controls/repeater/class-control-repeater.php
93 ERROR Middle may not be omitted from ternary operators in PHP < 5.3

blossom-feminine/inc/extras.php
236 ERROR Overriding WordPress globals is prohibited

blossom-feminine/inc/partials.php
36 ERROR The $text arg must be a single string literal, not "date_i18n( 'Y' )".

Instead of blossom_feminine_woo_hide_page_title you should use return_false

selectize.js license is not mentioned in the readme file

Please upload an update in the next 7 days or let me know if you need more time.

Regards,
Rodica

#3 @blossomthemes
3 weeks ago

Hi @rodicaelena, Thank you for the review. We will need some more days to submit new update.

Thank you.

#4 @rodicaelena
2 weeks ago

Hi @blossomthemes ,

Do you still need time for this? Please let me know.

Regards,
Rodica

#5 @blossomthemes
2 weeks ago

Hi @rodicaelena, we will submit the theme today in a few hours.

#6 @themetracbot
2 weeks ago

  • Summary changed from THEME: Blossom Feminine – 1.0.0 to THEME: Blossom Feminine – 1.0.1

Blossom Feminine - 1.0.1

Blossom Feminine is a free theme for female bloggers.

Theme URL - https://blossomthemes.com/themes/blossom-feminine-free-wordpress-theme
Author URL - http://blossomthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blossom-feminine/1.0.1

SVN - https://themes.svn.wordpress.org/blossom-feminine/1.0.1
ZIP - https://wordpress.org/themes/download/blossom-feminine.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blossom-feminine/1.0.0&new_path=blossom-feminine/1.0.1

History:


https://themes.svn.wordpress.org/blossom-feminine/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @blossomthemes
2 weeks ago

Hi @rodicaelena, we have fixed the issues. We have also made a few changes. Please check.

#8 @rodicaelena
13 days ago

Hi @blossomthemes ,

Thank you for the update.
This was not fixed:
Instead of blossom_feminine_woo_hide_page_title you should use return_false

Plus, on the homepage, when your latest posts option is selected, I can't see all the posts. There are always all the posts, except the last two added, or something. Please check that too.

Regards,
Rodica

#9 @themetracbot
9 days ago

  • Summary changed from THEME: Blossom Feminine – 1.0.1 to THEME: Blossom Feminine – 1.0.2

Blossom Feminine - 1.0.2

Blossom Feminine is a free theme for female bloggers.

Theme URL - https://blossomthemes.com/themes/blossom-feminine-free-wordpress-theme
Author URL - http://blossomthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blossom-feminine/1.0.2

SVN - https://themes.svn.wordpress.org/blossom-feminine/1.0.2
ZIP - https://wordpress.org/themes/download/blossom-feminine.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blossom-feminine/1.0.1&new_path=blossom-feminine/1.0.2

History:


https://themes.svn.wordpress.org/blossom-feminine/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#10 @blossomthemes
9 days ago

Hi @rodicaelena, We have uploaded a new version of Blossom Feminine.

Instead of blossom_feminine_woo_hide_page_title you should use return_false

FIXED

Plus, on the homepage, when your latest posts option is selected, I can't see all the posts. There are always all the posts, except the last two added, or something. Please check that too.

Checked, we've excluded the slider post in blog listing may thats the reason.

#11 @rodicaelena
9 days ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @blossomthemes ,

Thank you for the update! Everything seems ok now. I'll mark the theme as approves.

Regards,
Rodica

Note: See TracTickets for help on using tickets.