WordPress.org

Make WordPress Themes

Opened 2 weeks ago

Closed 4 days ago

#46977 closed theme (live)

THEME: Stacker Lite – 1.0.4

Reported by: themefurnace Owned by: rabmalin
Priority: theme update Keywords: theme-stacker-lite
Cc: olidale+wordpress@…

Description

Stacker Lite - 1.0.3

Stacker is a Grid-Based theme for showing off your photos and images. Includes a social media links menu to display icons linking to your favourite social media sites. Customize the colors and amount of columns via the Cutomizer. Download 22 more Free themes and templates at ThemeFurnace : http://themefurnace.com

Theme URL - http://themefurnace.com/stacker-theme
Author URL - http://www.themefurnace.com

Trac Browser - https://themes.trac.wordpress.org/browser/stacker-lite/1.0.3

SVN - https://themes.svn.wordpress.org/stacker-lite/1.0.3
ZIP - https://wordpress.org/themes/download/stacker-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stacker-lite/1.0.2&new_path=stacker-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#23555 THEME: Stacker Lite – 1.0 closed not-approved lancewillett
#24142 THEME: Stacker Lite – 1.0.1 closed live lancewillett
#24230 THEME: Stacker Lite – 1.0.2 closed live jacenty3590
#46977 THEME: Stacker Lite – 1.0.4 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/stacker-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are stacker-lite, themefurnace

Change History (13)

#1 @themetracbot
2 weeks ago

  • Owner set to themetracbot
  • Status changed from new to reviewing

Theme Update for existing Live theme - automatically reviewed

#2 @themetracbot
2 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Theme Update for existing Live theme - automatically approved

This ticket was mentioned in Slack in #themereview by olidale. View the logs.


13 days ago

This ticket was mentioned in Slack in #themereview by olidale. View the logs.


12 days ago

#5 @rabmalin
12 days ago

  • Resolution live deleted
  • Status changed from closed to reopened

#6 @rabmalin
12 days ago

  • Owner changed from themetracbot to rabmalin
  • Status changed from reopened to reviewing

#7 @rabmalin
12 days ago

Please fix following issues.

Issues

  • REQUIRED: style.css L11 - Text Domain should be stacker-lite.
  • REQUIRED: There should not be menu parameter in wp_nav_menu() call. Use theme_location parameter.
  • REQUIRED: Remove this code remove_filter( 'get_the_excerpt', 'wp_trim_excerpt' ); [Plugin Territory]
  • REQUIRED: Remove themefurnace_render_title()
  • REQUIRED: Use the_archive_title() to display archive title in archive templates.
  • REQUIRED: alt="<?php the_title(); ?>" - Inside HTML attribute, the_title_attribute() should be used.
  • REQUIRED: Escape get_category_link() with esc_url().
  • REQUIRED: Remove stacker_load_homepage_column_count() from header.php and use wp_head hook to add CSS.
  • REQUIRED: stacker_load_homepage_column_count() - Please escape value obtained from get_theme_mod( 'stacker_homepage_columns', '3' )
  • REQUIRED: Remove stacker_Textarea_Control custom control. Textarea control is already available in WP core.
  • REQUIRED: Remove stacker_wp_title(). See https://codex.wordpress.org/Title_Tag

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/stacker-lite/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 27 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

Time: 25119956 mins, 49.02 secs; Memory: 4Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/stacker-lite/footer.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
 26 | ERROR | Mismatch text domain. Expected 'stacker-lite' but got 'themefurnace'.
------------------------------------------------------------------------------------

Time: 25119956 mins, 49.15 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/stacker-lite/functions.php
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 191 | ERROR | The title tag must not be used. Use add_theme_support( 'title-tag' ) instead.
---------------------------------------------------------------------------------------------

Time: 25119956 mins, 49.2 secs; Memory: 4Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/stacker-lite/inc/custom-header.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 42 | ERROR | Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.
------------------------------------------------------------------------------------------------------------

Time: 25119956 mins, 49.29 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/stacker-lite/inc/extras.php
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 94 | ERROR | Overriding WordPress globals is prohibited
-----------------------------------------------------------------------------------

Time: 25119956 mins, 49.35 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/stacker-lite/inc/template-tags.php
------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
  18 | ERROR | Overriding WordPress globals is prohibited
 154 | ERROR | Strings should have translatable content
------------------------------------------------------------------------------------------

#8 @rabmalin
9 days ago

@themefurnace Any updates?

#9 @themefurnace
8 days ago

Hi, I will get the updates done this week.

#10 @themetracbot
6 days ago

  • Summary changed from THEME: Stacker Lite – 1.0.3 to THEME: Stacker Lite – 1.0.4

Stacker Lite - 1.0.4

Stacker is a Grid-Based theme for showing off your photos and images. Includes a social media links menu to display icons linking to your favourite social media sites. Customize the colors and amount of columns via the Cutomizer. Download 22 more Free themes and templates at ThemeFurnace : http://themefurnace.com

Theme URL - http://themefurnace.com/stacker-theme
Author URL - http://www.themefurnace.com

Trac Browser - https://themes.trac.wordpress.org/browser/stacker-lite/1.0.4

SVN - https://themes.svn.wordpress.org/stacker-lite/1.0.4
ZIP - https://wordpress.org/themes/download/stacker-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stacker-lite/1.0.3&new_path=stacker-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#23555 THEME: Stacker Lite – 1.0 closed not-approved lancewillett
#24142 THEME: Stacker Lite – 1.0.1 closed live lancewillett
#24230 THEME: Stacker Lite – 1.0.2 closed live jacenty3590
#46977 THEME: Stacker Lite – 1.0.4 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/stacker-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#11 @rabmalin
6 days ago

  • Status changed from reviewing to approved

#12 @rabmalin
6 days ago

@poena Please set this theme live from the back-end.

#13 @poena
4 days ago

  • Resolution set to live
  • Status changed from approved to closed

I suppose the ticket should also be closed

Note: See TracTickets for help on using tickets.