Make WordPress Themes

Opened 6 months ago

Closed 3 months ago

Last modified 8 weeks ago

#47039 closed theme (not-approved)

THEME: Newspaper for WP – 1.0

Reported by: ahmedkaludi Owned by: greenturtlelab
Priority: new theme Keywords: theme-newspaper-for-wp
Cc: ahmed@…

Change History (8)

#1 @poena
4 months ago

-This is not a complete review.
A reviewer will be assigned to your theme as soon as one is available, mean while, please fix the problems listed below:

The following needs to be fixed before your theme can be added to the directory

Declare licenses of any resources included such as fonts or images.
No minification of scripts or files unless you provide original files.

Theme URI is optional. If used, it must be about the theme we’re hosting on WordPress.org.

In header.php:
Themes are required to use existing functionality if available, this includes
using get_search_form() instead of hard coding the forms.
You can still make changes by editing searchform.php or using the filters:

All theme text strings are to be translatable.
This includes text meant for screen-readers.

esc_attr() should only be used in actual html attributes, such as alt, title, placeholder etc.
If you want to escape content that is between html tags, please use esc_html() instead.

<h3><?php echo esc_attr( 'Navigate', 'newspaper_for_wp' ) ?></h3>

Why is there two full width templates? I was just wondering if one was left by mistake.
The library folder is empty.

#2 @themetracbot
4 months ago

  • Owner set to greenturtlelab
  • Status changed from new to reviewing

#3 @greenturtlelab
4 months ago

Hi , I am reviewing your theme. I will post my findings soon.
Thank You.

#4 @greenturtlelab
3 months ago

Hi @ahmedkaludi
First make sure that you have to fix a the issues pointed by @poena .
Running the NS Theme Check plugin I found this errors:

Line 28: ERROR Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

Line 94: ERROR Strings should have translatable content

Line: 119 : ERROR Strings should have translatable content


Last edited 3 months ago by greenturtlelab (previous) (diff)

#5 @rabmalin
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing ticket due to no response.

#6 @ahmedkaludi
8 weeks ago

Hi @rabmalin @greenturtlelab @themetracbot @poena

I am extremely sorry for the delay. I was traveling for last few weeks so I couldn't check. I have been working on this for few months and waiting patiently but then due to my traveling, I did not notice and it got closed, which is very sad for me because I put a lot of time and efforts in this theme.

Can anyone please help me to get this theme back in the review queue? So that I can submit my changes?

Please let me know.

#7 @poena
8 weeks ago

You can still submit your update but a new ticket will be created.
If we see that you have made an effort to fix all the problems listed in the reviews and if I have time I might be able to look at the ticket next weekend.

#8 @ahmedkaludi
8 weeks ago


Oh that would be great! I will start working on the update and send it to you in a couple of days.

Thank you so much!! You are a Life Saver!

Note: See TracTickets for help on using tickets.