WordPress.org

Make WordPress Themes

Opened 2 months ago

Last modified 9 days ago

#47039 reviewing theme

THEME: Newspaper for WP – 1.0

Reported by: ahmedkaludi Owned by: greenturtlelab
Priority: new theme Keywords: theme-newspaper-for-wp
Cc: ahmed@…

Change History (4)

#1 @poena
2 weeks ago

Hi
-This is not a complete review.
A reviewer will be assigned to your theme as soon as one is available, mean while, please fix the problems listed below:

The following needs to be fixed before your theme can be added to the directory

Declare licenses of any resources included such as fonts or images.
No minification of scripts or files unless you provide original files.

Theme URI is optional. If used, it must be about the theme we’re hosting on WordPress.org.

In header.php:
Themes are required to use existing functionality if available, this includes
using get_search_form() instead of hard coding the forms.
You can still make changes by editing searchform.php or using the filters:
https://developer.wordpress.org/reference/functions/get_search_form/

All theme text strings are to be translatable.
This includes text meant for screen-readers.

esc_attr() should only be used in actual html attributes, such as alt, title, placeholder etc.
If you want to escape content that is between html tags, please use esc_html() instead.

<h3><?php echo esc_attr( 'Navigate', 'newspaper_for_wp' ) ?></h3>

Why is there two full width templates? I was just wondering if one was left by mistake.
The library folder is empty.

#2 @themetracbot
2 weeks ago

  • Owner set to greenturtlelab
  • Status changed from new to reviewing

#3 @greenturtlelab
2 weeks ago

Hi , I am reviewing your theme. I will post my findings soon.
Thank You.

#4 @greenturtlelab
9 days ago

Hi @ahmedkaludi
First make sure that you have to fix a the issues pointed by @poena .
Running the NS Theme Check plugin I found this errors:

newspaper-for-wp/comments.php
Line 28: ERROR Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

Line 94: ERROR Strings should have translatable content

newspaper-for-wp/header.php
Line: 119 : ERROR Strings should have translatable content

Thanks

Last edited 9 days ago by greenturtlelab (previous) (diff)
Note: See TracTickets for help on using tickets.