WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 2 months ago

Last modified 7 weeks ago

#47042 closed theme (live)

THEME: Notable – 1.0.2

Reported by: themesforbloggers Owned by: pratikgandhi
Priority: new theme Keywords: theme-notable
Cc: info@…

Description

Notable - 1.0.0

Notable is a big bold travel blog theme, designed to feature your beautiful travel photos and stories. The home page has an optional posts slider which let’s you set up a specific slider category for those posts you want to feature there. On the home page you can also choose to (optionally) feature some static pages right below the slider too. Of course you can set colors, social media links, and logo through the Customizer so you can make it your own without any coding required. Happy trails.

Theme URL - http://themesforbloggers.com/themes/notable/
Author URL - http://themesforbloggers.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notable/1.0.0

SVN - https://themes.svn.wordpress.org/notable/1.0.0
ZIP - https://wordpress.org/themes/download/notable.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#47042 THEME: Notable – 1.0.2 closed live pratikgandhi

(this ticket)

#50085 THEME: Notable – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/notable/1.0.0/screenshot.png

Attachments (1)

notable theme menu.png (157.3 KB) - added by pratikgandhi 2 months ago.

Download all attachments as: .zip

Change History (19)

#1 @themetracbot
3 months ago

  • Owner set to pratikgandhi
  • Status changed from new to reviewing

#2 @pratikgandhi
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Please check the attached screenshot of the sub menu issue in the front end.Other than theme is clear and good job done on overall work.

#3 @themesforbloggers
2 months ago

@pratikgandhi thank you for your time to review my theme.

BTW the part that you point out is okay, its part of the design. :)

#4 @themesforbloggers
2 months ago

why is this being close and not approve? @pratikgandhi it about 32hrs since you comment and you didn't reply for 8 day. please let me know

#5 @rabmalin
2 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#6 @rabmalin
2 months ago

  • Status changed from reopened to reviewing

#7 @pratikgandhi
2 months ago

  • Status changed from reviewing to approved

Other than the above issue the theme is approved.

Thanks

#8 @poena
2 months ago

@pratikgandhi
Hi! Did you do a full code and license review of the theme?

Please remember that design issues are only recommended, we only require these to be changed if it breaks the theme.

#9 @pratikgandhi
2 months ago

@poena Yes, I checked the code review of the files.

I got it about the design issues.

Thanks

#10 @poena
2 months ago

Great then I will check it shortly.

#11 @poena
2 months ago

  • Status changed from approved to reopened

Hi!
The following minor problems needs to be fixed before the theme can go live:

In index.php (and customizer.php), there are references to theme mods that does not exist,
optional_first_page_setting and optional_second_page_setting.

In customizer.php, notable_apply_color, the theme mods need to be escaped, not only echoed.

In header.php,
L18: the pingback_url should be conditional, since pingbacks can be turned off.
L29: Please escape the width and height attributes.
L37: Remove the if function_exist, themes may only be backwards compatible for 3 verions.

There is an image size that needs to be prefixed, or it might be overwritten:
widget-post-thumb in functions.php line 40 and widget.php line 39.

Please include the name of the licenses for the assets, not only the links.
For example gLyphicons have several different licenses, the "free" version is licensed under CC BY 3.0 which is not GPL compatible (only 4.0 is), but the halflings used in Bootstrap are licensed as MIT and are compatible.


Note:

In search.php, get_search_query() does not need to be escaped again because it is already escaped with esc_attr() by default.
https://developer.wordpress.org/reference/functions/get_search_query/#source


Please reply within 7 days.

#12 @themetracbot
2 months ago

  • Summary changed from THEME: Notable – 1.0.0 to THEME: Notable – 1.0.1

Notable - 1.0.1

Notable is a big bold travel blog theme, designed to feature your beautiful travel photos and stories. The home page has an optional posts slider which let’s you set up a specific slider category for those posts you want to feature there. On the home page you can also choose to (optionally) feature some static pages right below the slider too. Of course you can set colors, social media links, and logo through the Customizer so you can make it your own without any coding required. Happy trails.

Theme URL - http://themesforbloggers.com/themes/notable/
Author URL - http://themesforbloggers.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notable/1.0.1

SVN - https://themes.svn.wordpress.org/notable/1.0.1
ZIP - https://wordpress.org/themes/download/notable.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notable/1.0.0&new_path=notable/1.0.1

History:

Ticket Summary Status Resolution Owner
#47042 THEME: Notable – 1.0.2 closed live pratikgandhi

(this ticket)

#50085 THEME: Notable – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/notable/1.0.1/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function _e, with the arguments '

#13 @themetracbot
2 months ago

  • Summary changed from THEME: Notable – 1.0.1 to THEME: Notable – 1.0.2

Notable - 1.0.2

Notable is a big bold travel blog theme, designed to feature your beautiful travel photos and stories. The home page has an optional posts slider which let’s you set up a specific slider category for those posts you want to feature there. On the home page you can also choose to (optionally) feature some static pages right below the slider too. Of course you can set colors, social media links, and logo through the Customizer so you can make it your own without any coding required. Happy trails.

Theme URL - http://themesforbloggers.com/themes/notable/
Author URL - http://themesforbloggers.com/

Trac Browser - https://themes.trac.wordpress.org/browser/notable/1.0.2

SVN - https://themes.svn.wordpress.org/notable/1.0.2
ZIP - https://wordpress.org/themes/download/notable.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=notable/1.0.1&new_path=notable/1.0.2

History:

Ticket Summary Status Resolution Owner
#47042 THEME: Notable – 1.0.2 closed live pratikgandhi

(this ticket)

#50085 THEME: Notable – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/notable/1.0.2/screenshot.png

#14 @themesforbloggers
2 months ago

@poena minor problems was fixed.. looking forward to make this theme live soon.

thanks

#15 @poena
2 months ago

  • Status changed from reopened to reviewing

#16 @poena
2 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi!
Most of the problems were fixed, so I am setting the theme live.
It should show up in the directory shortly.

Please fix these issues in your next update:

Add the name of the license for these assets:

============================================
This theme uses GLYPHICONS Halflings in Bootstrap
============================================
 * http://glyphicons.com/license/ 
 * License for GLYPHICONS Halflings in Bootstrap
 * GLYPHICONS Halflings font is also released as an extension of a Bootstrap www.getbootstrap.com for free and it is released under the same license as   Bootstrap. While you are not required to include attribution on your Bootstrap-based projects, I would certainly appreciate any form of support, even   a nice Tweet is enough. Of course if you want, you can say thank you and support me by buying more icons on GLYPHICONS.com.
 
============================================
This theme uses Bootstrap as a design tool
============================================
 * Bootstrap (http://getbootstrap.com/)
 * Copyright (c) 2011-2014 Twitter, Inc
 * Licensed under https://github.com/twbs/bootstrap/blob/master/LICENSE

Missing prefix (and typo):

themes\notable\functions.php:
40: 	add_image_size( 'notabl-widget-post-thumb',  70, 70, true );

themes\notable\inc\widget.php:
39: the_post_thumbnail('widget-post-thumb', array('class' => 'alignleft'));


#17 @themesforbloggers
8 weeks ago

@poena sorry Im not sure about the name that you mention on the assets..
I thought the name for GLYPHICONS is (License for GLYPHICONS Halflings in Bootstrap)
and for Bootstrap is (Bootstrap)..

Can you please let me know how I can get the correct licensed name?

thanks

#18 @poena
7 weeks ago

Hi!
You are confusing the name of the asset with the name of the license.

The name of the license is missing.
The name of the asset is complete.

Note: See TracTickets for help on using tickets.