WordPress.org

Make WordPress Themes

Opened 2 months ago

Last modified 8 days ago

#47044 reviewing theme

THEME: Chocka – 1.0.5

Reported by: chocka Owned by: bandthemes
Priority: previously reviewed Keywords: theme-chocka
Cc: greene.brian2018@…

Description

Chocka - 1.0.5

Chocka is a fully responsive blogzine style theme suitable for personal blogs and magazine style content sites. It has contemporary bold fonts and a simple, easily customizable, color scheme. It also makes good use of featured images so you can showcase great photography too.

Theme URL - http://chocka.co.nz/about-this-theme/
Author URL - http://chocka.co.nz

Trac Browser - https://themes.trac.wordpress.org/browser/chocka/1.0.5

SVN - https://themes.svn.wordpress.org/chocka/1.0.5
ZIP - https://wordpress.org/themes/download/chocka.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=chocka/1.0.4&new_path=chocka/1.0.5

History:

Ticket Summary Status Resolution Owner
#41335 THEME: Chocka – 1.0.4 closed not-approved meissudeep
#47044 THEME: Chocka – 1.0.5 reviewing bandthemes

(this ticket)


https://themes.svn.wordpress.org/chocka/1.0.5/screenshot.png

Change History (3)

#1 @rabmalin
11 days ago

Note: This is not a full review.

Your theme will be reviewed when your theme reaches to the top of the Review Queue and review process will follow procedures found in the Theme Handbook. Please check it thoroughly and fix your theme accordingly. If 3 or more distinct issues are found, ticket could be closed as not approved.

In the mean time, please check following issues.

Issues

  • REQUIRED: Unsplash images are not allowed from June 9, 2017 as some terms are conflicting with GPL. Please change image.
  • RECOMMENDED: add_theme_support( 'custom-header', $defaults ); - You may want to add here width and height parameter also. Otherwise there may be problem in cropping header image. Please check it.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/chocka/footer.php
-------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------
 12 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
 26 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
-------------------------------------------------------------------------

Time: 25207817 mins, 43.19 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/chocka/header.php
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
 30 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
-------------------------------------------------------------------------

Time: 25207817 mins, 43.3 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/chocka/inc/functions/template-hooks.php
-----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------
 25 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
 26 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
-----------------------------------------------------------------------------------------------

#2 @themetracbot
10 days ago

  • Owner set to bandthemes
  • Status changed from new to reviewing

#3 @bandthemes
8 days ago

@chocka it's just in addition, don't forget to fix previous comment.

  • inc/customizer/controls.php
    'description'   => '': Pass something to it. That's the reason you declare it.
    
  • Prefixing, common third-party scripts and styles should use generic handle (unless modified from the original) so that they will not load twice if used also by a plugin ex:
    wp_enqueue_script( 'bootstrap', get_template_directory_uri() . '/assets/js/bootstrap.min.js', array('jquery'), '', true );
    
Note: See TracTickets for help on using tickets.