WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 5 weeks ago

#47073 closed theme (live)

THEME: Slightly – 1.0.9

Reported by: nickcil Owned by: rabmalin
Priority: previously reviewed Keywords: theme-slightly accessibility-ready
Cc: nickciliak@…

Description

Slightly - 1.0.1

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.1

SVN - https://themes.svn.wordpress.org/slightly/1.0.1
ZIP - https://wordpress.org/themes/download/slightly.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.0&new_path=slightly/1.0.1

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

Attachments (1)

slightly.zip (193.9 KB) - added by nickcil 2 months ago.
Slightly v1.0.2

Download all attachments as: .zip

Change History (38)

#1 @themetracbot
3 months ago

  • Owner set to ravioza
  • Status changed from new to reviewing

#2 follow-up: @ravioza
2 months ago

Hi @nickcil,

  • Required for Accessibility :
    • Need to include alt attributes with Images
  • Note: Looks like some button style issue in comments section. Please refer scresnshot.

#3 in reply to: ↑ 2 @nickcil
2 months ago

Replying to ravioza:

Hi @nickcil,

  • Required for Accessibility :
    • Need to include alt attributes with Images
  • Note: Looks like some button style issue in comments section. Please refer scresnshot.

Thanks @ravioza, great catch! I will fix and update.

@nickcil
2 months ago

Slightly v1.0.2

#4 follow-up: @nickcil
2 months ago

Hi @ravioza, I've added the updated theme as an attachment here. (v1.0.2) Do I need to create a new ticket for it? I wasn't sure. Thanks for your help!

EDIT: Oh, I just updated it again and see that it got added to this ticket. Nevermind :)

Last edited 2 months ago by nickcil (previous) (diff)

#5 @themetracbot
2 months ago

  • Keywords changed from theme-slightly, accessibility-ready to theme-slightly accessibility-ready
  • Summary changed from THEME: Slightly – 1.0.1 to THEME: Slightly – 1.0.2

Slightly - 1.0.2

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.2

SVN - https://themes.svn.wordpress.org/slightly/1.0.2
ZIP - https://wordpress.org/themes/download/slightly.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.1&new_path=slightly/1.0.2

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#6 in reply to: ↑ 4 @ravioza
2 months ago

Replying to nickcil:

Great!!!

Will check and update accordingly.

Hi @ravioza, I've added the updated theme as an attachment here. (v1.0.2) Do I need to create a new ticket for it? I wasn't sure. Thanks for your help!

EDIT: Oh, I just updated it again and see that it got added to this ticket. Nevermind :)

#7 follow-up: @ravioza
2 months ago

@nickcil,

  • Issues with Customizer options
    • Site Logo, if added appears large in size.
    • Tag line is not appearing on all of the pages, even if its checked under Customize > Site branding.
    • Header Text and Image customization is not reflecting.
    • Background color customization is available under Customize > Colors, color value something similar to body text color will make the pages unreadable. It is recommended to have text color customization.
  • Fix the above issues, if you chooses to keep the functionality. It is also recommended to add respective tags(e.g. custom-header)

#8 @themetracbot
2 months ago

  • Summary changed from THEME: Slightly – 1.0.2 to THEME: Slightly – 1.0.3

Slightly - 1.0.3

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.3

SVN - https://themes.svn.wordpress.org/slightly/1.0.3
ZIP - https://wordpress.org/themes/download/slightly.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.2&new_path=slightly/1.0.3

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#9 in reply to: ↑ 7 @nickcil
2 months ago

Hi @ravioza, thanks for catching this. I've made some changes!

  • The site logo will be whatever size the image is. So if you upload a large logo it will be large, if you want a smaller one the image should be small.
  • I removed the tagline option in Customizer because it was unused in the theme.
  • Removed the header text and image from Customizer because it was unused as well.
  • I added a Body Text Color setting to the Customizer. All of the text in the theme will not change color with this option, but it's a little better than before.

Replying to ravioza:

@nickcil,

  • Issues with Customizer options
    • Site Logo, if added appears large in size.
    • Tag line is not appearing on all of the pages, even if its checked under Customize > Site branding.
    • Header Text and Image customization is not reflecting.
    • Background color customization is available under Customize > Colors, color value something similar to body text color will make the pages unreadable. It is recommended to have text color customization.
  • Fix the above issues, if you chooses to keep the functionality. It is also recommended to add respective tags(e.g. custom-header)

#10 @nickcil
2 months ago

Oh shoot, I got to excited removing things and realized that the tagline IS actually being used, but only on one page. One sec, I will re add that...

#11 @themetracbot
2 months ago

  • Summary changed from THEME: Slightly – 1.0.3 to THEME: Slightly – 1.0.4

Slightly - 1.0.4

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.4

SVN - https://themes.svn.wordpress.org/slightly/1.0.4
ZIP - https://wordpress.org/themes/download/slightly.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.3&new_path=slightly/1.0.4

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#12 @ravioza
2 months ago

  • Tagline changes in Customizer are not reflecting in the view, requires page refresh.
Last edited 2 months ago by ravioza (previous) (diff)

#13 @themetracbot
2 months ago

  • Summary changed from THEME: Slightly – 1.0.4 to THEME: Slightly – 1.0.5

Slightly - 1.0.5

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.5

SVN - https://themes.svn.wordpress.org/slightly/1.0.5
ZIP - https://wordpress.org/themes/download/slightly.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.4&new_path=slightly/1.0.5

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#14 @nickcil
2 months ago

Oops -- my mistake. Thank you for catching that! It's fixed now :) I've also cleaned up some sass variables which is why other files have been changed, but it shouldn't affect much.

Thank you!

#15 @ravioza
2 months ago

  • Status changed from reviewing to approved

Looks fine!

#16 @Mirucon
2 months ago

  • Status changed from approved to reopened

#17 @Mirucon
2 months ago

  • Status changed from reopened to reviewing

This theme needs accessibility review before approval.

Pinging @joedolson @davidakennedy @poena

#18 @themetracbot
2 months ago

  • Summary changed from THEME: Slightly – 1.0.5 to THEME: Slightly – 1.0.6

Slightly - 1.0.6

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.6

SVN - https://themes.svn.wordpress.org/slightly/1.0.6
ZIP - https://wordpress.org/themes/download/slightly.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.5&new_path=slightly/1.0.6

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#19 @nickcil
2 months ago

Hello! I've made a couple small updates (1.0.6) to the theme to prepare for the forthcoming accessibility review. I hope this is okay. A summary of the changes:

  • Made :focus styles visually stronger and more consistent.
  • Adjusted featured images on some page templates to display as img elements as to include the alt tag.
  • Sidebar page template now correctly displays h1 element for the title. (Previously no h1 element on that page template)
  • More body copy link style consistency. Links are also now bolder.

Thank you!

#20 @joedolson
2 months ago

Here's your accessibility review: pretty close, a few minor things to address.

1) Keyboard Navigation - Fail

  • Menu toggle button has no :focus state
  • Mobile menu does not close when loses focus, but covers focusable content on the page. Several possible solutions: 1) automatically close menu if user leaves the menu; 2) Add a close menu button at end of menu; 3) Constrain focus while in menu so tabbing cycles through the menu and gives opportunity to close menu; 4) Don't cover content when menu is expanded

2) Controls - Pass

3) Skip Links - Pass

4) Forms - Pass

5) Headings - Fail

  • "Read this next" is H5, and is significantly out of sequence. Should either be H1 or not a heading.

6) ARIA Landmark Roles - Pass

7) Link Text - Pass

8) Contrasts - Fail

  • .post-edit-link has contrast ratio 1.79:1
  • .comment-edit-link has contrast ratio 2.81:1

9) Images - Pass

10) Media - None identified; default pass.

11) Not Allowed - Pass

Theme Accessibility Guidelines & Tips:
https://make.wordpress.org/themes/handbook/review/accessibility/required/

#21 @ravioza
2 months ago

@nickcil,

Go through the issues reported by @joedolson and submit the updated version.

#22 @nickcil
2 months ago

Thank you, I will fix these today!

#23 @themetracbot
2 months ago

  • Summary changed from THEME: Slightly – 1.0.6 to THEME: Slightly – 1.0.7

Slightly - 1.0.7

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.7

SVN - https://themes.svn.wordpress.org/slightly/1.0.7
ZIP - https://wordpress.org/themes/download/slightly.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.6&new_path=slightly/1.0.7

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#24 @nickcil
7 weeks ago

Hi @joedolson and @ravioza, it has been a week since my last update so I just wanted to check in to see where we are at with the review. Thank you! :)

#25 @ravioza
7 weeks ago

hi @nickcil,

@joedolson will check in next week and revert back.

#26 follow-up: @joedolson
6 weeks ago

It's very close. Be sure to test your next round of changes to the menu controls; the solution you implemented here doesn't work well, as it causes the menu to close too soon.

1) Keyboard Navigation - Fail

Menu closes as soon as top level menu item loses focus. Menu should only close if *nothing* in the menu is focused, and preferably only if the focus moves forward past the last item in the menu.

5) Headings - Pass

8) Contrasts - Pass

#27 @themetracbot
6 weeks ago

  • Summary changed from THEME: Slightly – 1.0.7 to THEME: Slightly – 1.0.8

Slightly - 1.0.8

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.8

SVN - https://themes.svn.wordpress.org/slightly/1.0.8
ZIP - https://wordpress.org/themes/download/slightly.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.7&new_path=slightly/1.0.8

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#28 in reply to: ↑ 26 @nickcil
6 weeks ago

Replying to joedolson:

It's very close. Be sure to test your next round of changes to the menu controls; the solution you implemented here doesn't work well, as it causes the menu to close too soon.

1) Keyboard Navigation - Fail

Menu closes as soon as top level menu item loses focus. Menu should only close if *nothing* in the menu is focused, and preferably only if the focus moves forward past the last item in the menu.

5) Headings - Pass

8) Contrasts - Pass

Thanks @joedolson! You're right, my first implementation of that mobile menu closing wasn't as reliable as I thought. The mobile nav should now close correctly when focus moves past the last nav item.

#29 @joedolson
5 weeks ago

Thank you! It's good to go. You're approved for accessibility-ready!

Best,
Joe

#30 @nickcil
5 weeks ago

Awesome, thanks @joedolson!

@ravioza what is the next step? Anything I need to do now?

#31 @ravioza
5 weeks ago

  • Status changed from reviewing to approved

@nickcil,

We got approval for accessibility-ready, so I am approving theme from my side.

You are not required to do anything, atleast for now.

Admin reviewer will take a look at it before making it live.

:)

#32 @rabmalin
5 weeks ago

  • Status changed from approved to reopened

#33 @rabmalin
5 weeks ago

  • Owner changed from ravioza to rabmalin
  • Status changed from reopened to reviewing

Doing final review.

#34 @rabmalin
5 weeks ago

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Translation issues - customizer.php L27. Please check in other places also.
  • REQUIRED: Escaping missing - customizer.php L41. Please check in other places also.
  • REQUIRED: alt="<?php echo esc_html( $alt ); ?>" - Inside HTML attribute, use esc_attr() to escape. In lots of attributes like alt, title, etc you are using esc_html(), please fix all.
  • REQUIRED: Change date('Y') to date_i18n(__('Y','textdomain'))
  • REQUIRED: Function call add_theme_support() should be inside function hooked to after_setup_theme. Check functions.php L144
  • REQUIRED: Do not prefix page template file name with page-. Use tpl- or template- or similar.
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: readme.txt - Credit for flexboxgrid.css missing.

Note:

  • Accessibility: In search form or comment form, I am not seeing any visual difference in the input fields (in Firefox browser). In Chrome, it looks good. You may want to test your theme in Firefox also.

#35 @themetracbot
5 weeks ago

  • Summary changed from THEME: Slightly – 1.0.8 to THEME: Slightly – 1.0.9

Slightly - 1.0.9

Slightly is a minimal, clean, ever-so-slightly opinionated WP theme for a beautifully simple start.

Theme URL - http://slightlytheme.com
Author URL - http://nickciliak.com

Trac Browser - https://themes.trac.wordpress.org/browser/slightly/1.0.9

SVN - https://themes.svn.wordpress.org/slightly/1.0.9
ZIP - https://wordpress.org/themes/download/slightly.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=slightly/1.0.8&new_path=slightly/1.0.9

History:

Ticket Summary Status Resolution Owner
#46946 THEME: Slightly – 1.0.0 closed not-approved acosmin
#47073 THEME: Slightly – 1.0.9 closed live rabmalin

(this ticket)


https://themes.svn.wordpress.org/slightly/1.0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#36 @nickcil
5 weeks ago

Hi @rabmalin, thank you for the review! I believe I have resolved all of the issues that you noted.

I wasn't able to see the issue with the inputs, however. I've tested the theme on the latest versions of Firefox, Chrome, and Safari on Mac. I adjusted a CSS property to try and solve it, but again I wasn't seeing the issue so I'm not sure if it did anything. If the problem persists would you please send a screenshot and maybe some more details? Thank you!

#37 @rabmalin
5 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Setting live.

Note: See TracTickets for help on using tickets.