WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 7 weeks ago

#47507 closed theme (closed-newer-version-uploaded)

THEME: Best Blog – 1.0.4

Reported by: imon Hasan Owned by: WPBrigade
Priority: new theme Keywords: theme-best-blog
Cc: imon.theme@…

Description

Best blog - 1.0.0

bestblog is a perfect WordPress theme for personal blogs, blog, content publishers .

Theme URL - http://imonthemes.com/bestblog-lite/
Author URL - http://imonthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-blog/1.0.0

SVN - https://themes.svn.wordpress.org/best-blog/1.0.0
ZIP - https://wordpress.org/themes/download/best-blog.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#47507 THEME: Best Blog – 1.0.4 closed closed-newer-version-uploaded WPBrigade

(this ticket)

#49931 THEME: Best Blog – 1.0.6 closed closed-newer-version-uploaded WPBrigade
#50197 THEME: Best Blog – 1.0.8 closed live WPBrigade
#50281 THEME: Best Blog – 1.0.9 closed live themetracbot
#50358 THEME: Best Blog – 1.1.0 closed live themetracbot
#51297 THEME: Best Blog – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/best-blog/1.0.0/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are best-blog, kirki

Change History (25)

#1 @themetracbot
2 months ago

  • Summary changed from THEME: Best blog – 1.0.0 to THEME: Best Blog – 1.0.1

Best Blog - 1.0.1

bestblog is a perfect WordPress theme for personal blogs, blog, content publishers .

Theme URL - http://imonthemes.com/bestblog-lite/
Author URL - http://imonthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-blog/1.0.1

SVN - https://themes.svn.wordpress.org/best-blog/1.0.1
ZIP - https://wordpress.org/themes/download/best-blog.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-blog/1.0.0&new_path=best-blog/1.0.1

History:

Ticket Summary Status Resolution Owner
#47507 THEME: Best Blog – 1.0.4 closed closed-newer-version-uploaded WPBrigade

(this ticket)

#49931 THEME: Best Blog – 1.0.6 closed closed-newer-version-uploaded WPBrigade
#50197 THEME: Best Blog – 1.0.8 closed live WPBrigade
#50281 THEME: Best Blog – 1.0.9 closed live themetracbot
#50358 THEME: Best Blog – 1.1.0 closed live themetracbot
#51297 THEME: Best Blog – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/best-blog/1.0.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are best-blog, kirki

#2 @themetracbot
8 weeks ago

  • Summary changed from THEME: Best Blog – 1.0.1 to THEME: Best Blog – 1.0.2

Best Blog - 1.0.2

bestblog is a perfect WordPress theme for personal blogs, blog, content publishers .

Theme URL - http://imonthemes.com/bestblog-lite/
Author URL - http://imonthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-blog/1.0.2

SVN - https://themes.svn.wordpress.org/best-blog/1.0.2
ZIP - https://wordpress.org/themes/download/best-blog.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-blog/1.0.1&new_path=best-blog/1.0.2

History:

Ticket Summary Status Resolution Owner
#47507 THEME: Best Blog – 1.0.4 closed closed-newer-version-uploaded WPBrigade

(this ticket)

#49931 THEME: Best Blog – 1.0.6 closed closed-newer-version-uploaded WPBrigade
#50197 THEME: Best Blog – 1.0.8 closed live WPBrigade
#50281 THEME: Best Blog – 1.0.9 closed live themetracbot
#50358 THEME: Best Blog – 1.1.0 closed live themetracbot
#51297 THEME: Best Blog – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/best-blog/1.0.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are best-blog, kirki

#3 @themetracbot
8 weeks ago

  • Summary changed from THEME: Best Blog – 1.0.2 to THEME: Best Blog – 1.0.3

Best Blog - 1.0.3

bestblog is a perfect WordPress theme for personal blogs, blog, content publishers .

Theme URL - http://imonthemes.com/bestblog-lite/
Author URL - http://imonthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-blog/1.0.3

SVN - https://themes.svn.wordpress.org/best-blog/1.0.3
ZIP - https://wordpress.org/themes/download/best-blog.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-blog/1.0.2&new_path=best-blog/1.0.3

History:

Ticket Summary Status Resolution Owner
#47507 THEME: Best Blog – 1.0.4 closed closed-newer-version-uploaded WPBrigade

(this ticket)

#49931 THEME: Best Blog – 1.0.6 closed closed-newer-version-uploaded WPBrigade
#50197 THEME: Best Blog – 1.0.8 closed live WPBrigade
#50281 THEME: Best Blog – 1.0.9 closed live themetracbot
#50358 THEME: Best Blog – 1.1.0 closed live themetracbot
#51297 THEME: Best Blog – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/best-blog/1.0.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are best-blog, kirki

#4 @themetracbot
7 weeks ago

  • Owner set to WPBrigade
  • Status changed from new to reviewing

#5 @WPBrigade
7 weeks ago

Hi @imon-hasan

I'm just assigned this theme to review. It is a formal message and let me know if you are active. Say Hello, and I will then start reviewing your theme.

If there is anything you want to change or update the version, Please do that and Reply.

Cheers!

#6 @themetracbot
7 weeks ago

  • Summary changed from THEME: Best Blog – 1.0.3 to THEME: Best Blog – 1.0.4

Best Blog - 1.0.4

Best Blog is a perfect WordPress theme for personal blogs, blog,content publishers. From travel to fashion and everything in between, Best Blog brings beauty and unique designs combined with quality performance and stability to any type of blog.

Theme URL - https://www.imonthemes.com/best-blog-wordpress-theme/
Author URL - http://imonthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-blog/1.0.4

SVN - https://themes.svn.wordpress.org/best-blog/1.0.4
ZIP - https://wordpress.org/themes/download/best-blog.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-blog/1.0.3&new_path=best-blog/1.0.4

History:

Ticket Summary Status Resolution Owner
#47507 THEME: Best Blog – 1.0.4 closed closed-newer-version-uploaded WPBrigade

(this ticket)

#49931 THEME: Best Blog – 1.0.6 closed closed-newer-version-uploaded WPBrigade
#50197 THEME: Best Blog – 1.0.8 closed live WPBrigade
#50281 THEME: Best Blog – 1.0.9 closed live themetracbot
#50358 THEME: Best Blog – 1.1.0 closed live themetracbot
#51297 THEME: Best Blog – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/best-blog/1.0.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are best-blog, kirki

#7 @imon Hasan
7 weeks ago

@WPBrigade Thank you for reviewing my theme. Please continue to review this version

#8 follow-up: @WPBrigade
7 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @imon-hasan

Sorry for closed the ticket because the themes that have 3 or more distinct issues may be closed as not-approved.

Required: No demo available in the Theme URI, Theme URI is optional if used as the URI to a demo site the content must be about the theme itself.
Required: You are not allowed to remove admin bar from theme
https://monosnap.com/file/novkuXuP0fmdctSKcahcVwMKngVrDa

Required: Theme should be free from any kind script errors i.e. Fata errors
https://monosnap.com/file/w4ny1j06yBKyNUYgfMEJLtnVM9w4LA

Required: Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.
Required: Provide a unique prefix for everything the Theme defines in the public namespace. Check file archive.php, slider.php and index.php etc.
Required: Customizer: header image is not displayed nor I can set it.
Required: Customizer: Background images is not changing.

#9 in reply to: ↑ 8 ; follow-up: @imon Hasan
7 weeks ago

Replying to WPBrigade:

Hi @imon-hasan

Sorry for closed the ticket because the themes that have 3 or more distinct issues may be closed as not-approved.

Required: No demo available in the Theme URI, Theme URI is optional if used as the URI to a demo site the content must be about the theme itself.

  • This is not Required . can you please give me ref ?

Required: You are not allowed to remove admin bar from theme
https://monosnap.com/file/novkuXuP0fmdctSKcahcVwMKngVrDa

  • in My end it is appear . Can you please check it in fresh install

Required: Theme should be free from any kind script errors i.e. Fata errors
https://monosnap.com/file/w4ny1j06yBKyNUYgfMEJLtnVM9w4LA

  • I will fixed it

Required: Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.

  • can you please give me code reference for that ?

Required: Provide a unique prefix for everything the Theme defines in the public namespace. Check file archive.php, slider.php and index.php etc.

  • can you please give me code reference for that ?

Required: Customizer: header image is not displayed nor I can set it.
Required: Customizer: Background images is not changing.

It is changing and not Required . can you please give me ref ?

I think you misunderstand. It said 3 distinct issue . So i have only 1 Required distinct issue

Code # (1 issue )

Required: Theme should be free from any kind script errors i.e. Fata errors
https://monosnap.com/file/w4ny1j06yBKyNUYgfMEJLtnVM9w4LA

Required: Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.

Required: Provide a unique prefix for everything the Theme defines in the public namespace. Check file archive.php, slider.php and index.php etc.

All are issues under Code .

This ticket was mentioned in Slack in #themereview by imonhasan. View the logs.


7 weeks ago

#11 @imon Hasan
7 weeks ago

@WPBrigade I want request you just give me one chance to upload new version please ?

#12 @Mirucon
7 weeks ago

It seems that it was closed rightly for me.
The three distinct issues are; Removing admin bar, fatal error and core customizer fields are not working.

But, if, the reviewer want to continue the review as these issues can be fixed easily, I'm happy to reopen the ticket.

Required: No demo available in the Theme URI, Theme URI is optional if used as the URI to a demo site the content must be about the theme itself.

There's no need to have one, the required thing on theme URI is that it shouldn't be test data.

Required: You are not allowed to remove admin bar from theme

https://monosnap.com/file/novkuXuP0fmdctSKcahcVwMKngVrDa

This is a required issue, I can see this style in <head>.
<style type="text/css" media="print">#wpadminbar { display:none; }</style>

Required: Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.

can you please give me code reference for that ?

I quickly checked customizer codes and there was no need to be sanitized, as Kirki does it. If there is another place where proper sanitizing is not provided, please just let us know.

Required: Theme should be free from any kind script errors i.e. Fata errors

https://monosnap.com/file/w4ny1j06yBKyNUYgfMEJLtnVM9w4LA

Yes, this is also a required issue.

Required: Provide a unique prefix for everything the Theme defines in the public namespace. Check file archive.php, slider.php and index.php etc.

I did see that everything was properly prefixed.

Required: Customizer: header image is not displayed nor I can set it.

Required: Customizer: Background images is not changing

These are also required, all the Core customizer fields mean to be worked in the theme. If you'd not like to implement these functionalities, you can simply remove these supports by removing add_theme_support().

And these are also required issues I found during the quick look of this theme.

  • Untranslatable strings are found; e.g. functions/menu.php L75.
  • There should not be any blank file; page-notitle_full_width.php.
  • Widget title should be passed through widget_title filter ‘’‘with parameters instance and id base’’’.
Last edited 7 weeks ago by Mirucon (previous) (diff)

#13 in reply to: ↑ 9 @WPBrigade
7 weeks ago

Hi, @imon-hasan

I just forget to mention the refrences in previous comment. Please read out the handbook clearly that was updated month ago.

Required: No demo available in the Theme URI, Theme URI is optional if used as the URI to a demo site the content must be about the theme itself.
“This is not Required . can you please give me ref ? “

Ref:
https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

Required: You are not allowed to remove admin bar from theme
https://monosnap.com/file/novkuXuP0fmdctSKcahcVwMKngVrDa
“in My end it is appear . Can you please check it in fresh install “

  • You are not making theme for your end only, I have checked on different machine and it’s the same problem on all of them.

Required: Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.
can you please give me code reference for that ?
Please read carefully third point.
https://make.wordpress.org/themes/handbook/review/required/#code

Required: Provide a unique prefix for everything the Theme defines in the public namespace. Check file archive.php, slider.php and index.php etc.
“can you please give me code reference for that ? “
Ref:
https://make.wordpress.org/themes/handbook/review/required/#code

Required: Customizer: header image is not displayed nor I can set it.
Required: Customizer: Background images is not changing.
“It is changing and not Required . can you please give me ref ?”
The two options mentioned above are not working at all, do I really have to give you reference to tell you; why to make sure your theme is working.

#14 @imon Hasan
7 weeks ago

@WPBrigade I understand and thank you for reviewing

I am uncertain upload this version and after i just find this fatal error and just requesting you to reopen this ticket please ?

  • because of this fatal error those issue appear

1) Required: You are not allowed to remove admin bar from theme
https://monosnap.com/file/novkuXuP0fmdctSKcahcVwMKngVrDa

2) fatal code error also

Not understand what happen with this them url ?

  • Required: Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.

Can you please point me out where you find this issue in my theme code ?

  • Required: Provide a unique prefix for everything the Theme defines in the public namespace. Check file archive.php, slider.php and index.php etc.

Can you please point me out where you find this issue in my theme code ?

Thank you very much

#15 @imon Hasan
7 weeks ago

Required: Customizer: header image is not displayed nor I can set it.

for this option, you should select Header background style Header image from theme option

https://imgur.com/a/eHlS5

Required: Customizer: Background images is not changing.

https://imgur.com/a/gxjgY

there is a screenshot about background image

#16 @WPBrigade
7 weeks ago

Hi, @Mirucon

Please give him a chance :)

Hello, @imon-hasan

Theme URI isn't working couple of hours ago, that's "Demo Link"

Please check out the whole theme for validation / Sanitization.
Please check the the complete files for prefix.

Any custom features, templates, options, customizer or any limitations (for example menu restrictions), should be explained. Enough documentation should be provided.
Ref: https://make.wordpress.org/themes/handbook/review/required/#documentation

Please readout the documentation clearly before upload you next version: https://make.wordpress.org/themes/handbook/review/required/

Thank you.

#17 @Mirucon
7 weeks ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#18 @Mirucon
7 weeks ago

  • Status changed from reopened to reviewing

Reopened :)

#19 @imon Hasan
7 weeks ago

@Mirucon and @WPBrigade thank you so much i will upload new version within 24 hours

I was check hole theme file one by one and not find prefix issue can you please point out me where i have this issue in my theme file

Again Thank you

#20 @WPBrigade
7 weeks ago

Just mention the files name above in comment:8

slider: http://prntscr.com/hwdhik
archive: http://prntscr.com/hwdi4u
index: http://prntscr.com/hwdigw

Hope it's clear now.

#21 @imon Hasan
7 weeks ago

Those need to prefix ? I don't think so

please check the defult theme twentyseventeen

https://themes.svn.wordpress.org/twentyseventeen/1.4/comments.php 

$comments_number
https://themes.svn.wordpress.org/twentyseventeen/1.4/template-parts/post/content-audio.php

$audio

$content

Thank you

#22 @Mirucon
7 weeks ago

Hi guys,

I did not see any functions/variables/classes that need to be prefixed. Everything seems to be fine on prefixing.
The variables mentioned in comment:20 are all not under the global scope.

#23 @imon Hasan
7 weeks ago

@Mirucon and @WPBrigade Thank you for your time

please continue the review in this ticket : https://themes.trac.wordpress.org/ticket/49931

Don't why new ticket is created

thank you

#24 @Mirucon
7 weeks ago

@rabmalin Would you close this as closed-newer-version-uploaded?

#25 @rabmalin
7 weeks ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.