WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 4 weeks ago

Last modified 3 weeks ago

#47592 closed theme (not-approved)

THEME: Newsgem – 0.6

Reported by: Ydesignservices Owned by: WPBrigade
Priority: new theme Keywords: theme-newsgem
Cc: contact@…

Description

Newsgem - 0.1

Newsgem is a clean and modern magazine, news or blog WordPress theme for magazines, news websites, blogs and others.Theme Features: Advanced Custom Fields, Contact Form, Custom Front Page Settings, Custom Background Support, Custom Menu

Theme URL - https://www.ydesignservices.com/newsgem-free-wordpress-theme/
Author URL - http://www.ydesignservices.com/

Trac Browser - https://themes.trac.wordpress.org/browser/newsgem/0.1

SVN - https://themes.svn.wordpress.org/newsgem/0.1
ZIP - https://wordpress.org/themes/download/newsgem.0.1.zip?nostats=1

History:


https://themes.svn.wordpress.org/newsgem/0.1/screenshot.png

Change History (15)

#1 @themetracbot
7 weeks ago

  • Summary changed from THEME: Newsgem – 0.1 to THEME: Newsgem – 0.2

Newsgem - 0.2

Newsgem is a clean and modern magazine, news or blog WordPress theme for magazines, news websites, blogs and others.Theme Features: Advanced Custom Fields, Contact Form, Custom Front Page Settings, Custom Background Support, Custom Menu

Theme URL - https://www.ydesignservices.com/product/free-wordpress-themes/newsgem-free/
Author URL - https://www.ydesignservices.com/

Trac Browser - https://themes.trac.wordpress.org/browser/newsgem/0.2

SVN - https://themes.svn.wordpress.org/newsgem/0.2
ZIP - https://wordpress.org/themes/download/newsgem.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newsgem/0.1&new_path=newsgem/0.2

History:


https://themes.svn.wordpress.org/newsgem/0.2/screenshot.png

#2 @themetracbot
7 weeks ago

  • Summary changed from THEME: Newsgem – 0.2 to THEME: Newsgem – 0.3

Newsgem - 0.3

Newsgem is a clean and modern magazine, news or blog WordPress theme for magazines, news websites, blogs and others.Theme Features: Advanced Custom Fields, Contact Form, Custom Front Page Settings, Custom Background Support, Custom Menu

Theme URL - https://www.ydesignservices.com/product/free-wordpress-themes/newsgem-free/
Author URL - https://www.ydesignservices.com/

Trac Browser - https://themes.trac.wordpress.org/browser/newsgem/0.3

SVN - https://themes.svn.wordpress.org/newsgem/0.3
ZIP - https://wordpress.org/themes/download/newsgem.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newsgem/0.2&new_path=newsgem/0.3

History:


https://themes.svn.wordpress.org/newsgem/0.3/screenshot.png

#3 @themetracbot
6 weeks ago

  • Owner set to WPBrigade
  • Status changed from new to reviewing

#4 @WPBrigade
6 weeks ago

Hi @Ydesignservices

I'm just assigned this theme to review. It is a formal message and let me know if you are active. Say Hello, and I will then start reviewing your theme.

If there is anything you want to change or update the version, Please do that and Reply.

Cheers!

#5 @Ydesignservices
6 weeks ago

Hello,

I will be waiting for your review.

Thanks.

#6 @WPBrigade
6 weeks ago

Hi, @Ydesignservices

You have 7 days to fix these issues. If you need more time please comment below.

Required: Please provide a concise documentation on usage of your provided options in customizer. The options are not self-explanatory i.e. “Author social settings”. Also make the user aware that he/she should first set the provided home template. Ref

Required: Customizer setting for “Share post settings” are not working. The share post icons are not disappearing on unchecking them.

Required: Escape all url used in content-single.php Ref

Required: Widgets.php; The default values in the fields of your widget is empty which make the following error to pop when widget is created “Notice: Undefined index: adsenseCode” or “Notice: Undefined index: title” etc. Please make sure you give a !empty() check when values are called.

#7 @themetracbot
5 weeks ago

  • Summary changed from THEME: Newsgem – 0.3 to THEME: Newsgem – 0.4

Newsgem - 0.4

Newsgem is a clean and modern magazine, news or blog WordPress theme for magazines, news websites, blogs and others.Theme Features: Advanced Custom Fields, Contact Form, Custom Front Page Settings, Custom Background Support, Custom Menu

Theme URL - https://www.ydesignservices.com/product/free-wordpress-themes/newsgem-free/
Author URL - https://www.ydesignservices.com/

Trac Browser - https://themes.trac.wordpress.org/browser/newsgem/0.4

SVN - https://themes.svn.wordpress.org/newsgem/0.4
ZIP - https://wordpress.org/themes/download/newsgem.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newsgem/0.3&new_path=newsgem/0.4

History:


https://themes.svn.wordpress.org/newsgem/0.4/screenshot.png

#8 @WPBrigade
4 weeks ago

Hi, @Ydesignservices

Nothing is fixed since my last comment
Please fix all the issues mentioned above in my first comment link

All things mentioned under Required, need to be fixed.

Screenshot of notices.

Looking forward.

#9 @themetracbot
4 weeks ago

  • Summary changed from THEME: Newsgem – 0.4 to THEME: Newsgem – 0.5

Newsgem - 0.5

Newsgem is a clean and modern magazine, news or blog WordPress theme for magazines, news websites, blogs and others.Theme Features: Advanced Custom Fields, Contact Form, Custom Front Page Settings, Custom Background Support, Custom Menu

Theme URL - https://www.ydesignservices.com/product/free-wordpress-themes/newsgem-free/
Author URL - https://www.ydesignservices.com/

Trac Browser - https://themes.trac.wordpress.org/browser/newsgem/0.5

SVN - https://themes.svn.wordpress.org/newsgem/0.5
ZIP - https://wordpress.org/themes/download/newsgem.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newsgem/0.4&new_path=newsgem/0.5

History:


https://themes.svn.wordpress.org/newsgem/0.5/screenshot.png

#10 @WPBrigade
4 weeks ago

Hi, @Ydesignservices

It is REQUIRED to fix all the issues mentioned below. You have 7 days to fix these issues.

Customizer:
Share social buttons are not allowed in theme.

This is default view of your given template http://take.ms/VVd4H

And this is when open in customizer without editing anything http://take.ms/sO34hg

The three sections provided in “Home feature news” should not have a default values in template unless they are added with customizer.


Widgets:

“Newsgem: Header ads (728x90)”

  • Can’t change image via upload.
  • Can’t change title.

Newsgem: Medium Rectangle Ads (300x300)

  • Can’t change image via upload.

Newsgen: Recent Posts

  • Why the category drop-down shows my pages?

Code:

You are not escape the all url in previous update please escape all url used in content-single.php Ref.

#11 @themetracbot
4 weeks ago

  • Summary changed from THEME: Newsgem – 0.5 to THEME: Newsgem – 0.6

Newsgem - 0.6

Newsgem is a clean and modern magazine, news or blog WordPress theme for magazines, news websites, blogs and others.Theme Features: Advanced Custom Fields, Contact Form, Custom Front Page Settings, Custom Background Support, Custom Menu

Theme URL - https://www.ydesignservices.com/product/free-wordpress-themes/newsgem-free/
Author URL - https://www.ydesignservices.com/

Trac Browser - https://themes.trac.wordpress.org/browser/newsgem/0.6

SVN - https://themes.svn.wordpress.org/newsgem/0.6
ZIP - https://wordpress.org/themes/download/newsgem.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newsgem/0.5&new_path=newsgem/0.6

History:


https://themes.svn.wordpress.org/newsgem/0.6/screenshot.png

#12 @WPBrigade
4 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi, @Ydesignservices

I am closing your ticket as there are too many issues with your theme.
Test your theme with all possibilites by yourself before uploading for the review
Please read the theme review hand book required section to make yourself familiar with the review process.

In your latest upload, theme is much more damaged as compared to last time.

  • Your custom widgets are not working at all except Newsgen: Recent Posts
  • Cant see contents of post in single posts view
  • Social links are not escaped in widget Newsgem: Footer about us
  • Admin Bar on the top disappears in single post page
  • Scheduled posts are supposed to be posted in future, they should not be visible in font by default.
  • In widgets Newsgen: Recent Posts and Home Featured News customizer section you are showing pages instead of showing user posts?!
  • You can not remove default section 'background image' in customizer in this case

#13 @Ydesignservices
3 weeks ago

Most of the Issues you mentioned are working fine on my side. I don't understand how you say they are not working.

I would like to have this theme reviewed from another reviewer. I am not satisfied with the review.

#14 @Ydesignservices
3 weeks ago

@poena Can you please help with this theme review?

#15 @poena
3 weeks ago

Hi
I have tested theme on two different servers with php versions 5.2 and 7.17 and the reviewer is right,
In single posts, the content is not showing and the page breaks causing the admin bar not to show because there is a php error:

Fatal error: Call to undefined function esc_url__() in newsgem/template-parts/content-single.php on line 7

When I try to test the widgets I get the following php notice:

Notice: Undefined variable: title in /app/public/wp-content/themes/newsgem/admin/widgets.php on line 173

When I do a search there are broken images on the search results page and I see the following:

<img src="&#10;Notice: Undefined variable: featured_img_search in
 themes/newsgem/template-parts/content-search.php on line 8&#10;" alt="Hello world!">

There is also text that is not translation ready in the widget files.

Missing license information for Fonts included in the theme folders.


-There already is a widget where the user can upload an image so it would be best to use those: standard image widgets are not lost when the user switches themes, but your custom widgets and the content will be lost.

Some of the "nonminified" versions of the scripts are not human readable, with lines between 500-3000 characters long.
Please understand that this makes it very difficult for users to make changes to it, and for us to review the code.
Compare owl.carousel.js with the wow.js file.

Note: See TracTickets for help on using tickets.