WordPress.org

Make WordPress Themes

Opened 4 weeks ago

Last modified 3 days ago

#48326 reviewing theme

THEME: SuperSport – 1.0.2

Reported by: sophy Owned by: thinkupthemes
Priority: new theme Keywords: theme-supersport child-theme parent-basepress
Cc: sophy.prak@…

Description

SuperSport - 1.0.0

This is a child theme for BasePress Theme

Theme URL - https://themecountry.com/themes/supersport/
Author URL - https://themecountry.com

Trac Browser - https://themes.trac.wordpress.org/browser/supersport/1.0.0

SVN - https://themes.svn.wordpress.org/supersport/1.0.0
ZIP - https://wordpress.org/themes/download/supersport.1.0.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/basepress

History:

Ticket Summary Status Resolution Owner
#48326 THEME: SuperSport – 1.0.2 reviewing thinkupthemes

(this ticket)


https://themes.svn.wordpress.org/supersport/1.0.0/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().

Change History (10)

#1 @rabmalin
4 weeks ago

  • Keywords changed from theme-supersport, child-theme, parent-basepress to theme-supersport child-theme parent-basepress
  • Owner set to williampatton
  • Status changed from new to reviewing

#2 @rabmalin
3 weeks ago

@williampatton Have you reviewed theme? Please post review comments.

#3 @rabmalin
2 weeks ago

  • Owner williampatton deleted

Returning ticket back to review queue for new reviewer.

#4 @thinkupthemes
2 weeks ago

  • Owner set to thinkupthemes

Hello @sophy I've taken over the review from @williampatton. I'll post my review findings within 24 hours.

Kind regards.

#5 @thinkupthemes
13 days ago

Hello @sophy

I've now completed the review of your theme and there are a number of issues however that need to be addressed before your theme fully meets the required standards. I've provided feedback for my findings below:

Code

  • All functions must be prefixed with the theme slug. (e.g. top_search_header). Please check your theme for all other similar issues.
  • All untrusted data must be escaped on output. (e.g. get_permalink( get_option( 'page_for_posts' ) ) on line 131 in function-template.php). Please check your theme for all other similar issues.
  • There are significant escaping related issues in the files magazine-posts-featured.php and magazine-posts-lists.php. So please check these files fully.

Licensing

  • The license for all images must be explicitly stated in the themes readme file. Please state the license for the images in the /images/featured-images/ folder.

Please upload an update within 7 days otherwise the ticket may be closed as not-approved. If you have any questions about any of the points below please do let me know.

Kind regards

Last edited 13 days ago by thinkupthemes (previous) (diff)

#6 @sophy
13 days ago

Hello @thinkupthemes,

Thank you so much for your fasting feedback I will update my theme asap.

Best,
Sophy

#7 @themetracbot
7 days ago

  • Summary changed from THEME: SuperSport – 1.0.0 to THEME: SuperSport – 1.0.1

SuperSport - 1.0.1

This is a child theme for BasePress Theme

Theme URL - https://themecountry.com/themes/supersport/
Author URL - https://themecountry.com

Trac Browser - https://themes.trac.wordpress.org/browser/supersport/1.0.1

SVN - https://themes.svn.wordpress.org/supersport/1.0.1
ZIP - https://wordpress.org/themes/download/supersport.1.0.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/basepress

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=supersport/1.0.0&new_path=supersport/1.0.1

History:

Ticket Summary Status Resolution Owner
#48326 THEME: SuperSport – 1.0.2 reviewing thinkupthemes

(this ticket)


https://themes.svn.wordpress.org/supersport/1.0.1/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().

#8 @thinkupthemes
5 days ago

Hello @sophy

Unfortunately your theme doesn't meet the required standards. Please review the following feedback fully:

  • There are significant escaping related issues in the files magazine-posts-featured.php and magazine-posts-lists.php. So please check these files fully

Essentially, anything PHP variable output within an attribute needs to be escaped. For example echo $this->get_field_id('title') on line 215 in magazine-posts-featured.php. There are many instances of similar issue.

Please upload an update within 7 days otherwise the ticket may be closed as not-approved. If you have any questions about any of the points below please do let me know

Kind regards.

#9 @themetracbot
3 days ago

  • Summary changed from THEME: SuperSport – 1.0.1 to THEME: SuperSport – 1.0.2

SuperSport - 1.0.2

This is a child theme for BasePress Theme

Theme URL - https://themecountry.com/themes/supersport/
Author URL - https://themecountry.com

Trac Browser - https://themes.trac.wordpress.org/browser/supersport/1.0.2

SVN - https://themes.svn.wordpress.org/supersport/1.0.2
ZIP - https://wordpress.org/themes/download/supersport.1.0.2.zip?nostats=1
Parent Theme: https://wordpress.org/themes/basepress

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=supersport/1.0.1&new_path=supersport/1.0.2

History:

Ticket Summary Status Resolution Owner
#48326 THEME: SuperSport – 1.0.2 reviewing thinkupthemes

(this ticket)


https://themes.svn.wordpress.org/supersport/1.0.2/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().

#10 @sophy
3 days ago

Hello @thinkupthemes,

Thank you for taking your valuable time to review our theme. Please feel free recheck again new version that I updated follow your feedback.

Best,
Sophy

Note: See TracTickets for help on using tickets.