WordPress.org

Make WordPress Themes

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#48451 closed theme (not-approved)

THEME: friby – 1.0.0

Reported by: ardsoft Owned by: rabmalin
Priority: new theme Keywords: theme-friby
Cc: info@…

Description

friby - 1.0.0

Friby is a free and elegant one page theme that can be used for web agency business,corporate business,personal and parallax business portfolio, photography sites and freelancer. It comes with a clean and beautiful design, which makes it run smoothly and easily. You can simply modify almost everything, as the theme comes with a complex and user-friendly set of customization options.

Theme URL - http://friby.webmountain.net/
Author URL - http://www.webmountain.net/

Trac Browser - https://themes.trac.wordpress.org/browser/friby/1.0.0

SVN - https://themes.svn.wordpress.org/friby/1.0.0
ZIP - https://wordpress.org/themes/download/friby.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#48451 THEME: friby – 1.0.0 closed not-approved rabmalin

(this ticket)


https://themes.svn.wordpress.org/friby/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Found the URL of a CDN in the code: <code>oss.maxcdn.com/libs/html5shiv</code>. You should not load CSS or Javascript resources from a CDN, please bundle them with the theme.
  • RECOMMENDED: Found the URL of a CDN in the code: <code>oss.maxcdn.com/libs/respond.js</code>. You should not load CSS or Javascript resources from a CDN, please bundle them with the theme.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'friby'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'friby'

Change History (6)

#1 @rabmalin
3 weeks ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#2 follow-up: @rabmalin
3 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello,

I am closing this ticket because theme has lots of issues. Please go through the Theme Review Guideline very carefully. Please fix your theme accordingly. Reviewer is allowed to close if there are more than 3+ distinct issues. If ticket is closed with such 3+ issues, then your new theme update would have to go through review queue again to get another round of review.

To become more familiar with Theme Review system, you can also start reviewing themes. Become a Reviewer

If you have any confusion or question regarding the guideline, you can ask here. I am happy to explain.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

#3 in reply to: ↑ 2 @ardsoft
3 weeks ago

Hi rabmalin.
Thank you for the review. I'll check my theme and fix all the issues.
I have a question. I downloaded some themes and checked for the documentation. But, none of them has any documentation within the zip file.
Where can I place documentation in the zip file or on a website linked through the README file?
Regards,

Replying to rabmalin:

Hello,

I am closing this ticket because theme has lots of issues. Please go through the Theme Review Guideline very carefully. Please fix your theme accordingly. Reviewer is allowed to close if there are more than 3+ distinct issues. If ticket is closed with such 3+ issues, then your new theme update would have to go through review queue again to get another round of review.

To become more familiar with Theme Review system, you can also start reviewing themes. Become a Reviewer

If you have any confusion or question regarding the guideline, you can ask here. I am happy to explain.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

#4 @rabmalin
3 weeks ago

For documentation, it is best to setup in your site and keep link in your theme. Generally we dont allow doc folder inside theme.

#5 @ardsoft
3 weeks ago

Hi Rabmalin,

After the review, I fixed all the REQUIRED, RECOMMENDED and INFO messages.

But, there is a WARNING saying "Found a translation function that is missing a text-domain. Function , with the arguments 'friby'"

friby is the text-domain of my theme.

I checked all the theme files line by line. There is no function like that. What I found is there are some functions at the WordPress files not theme files.

For example:
( 'Your account has been activated. You may now <a href="%1$s">log in</a> to the site using your chosen username of &#8220;%2$s&#8221;. Please check your email inbox at %3$s for your password and login instructions. If you do not receive an email, please check your junk or spam folder. If you still do not receive an email within an hour, you can <a href="%4$s">reset your password</a>.' ),

in the wp-activate.php file.

What can i do for that?

Thanks in advance for your advice.

Last edited 3 weeks ago by ardsoft (previous) (diff)

#6 @rabmalin
3 weeks ago

Can you please check again? I dont think the Theme Sniffer plugin will ever check wp-activate.php. That is file from WP core.

Last edited 3 weeks ago by rabmalin (previous) (diff)
Note: See TracTickets for help on using tickets.