WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4846 closed theme (not-approved)

THEME: utility - 1.1

Reported by: kapilchugh Owned by: jason-g
Priority: Keywords: theme-utility, synchold
Cc: kapil.chugh@…

Description

utility - 1.1

A Free WordPress theme designed by blitzthemes.com is stylish, customizable, simple, and readable.It offers customizable theme options, custom menu, slider, dynamic header for custom logo, custom background, widgetized sidebar and featured images (thumbnails for gallery posts and custom size images for posts).

Theme URL - http://blitzthemes.com/
Author URL -

SVN - http://themes.svn.wordpress.org/utility/1.1
ZIP - http://wordpress.org/extend/themes/download/utility.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/utility/1.0&new_path=/utility/1.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-utility&order=priority

https://themes.svn.wordpress.org/utility/1.1/screenshot.png

Change History (7)

comment:1 garinungkadol3 years ago

  • Owner set to jason-g
  • Status changed from new to assigned

comment:2 jason-g3 years ago

Theme Review

Thank you very much for your theme submission. Below is my complete review and findings.

Policy Requirements - Results: PASSED

Theme Check - Results: PASSED

Code Quality - Results: FAILED

header.php

No scripts or script file links should be hard-coded into the document head. (These must be enqueued and hooked in appropriately.)

style.css

Just as a recommendation you may want to include your Author URI in the header of style.css.

Theme Unit Tests - Results: PASSED

Theme Activation Tests - Results: PASSED

General Validation Tests - Results: FAILED

You have an extra </div> tag which causes a validation errror on every page.

This is a complete review and the recommendation is: NOT APPROVED
Please fix all issues stated in this review before resubmitting.

Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:
Theme Check Plugin: http://wordpress.org/extend/plugins/theme-check/
Theme Unit Test: http://codex.wordpress.org/Theme_Unit_Test
Log Deprecated Notices: http://wordpress.org/extend/plugins/log-deprecated-notices/
Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page.
Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
1) Leave a comment on this ticket
2) Email the theme-reviewers email list
3) Use the #wordpress-themes channel on irc.freenode.net

comment:3 kapilchugh3 years ago

Thank you so much for your feedback.

I was checking header.php of twentyeleven theme and they have also included one js file in header.php

One more thing:-
When i check my theme using w3c validator i didn't get any extra </div> tag.You can also check the result.

http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Futilitydemo.blitzthemes.com%2F

comment:4 garinungkadol3 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

@jason-g, On the blog index view I don't get any validation errors. XHTML 1.0 Transitional validation returns as successfully completed. What post/page view did you validate on?

@kapilchugh, I agree with Jason. Since you do have an enqueued script function, you should move the comment reply script from header.php to utility_custom_theme_scripts()

Here are some other code quality issues that I saw:
Prefix

  • REQUIRED: All functions, global variables and constants that are created by the theme MUST be prefixed using the theme slug or an appropriate variant.
  • REQUIRED: Constants are not prefixed. For example THEME_SHORT_NAME would be MYTHEMEPREFIX_THEME_SHORT_NAME.
  • REQUIRED: Global variables are not prefixed: For example: $custom_theme_option or $themename or $global_options_array
  • REQUIRED: Not all custom functions are prefixed. See adminpanel\adminpanel.php.
  • REQUIRED: Name references for enqueued scripts must be prefixed to prevent conflicts. For example:wp_enqueue_script( 'jquery.ticker.min' would be wp_enqueue_script( 'mythemeprefix_jquery.ticker.min' and so on. mythemeprefix would be replaced with whatever prefix you are using.

Enqueuing Styles

  • REQUIRED: Only the style.css can be hard-coded in header.php. All other stylesheets should be placed in a function and hooked into wp_print_styles. See wp_enqueue_style

Others

  • the_excerpt already removes HTML tags and shortcodes for display so the function: utility_strip_all_tags is redundant. See the_excerpt(). Is there a particular reason why you are doing this?
  • REQUIRED: You should not be packaging the jQuery script with your theme package especially since you are using a lower version. WordPress is currently using jQuery 1.6.1. You can use the Google API to link to another version of jQuery as long as it is higher than what WordPress is using.

Closing ticket as per reviewer's recommendation: NOT-APPROVED

comment:5 kapilchugh3 years ago

the excerpt removes HTML tags but it doesn't remove shortcodes, so there is no need to put extra strip_tags function inside utility_strip_all_tags.

Last edited 3 years ago by kapilchugh (previous) (diff)

comment:6 jason-g3 years ago

General Validation Tests - Results: PASSED

Sorry, I belief the validation errors I saw were created by a browser extension I had installed.

comment:7 kapilchugh3 years ago

Please find the new version of the theme with suggested changes.
http://themes.trac.wordpress.org/ticket/5073

Note: See TracTickets for help on using tickets.