WordPress.org

Make WordPress Themes

Change History (6)

#1 @garinungkadol
6 years ago

  • Owner set to saymar90
  • Status changed from new to assigned

#2 @saymar90
6 years ago

Suggest

Not approved

Theme check

  • REQUIRED: get_users_of_blog found in the file functions.php. Deprecated since version 3.1. Use get_users() instead.
    Line 44: elseif(function_exists('get_users_of_blog')):
    Line 45: $users = get_users_of_blog();
    
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' ) in the functions.php file.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Layout

  • sub and sup html tags don't display properly.
  • Make a style for table
  • Posts categories don't display.

Code Quality

  • There are functions without prefixe.

Theme features

  • When posts are not starred, and we click on "My starred" All posts display
  • When there are a sticky post not starred or not rated, it's automatically display with "My starred", popular or unpopular posts or most voted-on.
Last edited 6 years ago by saymar90 (previous) (diff)

#3 @garinungkadol
6 years ago

@enej: Minor revisions are needed so we'll keep this ticket open for two days. Let me know if you need more time.

#4 @enej
6 years ago

Hi @garinungkadol

That should be enough time, thanks for all your hard work!

Cheers Enej

#5 @enej
6 years ago

Hi @garinungkadol

The update took longer then I though. Sorry. I uploaded the new version of pulsepress 1.3.3, I am not sure if that was the right thing to do, here is the link to the ticket. http://themes.trac.wordpress.org/ticket/5000. Thanks for all the feedback. I documented the changes I did in the changelog.txt.

#6 @garinungkadol
6 years ago

  • Keywords synchold added
  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.