WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#4849 closed theme (closed-newer-version-uploaded)

THEME: Sonar - 1.2.2

Reported by: bradthomas127 Owned by: garinungkadol
Priority: Keywords: theme-sonar, synchold
Cc: bradthomas127@…

Description

Sonar - 1.2.2

The Sonar theme is a stylish, neat, and fully customizable WordPress theme. Make it yours with the easy customizable theme options with a simple check-box interface to easily change colors, fonts, header, background, menus, sidebars, and much more. Uses Superfish menu effects and it has built-in pagination for post pages and comments. Sonar has page templates of HTML Sitemap, one-column page template that removes the sidebar, and one-column full width iframe. Special styles for posts in the Asides, Status, and Gallery categories and Sonar has a active support forum.

Theme URL - http://wp-ultra.com/themes/sonar/
Author URL - http://wp-ultra.com/

SVN - http://themes.svn.wordpress.org/sonar/1.2.2
ZIP - http://wordpress.org/extend/themes/download/sonar.1.2.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/sonar/1.2.1&new_path=/sonar/1.2.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-sonar&order=priority

https://themes.svn.wordpress.org/sonar/1.2.2/screenshot.png

Change History (7)

comment:1 garinungkadol3 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

comment:2 garinungkadol3 years ago

REVIEW SUMMARY

  • Theme is already approved
  • Diff. check shows changing divs to HTML5 tags and adding of javascript functionality.
  • Additional issues identified are:
  • REQUIRED: Check your footer credit in footer.php
    <a href="<?php echo esc_url( __( 'http://wp-ultra.com/', 'sonar' ) ); ?>" title="<?php esc_attr_e( 'Wordpress Sonar Theme ', 'sonar' ); ?>" rel="generator"><?php printf( __( 'Sonar Theme', 'energy' )); ?></a>
    

The title text is a form of SEO-seeding. You are also using the text domain 'energy'. The correct form is:

<a href="<?php echo esc_url( __( 'http://wp-ultra.com/', 'sonar' ) ); ?>" title="<?php esc_attr_e( 'Sonar Theme ', 'sonar' ); ?>" rel="generator"><?php printf( __( 'Sonar Theme', 'sonar' )); ?></a>
  • REQUIRED: All global variables: $options, $themename, $shortname, $version, $option_group, $option_name must be prefixed with the theme slug or an appropriate variant. I'm not sure what is the difference between $options and $sonar_options


  • REQUIRED: Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected" for checkboxes and select options


RECOMMENDATION: APPROVED when required changes are fixed.
I can keep this ticket open for two days. If you need more time, please let me know.

Last edited 3 years ago by garinungkadol (previous) (diff)

comment:3 bradthomas1273 years ago

@garinungkadol - Thanks for the review, I'll get to work on these issues tomorrow morning.
Thanks for leaving the ticket open.

comment:4 follow-up: bradthomas1273 years ago

@garinungkadol - My $themename, $shortname, $option_group, $option_name are prefixed with a theme slug and their is a difference between $options and $sonar_options ($options = get_option( $option_name ); ), i can rename if needed. I have fixed the other issues and just need to know about this last issue.

comment:5 in reply to: ↑ 4 garinungkadol3 years ago

Replying to bradthomas127:

@garinungkadol - My $themename, $shortname, $option_group, $option_name are prefixed with a theme slug and their is a difference between $options and $sonar_options ($options = get_option( $option_name ); ), i can rename if needed. I have fixed the other issues and just need to know about this last issue.


I'm referring to this file: http://themes.svn.wordpress.org/sonar/1.2.2/admin/sonar-options.php

For example, you have defined $themename and $shortname which are then called as global variables in the different functions. These should be $sonar_themename, $sonar_shortname and so on.

The reason why I asked about $options and $sonar_options is if you were to prefix $options as $sonar_options there will be a conflict with the existing $sonar_options. So renaming one of theme is highly recommended.

comment:6 bradthomas1273 years ago

@garinungkadol - Think i got it all now.
http://themes.trac.wordpress.org/ticket/4926

comment:7 garinungkadol3 years ago

  • Keywords synchold added
  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.