WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#4860 closed theme (not-approved)

THEME: PressPlay - 2.2

Reported by: SeventhSteel Owned by: garinungkadol
Priority: Keywords: theme-pressplay, synchold
Cc: michaelmdance@…

Description

PressPlay - 2.2

A clean and elegant theme with rich colors for personal or professional websites. Features four different layouts; six widget areas; a simple tabbed jQuery sidebar; mutiple custom page templates; built-in support for custom post types and taxonomies; two custom nav menu locations; and support for custom headers, backgrounds, and featured images. Valid, browser-safe XHTML 1.0 Strict.

Theme URL - http://mikedance.com/projects/pressplay
Author URL - http://mikedance.com

SVN - http://themes.svn.wordpress.org/pressplay/2.2
ZIP - http://wordpress.org/extend/themes/download/pressplay.2.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/pressplay/2.1&new_path=/pressplay/2.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-pressplay&order=priority

https://themes.svn.wordpress.org/pressplay/2.2/screenshot.png

Attachments (7)

center-aligned-captioned-image.jpg (45.1 KB) - added by garinungkadol 6 years ago.
floated-elements.jpg (31.5 KB) - added by garinungkadol 6 years ago.
left-sidebar.jpg (50.7 KB) - added by garinungkadol 6 years ago.
lists-comments.jpg (30.7 KB) - added by garinungkadol 6 years ago.
many-categories.jpg (35.4 KB) - added by garinungkadol 6 years ago.
not-logged-in-comment-form.jpg (35.7 KB) - added by garinungkadol 6 years ago.
wide-image.jpg (77.5 KB) - added by garinungkadol 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @garinungkadol
6 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

#2 @garinungkadol
6 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS
This is a complete review. Below are the theme review results. Anything marked FAIL needs to be addressed. Anything marked REQUIRED is needed to be fixed while anything marked RECOMMENDED is strongly advised. Other points may be raised purely for information.

RECOMMENDATION: NOT-APPROVED


Theme Information: FAIL

  • Credit Link: Your footer link must be either the Theme URI or Author URI. http://pressplaying.com is not valid.

Theme Check Results: PASS

  • INFO: Non-printable characters were found in the searchform.php file. You may want to check this file for errors.
    Line 1: ?<form method='get' class='searchform' action='<?php bloginfo('url'); ?>/
    
  • RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • RECOMMENDED: bloginfo(url) was found in the file searchform.php. Use echo home_url() instead.
  • RECOMMENDED: bloginfo(url) was found in the file 404.php. Use echo home_url() instead.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Debugger results: PASS


Test data results: FAIL
Blog Post Index View

  • REQUIRED: Posts with no title should still display the permalink to the single post view. The recommended practice is to place the permalink on the post date.
  • REQUIRED: A post with many categories will break the post header bar. Please check this. See many-categories.jpg
  • There is no right padding for re-sized images. See wide-image.jpg. Is this intentional?

Single Post View

  • REQUIRED: Please check the styling of ordered and unordered lists when they are used in comments. See lists-comments.jpg
  • REQUIRED: The comment text area for visitors who are not logged in slightly overlaps the content area when the "Respond" link is clicked. See not-logged-in-comment-form.jpg

Visual issues / functionality / browser checks: FAIL

  • FAIL: There is a problem with your implementation of Navigation Menus. The menus that I set in Appearance >> Menu are not being displayed.
  • REQUIRED: When I select the theme option "Layout >> Left Sidebar", the sidebar appears after the content on the right side. This is with 1024 x 768 resolution in Google Chrome. The display is fine in Firefox. See left-sidebar.jpg

Validation: PASS
CSS: PASS

HTML: PASS


Code Quality: FAIL

  • REQUIRED: wp_footer() must be placed directly before </body>.
  • REQUIRED: wp_head() must be placed directly before </head>.
  • REQUIRED: The search form must be displayed using get_search_form(). You can customize the search form using the template 'searchform.php'. Refer to 404.php
  • REQUIRED: There is no need for a compatiblity check for the function post_class(). Your theme should be supporting the latest version of WordPress. Refer to archive.php, author.php, category.php, date.php, image.php, index.php, links.php, no-sidebar.php, page.php, search.php, single.php, tag.php, widget-page.php
    <?php if (function_exists("post_class")) { // for pre-WordPress 2.7 ?>
    <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    <?php } else { ?>
    <div id="post-<?php the_ID(); ?>">
    <?php } ?>
    

should be:

<div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
  • REQUIRED: Please remove Lines 4 and 5 in comments.php. Direct page access of the comments template is not needed anymore.
  • REQUIRED: Check translatable text. Comments.php (Line 42), functions.php (Line 21, 22)
  • REQUIRED: If you have a number of scripts you should place them in a function that hooks into wp_enqueue_scripts. Also, you don't need to enqueue jQuery - you just call it as a dependency for your script. For example in header.php
    Line 8 <?php if ( is_singular() && get_option( 'thread_comments' ) ) wp_enqueue_script( 'comment-reply' );
    Line 9 	wp_enqueue_script('jquery');
    Line 10 wp_enqueue_script('jquery-ui-core');
    Line 11	wp_enqueue_script('jquery-ui-tabs');
    Line 12 	wp_enqueue_script('jquery-tabbox-pressplay', get_template_directory_uri() . '/library/tabs.js', array('jquery-ui-core','jquery-ui-tabs')); ?>
    

when placed in functions.php will become:

function pp_scripts(){
  if ( is_singular() && get_option( 'thread_comments' ) ) wp_enqueue_script( 'comment-reply' );
  wp_enqueue_script('jquery-tabbox-pressplay', get_template_directory_uri() . '/library/tabs.js', array('jquery', 'jquery-ui-core','jquery-ui-tabs'));
}
add_action( 'wp_enqueue_scripts', 'pp_scripts' );
  • REQUIRED: You should not be hard-coding additional styles in header.php. I suggest you create additional stylesheet files and then enqueue them within a function that hooks into wp_print_styles.
    function pp_styles(){
    	$options = get_option( 'pp_theme_options' );
    	if($options['layout'] == "left-sidebar") {
    		wp_enqueue_style( 'pp-left-sidebar', get_template_directory_uri() . /styles/left-sidebar.css' ) ;
    	}
      
        if($options['width'] == "stretched"){
    	   wp_enqueue_style( 'pp-stretched', get_template_directory_uri() . /styles/stretched.css' ) ;
    	}
    	
    	... and so on ...
    }
    add_action( 'wp_print_styles', 'pp_styles' );
    
  • REQUIRED: Provide an id for your sidebars
    	register_sidebar( array(
    		'id' => 'upper-sidebar',
    		'name' => 'Upper Sidebar',
    		'description' => 'Widgets in this section will appear ABOVE the default sidebar elements.',
    
  • REQUIRED: Make use of checked() and selected() in theme settings form where appropriate.

Other notes


Information
If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.
Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:

Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page http://codex.wordpress.org/Theme_Review.

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

  • 1) Leave a comment on this ticket
  • 2) Email the theme-reviewers email list
  • 3) Use the #wordpress-themes channel on irc.freenode.net
Note: See TracTickets for help on using tickets.