WordPress.org

Make WordPress Themes

Opened 3 weeks ago

Closed 4 days ago

Last modified 4 days ago

#48665 closed theme (live)

THEME: WP iClean Responsive – 1.1.6

Reported by: wponlinesupport Owned by: maneshtimilsina
Priority: new theme Keywords: theme-wp-iclean-responsive
Cc: support@…

Description

WP iClean Responsive - 1.1.3

The Wp Iclean Responsive theme for WordPress is a fully responsive theme that looks great on any device. Features include a front page template with its own widgets, an optional display font, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL -
Author URL - https://www.wponlinesupport.com

Trac Browser - https://themes.trac.wordpress.org/browser/wp-iclean-responsive/1.1.3

SVN - https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.3
ZIP - https://wordpress.org/themes/download/wp-iclean-responsive.1.1.3.zip?nostats=1

History:


https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.3/screenshot.png

Change History (16)

#1 @wponlinesupport
3 weeks ago

Hi,

As per request by @maneshtimilsina,

"Prefixing - Your theme slug is wpos-clean-responsive. You should use it as prefixing. Only company name in prefix is not allowed. Please fix in all files."

We have updated prefix name in all files and as well as we have updated our folder name and theme text domain according to theme folder.

But we have noticed that while submitting theme again a new ticket has been generated and I think due to new name. Here is the old ticket link
https://themes.trac.wordpress.org/ticket/46559#comment:10

Can you please guide us?

Thanks in advance.

#2 @rabmalin
3 weeks ago

  • Owner set to maneshtimilsina
  • Status changed from new to reviewing

#3 @rabmalin
2 weeks ago

@maneshtimilsina Are are able to continue review? If not we can reassign.

#4 @maneshtimilsina
2 weeks ago

Hi @rabmalin

I was out of work so could not review it. I will continue my review.

@wponlinesupport thanks for your patience. I will post my feedback soon.

#5 @maneshtimilsina
2 weeks ago

Hi @wponlinesupport

Please fix following issues of your theme and upload new version.

Issues

  • Remove default link to your page from facebook and twitter of social icons in customizer.
  • Remove inline style from line 116 of header.php
  • wp_footer() should be called just before </body>. Please check it on footer.php
  • Images from Unsplash are not allowed to use because of their license. Please remove them and update screenshot as well.
  • Inside HTML attributes like placeholder, you should use esc_attr__() instead of esc_html__(), please check line 21 of search-top-nav.php
  • Styles and scripts added by theme need to be handled with theme slug. Please check class-wpcrt-script.php, Ex: customizer at line 36, google-fonts at line 53 and others
  • Translation missing at lable and title of class-wpcrt-theme-customizer.php. Please check it at wpcrt-functions.php as well.
  • Where is wpcrt_google_font_data() used? If it is not used please remove unused functions of theme.
  • $front_page_id should be escaped at line 74 of front-page.php

#6 @themetracbot
11 days ago

  • Summary changed from THEME: WP iClean Responsive – 1.1.3 to THEME: WP iClean Responsive – 1.1.4

WP iClean Responsive - 1.1.4

The WP iClean Responsive theme for WordPress is a fully responsive theme that looks great on any device. Features include a front page template with its own widgets, an optional display font, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL -
Author URL - https://www.wponlinesupport.com

Trac Browser - https://themes.trac.wordpress.org/browser/wp-iclean-responsive/1.1.4

SVN - https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.4
ZIP - https://wordpress.org/themes/download/wp-iclean-responsive.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wp-iclean-responsive/1.1.3&new_path=wp-iclean-responsive/1.1.4

History:


https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.4/screenshot.png

#7 @wponlinesupport
11 days ago

Hi @maneshtimilsina,

Thanks for your response.

We have done all the changes as you had suggested.

We have also updated our Prefix to wp_iclean_responsive to functions and other end.

As per your suggestion
1) Images from Unsplash are not allowed to use because of their license. Please remove them and update screenshot as well.

Ans - Sorry, Actually it is left by mistake. We are not using any image from Unsplash. We have updated our readme.txt file also.

Thanks.

Last edited 11 days ago by wponlinesupport (previous) (diff)

#8 @maneshtimilsina
10 days ago

Hi @wponlinesupport

Please fix following issues of your theme and upload new version.

  • Remove default value # for social icons. It should not be displayed until user enter their social links.
  • Update TGM library to latest version.
  • Escaping missing - class-wpcrt-theme-customizer.php line 1297, 1301
  • wp_iclean_responsive_paginate_links() - Use the_posts_pagination() for numeric pagination in archive instead of paginate_links().
  • do_shortcode() is not escaping function. Please use appropriate escaping before applying do_shortcode().
  • Inside HTML attributes like alt, placeholder, title, etc, use esc_attr_e() instead of esc_html_e()
  • I guess, copyright here is not correct. WP iClean Responsive WordPress Theme, Copyright 2016-2017 WordPress.org & Automattic.com. Copyright owner should be you.

#9 @themetracbot
9 days ago

  • Summary changed from THEME: WP iClean Responsive – 1.1.4 to THEME: WP iClean Responsive – 1.1.5

WP iClean Responsive - 1.1.5

The WP iClean Responsive theme for WordPress is a fully responsive theme that looks great on any device. Features include a front page template with its own widgets, an optional display font, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL -
Author URL - https://www.wponlinesupport.com

Trac Browser - https://themes.trac.wordpress.org/browser/wp-iclean-responsive/1.1.5

SVN - https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.5
ZIP - https://wordpress.org/themes/download/wp-iclean-responsive.1.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wp-iclean-responsive/1.1.4&new_path=wp-iclean-responsive/1.1.5

History:


https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.5/screenshot.png

#10 @wponlinesupport
9 days ago

Hi,

I have done all the changes as you had suggested but we have one query regarding to

Ques 1) do_shortcode() is not escaping function. Please use appropriate escaping before applying do_shortcode().

Ans - We have used proper sanitize function for different types of field. So now this value is stored with proper sanitize so can we pass directly to do_shortocde() ?

Because whole shortcode is stored in DB so we are not sure which types of escaping function need to be used but we think after sanitize it will be ok.

Please let me know your suggestion if any.

Thanks.

#11 @maneshtimilsina
5 days ago

Hi @wponlinesupport

You can escape shortcode like this echo do_shortcode( wp_kses_post( $option_value ) );

Beside this please update stable tag to the latest version of theme in readme file and keep changelog of all versions.

Thanks

#12 @anoopranawat
5 days ago

Hello @maneshtimilsina,

Thanks for your feedback and let me upload the theme again today :)

#13 @themetracbot
5 days ago

  • Summary changed from THEME: WP iClean Responsive – 1.1.5 to THEME: WP iClean Responsive – 1.1.6

WP iClean Responsive - 1.1.6

The WP iClean Responsive theme for WordPress is a fully responsive theme that looks great on any device. Features include a front page template with its own widgets, an optional display font, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL -
Author URL - https://www.wponlinesupport.com

Trac Browser - https://themes.trac.wordpress.org/browser/wp-iclean-responsive/1.1.6

SVN - https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.6
ZIP - https://wordpress.org/themes/download/wp-iclean-responsive.1.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wp-iclean-responsive/1.1.5&new_path=wp-iclean-responsive/1.1.6

History:


https://themes.svn.wordpress.org/wp-iclean-responsive/1.1.6/screenshot.png

#14 @wponlinesupport
5 days ago

Hello @maneshtimilsina,

We have updated the changes and added new v1.1.6

#15 @maneshtimilsina
4 days ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @wponlinesupport

No more issues found on your theme.

I am setting it live. It will take around 1 hour for a theme to appear in the directory.

Good luck!

#16 @wponlinesupport
4 days ago

Hello @maneshtimilsina ,

Thanks for your review. I just want to know that as our theme has been live now so how we will manage this? Like we also have plugins where we manage plugin with SVN so is their any way to manage the theme also?

Thanks again for your time.

Note: See TracTickets for help on using tickets.