WordPress.org

Make WordPress Themes

Attachments (5)

Ordered-List.png (3.4 KB) - added by saymar90 3 years ago.
Page with comments disabled.png (8.1 KB) - added by saymar90 3 years ago.
trackback.png (4.5 KB) - added by saymar90 3 years ago.
Post-Format-Test_-Image-(Linked).jpg (167.4 KB) - added by saymar90 3 years ago.
Wide-Image.jpg (58.2 KB) - added by saymar90 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 garinungkadol3 years ago

  • Owner set to saymar90
  • Status changed from new to assigned

saymar903 years ago

saymar903 years ago

saymar903 years ago

comment:2 saymar903 years ago

Suggest

Not approved

Theme Check Recommended

  • No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Last Review

  • Content-type meta declaration have to be before <title> tag Fixed
  • Missing XFN profile link in <head> tag Fixed
    <head profile="http://gmpg.org/xfn/11">
    

or

<link rel="profile" href="http://gmpg.org/xfn/11" />
  • Presence of `include( TEMPLATEPATH . '/file.php' ), Use get_template_part() instead. Fixed
  • Wide image (900x598px) overlaps sidebar area. Fixed
  • Embeded video overlaps sidebar too Fixed
  • in functions.php $content_width = 920; is too big value, it should be equal to the width of the content area the theme is designed for Fixed
  • Floated elements (images) are not cleared at the bottom Fixed

Code Quality

  • You don't need to use if ( function_exists( 'add_theme_support' ) ){
  • You don't need to use line 8 and 9 in comments.php
  • It's required to prefix all options, custom functions, custom variables, and custom constants with theme-slug or appropriate variant.
  • It's required to use the add_theme_page() function to add the Theme Settings Page to the Appearance menu, rather than using add_menu_page() to add a top-level menu.
  • It's required to use the edit_theme_options capability for add_theme_page(), rather than rely on a role (e.g. "administrator"), or a different capability (e.g. "edit_themes", "manage_options") for the capability to add the settings page.
  • Post must display links to previous and next posts.
  • Dropdown menu don't work correctly.
  • It's recommended to include in a readme.txt documentation not made in comments within the template and stylesheet files. Other forms of documentation may be included in addition to the readme file at the Theme author's discretion such as "Contextual Help" within the Theme's "option" page(s), the restrictions of the theme (for example, number of elements for the menu...).

Layout

  • Wide image (900x598px) is resized incorrectly. You shouldn't use css to resize it.Wide-Image.jpg

Theme Options

  • Theme Options don't work correctly. When we uncheck a box to deactivate an option, and save changes. The box is always checked and the option always enabled.
Last edited 3 years ago by saymar90 (previous) (diff)

comment:3 garinungkadol3 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

@effited, You should also change the images (from Up) that you are using in the screenshot as I don't think their license are GPL-compatible.

Closing ticket as per reviewer's recommendation: NOT-APPROVED

Note: See TracTickets for help on using tickets.