WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#5326 closed theme (not-approved)

THEME: F2 - 1.2.1

Reported by: SriniG Owned by: nofearinc
Priority: Keywords: theme-f2
Cc: srinig112@…

Description

F2 - 1.2.1

F2 is a fast loading flexible width theme for WordPress. Customizable header, any of the two sidebars can be optionally turned off, and much more options in the settings page. Compatible with WordPress 2.8 and above. Valid XHTML, CSS.

Theme URL - http://srinig.com/wordpress/themes/f2/
Author URL - http://srinig.com/wordpress

SVN - http://themes.svn.wordpress.org/f2/1.2.1
ZIP - http://wordpress.org/extend/themes/download/f2.1.2.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/f2/1.2&new_path=/f2/1.2.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-f2&order=priority

https://themes.svn.wordpress.org/f2/1.2.1/screenshot.png

Attachments (2)

f2-menu-overlap.png (3.1 KB) - added by nofearinc 6 years ago.
f2-two-rows-title.png (3.9 KB) - added by nofearinc 6 years ago.

Download all attachments as: .zip

Change History (5)

#1 @nofearinc
6 years ago

  • Owner set to nofearinc
  • Status changed from new to assigned

#2 @nofearinc
6 years ago

Theme review: "Not-Approved"

Several visual and technical issues were encountered during the review. See below and correct where applicable.

Visual Review

  • => theme doesn't provide styling for several HTML tags such as: dl, dt, var, i, em, b, strong
  • => Post titles on index or single post view taking 2 rows have problems with the line height:


  • => Clearing Floats

Floating of image is not done properly (pagination is next to the picture)

  • / Menu has insufficient top margin and overlaps some of the letters in the site description:


  • / Theme supports large menus on 2 rows. However second row items right above the sidebar are hardly clickable (second row overlaps the sidebar and due to z-index issues menu item could be clicked only on item's top corner)

Code Review

comments.php

  • => Lines 3 to 5 for the SERVER variable check are not required anymore and the direct usage of $_SERVER is not recommended (please remove the three lines)
  • => Use the comment_form() WordPress function instead of the custom form with manual parsing

header.php

  • => print.css is imported incorrectly - please use wp_enqueue_style for CSS embedding

functions.php

  • => Add IDs to your sidebars to avoid conflicts with other themes and updates
  • => Using direct access to options is considered insecure. Please refer to Settings API for better integration of your admin options.
  • => Add a prefix to your $options and $style variables (and all other theme related variables) as per the guidelines recommendation
  • => use wp_enqueue_style for rounded corners and custom css file

Information
If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated. This ticket will be open for the next 48h.

Note:

Re-submitted Themes are given review priority over new Themes.
You can use the following tools to recreate the issues raised above if any have been:
Theme Check Plugin: http://wordpress.org/extend/plugins/theme-check/
Theme Unit Test: http://codex.wordpress.org/Theme_Unit_Test
Log Deprecated Notices: http://wordpress.org/extend/plugins/log-deprecated-notices/
Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page.

Items marked with => are reasons for not being approved
Items marked with / are recommendations
Items marked with # are notes

Last edited 6 years ago by nofearinc (previous) (diff)

#3 @nofearinc
6 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.