WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5725 closed theme (not-approved)

THEME: Swift Basic - 0.0.1

Reported by: gandham Owned by: garinungkadol
Priority: Keywords: theme-swift-basic, synchold
Cc: satish_g2009@…

Description

Swift Basic - 0.0.1

Swift Basic is the free version of Swift, the fastest loading, developer friendly and most advanced SEO WordPress theme with loads of intutive customization options, giving you infinite number of layouts. It supports all the awesome WordPress features like menus, post types, post formats, you name it and it will be there in Swift.

Theme URL - http://swiftthemes.com/swift-basic/
Author URL - http://SatishGandham.Com

SVN - http://themes.svn.wordpress.org/swift-basic/0.0.1
ZIP - http://wordpress.org/extend/themes/download/swift-basic.0.0.1.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-swift-basic

https://themes.svn.wordpress.org/swift-basic/0.0.1/screenshot.png

Attachments (5)

3-column-fluid.jpg (104.7 KB) - added by garinungkadol 2 years ago.
footer-menu.jpg (22.9 KB) - added by garinungkadol 2 years ago.
long-title.jpg (61.6 KB) - added by garinungkadol 2 years ago.
post-admin-background.jpg (180.6 KB) - added by garinungkadol 2 years ago.
wide-images.jpg (127.2 KB) - added by garinungkadol 2 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 garinungkadol2 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

comment:2 gandham2 years ago

feedback please...

garinungkadol2 years ago

garinungkadol2 years ago

garinungkadol2 years ago

garinungkadol2 years ago

comment:3 garinungkadol2 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

RECOMMENDATION: NOT-APPROVED

THEME INFORMATION

DEBUGGER ERRORS

Upon activating the theme
-- Notice: Undefined index: default in C:\xampp\htdocs\wpthemes\wp-content\themes\swift-basic\lib\admin\admin-setup.php on line 348
-- Warning: Cannot modify header information - headers already sent by (output started at C:\xampp\htdocs\wpthemes\wp-content\themes\swift-basic\lib\admin\admin-setup.php:339) in C:\xampp\htdocs\wpthemes\wp-content\themes\swift-basic\lib\admin\admin-setup.php on line 364

When uploading an image for the sidebar background
-- Debug: Undefined index: sidebar_bg on line 332 of C:\xampp\htdocs\wpthemes\wp-content\themes\swift-basic\lib\admin\create-styles.php

When uploading an image for the footer background
-- Debug: Undefined index: footer_bg on line 335 of C:\xampp\htdocs\wpthemes\wp-content\themes\swift-basic\lib\admin\create-styles.php

THEME TEST RESULTS

Single Post View

VISUAL ISSUES / FUNCTIONALITY

  • REQUIRED: Favicons should not be enabled by default. If the user has not opted to have a favicon no image should be displayed.
  • REQUIRED: Check the implementation of editor styles. The theme body background changes the admin background when in the Edit Posts screen. See post-admin-background.jpg
  • REQUIRED: The 3-column magazine layout doesn't work if "Fluid" layout is selected. See 3-column-fluid.jpg
  • REQUIRED: Check the styling of the footer menu - sub-level menu items are being displayed instead of being visible when you hover over the parent link. See footer-menu.jpg
  • REQUIRED: Body background must be implemented using add_custom_background().
  • REQUIRED: Background set under "Sidebar background" is not appearing. See Debugger Errors above.
  • REQUIRED: Background set under "Footer background" is not appearing See Debugger Errors above.

CODE QUALITY

Settings
Please see http://codex.wordpress.org/Theme_Review#Theme_Settings_and_Data_Security

  • REQUIRED: All global variables must be prefixed with the theme slug or an appropriate variant. See $count, $image_repeat, $font_stack, $font_unit, $font_style, $font_weight, $text_transform
  • REQUIRED: Themes are required to use the edit_theme_options capability for add_theme_page().
  • REQUIRED: Themes are required to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you.
  • REQUIRED: For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.

Translation

  • REQUIRED: Themes are required to use theme-slug as textdomain for translation. Text domain must be swift-basic not swift
  • REQUIRED: Missing textdomain in in modified-core-functions.php.
    Line 154: printf( __('%1$s at %2$s'), get_comment_date(),  get_comment_time()) ?></a><?php ed
    Line 161: <em class='comment-awaiting-moderation'><?php _e('Your comment is awaiting moderation.') ?></em>
    

comment:4 follow-up: gandham2 years ago

Thanks for the detailed review.
I'm in a journey with limited connectivity, will fix these in few hours.

How long before this ticket its closed permanently?

Sent from galaxy s2

comment:5 in reply to: ↑ 4 garinungkadol2 years ago

Replying to gandham:

Thanks for the detailed review.
I'm in a journey with limited connectivity, will fix these in few hours.

How long before this ticket its closed permanently?


If you are able to make the revisions within 2 days, comment here with the link to the new trac ticket and I will continue the review there.

comment:6 follow-up: gandham2 years ago

REQUIRED: Body background must be implemented using add_custom_background().

My theme has option to set backgrounds for multiple elements of the page, having them on a single page will make it easy for the users.
Can you make an exception?

REQUIRED: Themes are required to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you.

I'm only using two options arrays, one for site options and the other for design options.

There is not enough documentation on set_theme_mod, can you explain what exactly is its purpose?

REQUIRED: Themes are required to use theme-slug as textdomain for translation. Text domain must be swift-basic not swift

Swift basic is limited version of our premium theme Swift, having the same slug will make the maintenance of the translation files easy.

comment:7 gandham2 years ago

Hello,
I fixed the problems and uploaded the new version.
New version: http://themes.trac.wordpress.org/ticket/6076

I provided explanation for some errors you pointed, let me know if there is a better way to fix the problem.

Regards
Satish Gandham

REQUIRED: Credit link in footer is invalid. You must use either the Theme URI or Author URI. See  http://codex.wordpress.org/Theme_Review#Credit_Links
Fixed
REQUIRED: Make sure that your screenshot doesn't contain any copyrighted images.
It's not a copyrighted image, http://www.flickr.com/photos/indygirl/6217102314/
RECOMMENDED: could not find the file readme.txt in the theme. Please see  Theme_Documentation for more information.
Added
REQUIRED: Long post titles overlap the post content area. See long-title.jpg
Fixed
REQUIRED: Wide images are not resized to fit the post content area . See wide-images.jpg
Fixed ( I dint find the problem)
REQUIRED: Favicons should not be enabled by default. If the user has not opted to have a favicon no image should be displayed.
Fixed
REQUIRED: Check the implementation of editor styles. The theme body background changes the admin background when in the Edit Posts screen. See post-admin-background.jpg
Fixed (its actually a bug with wp 3.3) http://wpdevel.wordpress.com/2011/12/12/use-wp_enqueue_scripts-not-wp_print_styles-to-enqueue-scripts-and-styles-for-the-frontend/
REQUIRED: The 3-column magazine layout doesn't work if "Fluid" layout is selected. See 3-column-fluid.jpg
Fixed
REQUIRED: Check the styling of the footer menu - sub-level menu items are being displayed instead of being visible when you hover over the parent link. See footer-menu.jpg
Added a note in readme file.
REQUIRED: Body background must be implemented using  add_custom_background().
My theme has option to set backgrounds for multiple elements, having all of them on the same page will make it easy for the users.
REQUIRED: Background set under "Sidebar background" is not appearing. See Debugger Errors above.
Fixed
REQUIRED: Background set under "Footer background" is not appearing See Debugger Errors above.
Fixed
REQUIRED: All global variables must be prefixed with the theme slug or an appropriate variant. See $count, $image_repeat, $font_stack, $font_unit, $font_style, $font_weight, $text_transform
Fixed
REQUIRED: Themes are required to use the edit_theme_options capability for add_theme_page().
Fixed
REQUIRED: Themes are required to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you.
My theme uses only three options arrays.
REQUIRED: For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.
Fixed
REQUIRED: Themes are required to use theme-slug as textdomain for translation. Text domain must be swift-basic not swift
Swift basic is limited version of our premium theme Swift, having the same slug will make the maintenance of the translation files easy.
REQUIRED: Missing textdomain in in modified-core-functions.php.
Fixed

New version: http://themes.trac.wordpress.org/ticket/6076

comment:8 in reply to: ↑ 6 garinungkadol2 years ago

Replying to gandham:

REQUIRED: Body background must be implemented using add_custom_background().

My theme has option to set backgrounds for multiple elements of the page, having them on a single page will make it easy for the users.
Can you make an exception?


I will have to run this by the other theme reviewers and get their feedback.

REQUIRED: Themes are required to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you.

I'm only using two options arrays, one for site options and the other for design options.


The theme review requirements are clear on this, only a single array can be used to store options.

There is not enough documentation on set_theme_mod, can you explain what exactly is its purpose?


The use of get_theme_mod/set_theme_mod is one way of including additional options associated with your theme. These functions add custom values to your theme's modification option. The way I see it working would be like this:

   $defaults = mythemeprefix_default_options();
   $current_options = get_theme_mod( 'whatever_this_name_is', $defaults );
   set_theme_mod( 'whatever_this_name_is, $current_options );

You could hook it into after_theme_setup so that it runs when the theme is first activated.

Then whenever you need to call those options you just use:

$mythemeprefix_other_options = get_theme_mod( 'whatever_this_name_is' );

Using this you don't have additional options being saved in the WordPress options table.
You can see http://www.chipbennett.net/2011/02/17/incorporating-the-settings-api-in-wordpress-themes/2/ as another method for setting option defaults.


REQUIRED: Themes are required to use theme-slug as textdomain for translation. Text domain must be swift-basic not swift

Swift basic is limited version of our premium theme Swift, having the same slug will make the maintenance of the translation files easy.


As with the custom background request, I'll bring this up with the other reviewers.

Note: See TracTickets for help on using tickets.