WordPress.org

Make WordPress Themes

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#588 closed theme (not-approved)

THEME: Simplish - 2.4.1

Reported by: themetracbot Owned by: Frumph
Priority: Keywords: theme-simplish,
Cc:

Description

Simplish - 2.4.1

Simplish is a WordPress variant of the Scribbish theme for blogs.

Theme URL - http://simplish.pomfolio.com
Author URL -

SVN - http://themes.svn.wordpress.org/simplish/2.4.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-simplish

Change History (3)

#1 @Frumph
7 years ago

  • Owner set to Frumph
  • Status changed from new to assigned

#2 follow-up: @Frumph
7 years ago

  • Resolution set to not-accepted
  • Status changed from assigned to closed

=> missing body_class();
=> need to add add_theme_support('menus');
=> floats not clearing properly http://codex.wordpress.org/Theme_Unit_Test#Clearing_Floats
=> comments not working on pages http://codex.wordpress.org/Theme_Unit_Test#Page_With_Comments
=> need to use get_template_part(); instead of includes
=> required comment_form(); needs to be used in comments.php

Developer needs to thoroughly read the http://codex.wordpress.org/Theme_Review and find all the must-haves and update their theme(s) accordingly, this theme will continue to not pass until all requirements are met.

Items marked with => are reasons for not being approved
items marked with / are just suggestions

This is a tertiary review, enough items didn't pass; Next reviewer might find more so please do everything you can to adhere to the documentation on what is accepted in the theme review.

To check for notices/warnings/fatal errors, enable define('WP_DEBUG', true); in the wp-config.php

#3 in reply to: ↑ 2 @joshix
7 years ago

Replying to Frumph:

First, thanks for the review. I had not kept up closely enough with changes in the last few wp versions. A question before we resubmit:

=> need to add add_theme_support('menus');

Docs indicate that is redundant in the presence of register_nav_menus().
"This function automatically registers custom menu support for the theme therefore you do not need to call add_theme_support( 'menus' );"
(http://codex.wordpress.org/Function_Reference/register_nav_menus#Notes)
Do the docs need correction?

Note: See TracTickets for help on using tickets.