WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#5927 closed theme (live)

THEME: obandes - 0.78

Reported by: nobita Owned by: greenshady
Priority: Keywords: theme-obandes
Cc: a.tenman@…

Description

obandes - 0.78

This is sidebar width and position changeable 2column html5 theme. You can embed big size photo easy and can get drag and drop view when using post format image. Post format link make a website thumbnail create automatically. And index page have post format group view.Some category has special layout e.g blog , gallery. All of view keep WEB standard. This theme has style sheet editor for background ,color and border. Layout keep clean and not broken when you delete all this textarea. This theme is the one such as palettes and paintbrushes often devised for the artist.

Theme URL - http://www.tenman.info/wp3/obandes/
Author URL - http://www.tenman.info/wp3/

SVN - http://themes.svn.wordpress.org/obandes/0.78
ZIP - http://wordpress.org/extend/themes/download/obandes.0.78.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/obandes/0.76&new_path=/obandes/0.78

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-obandes&order=id

https://themes.svn.wordpress.org/obandes/0.78/screenshot.png

Change History (3)

comment:1 greenshady2 years ago

  • Owner set to greenshady
  • Status changed from new to accepted

comment:2 greenshady2 years ago

I don't see any glaring issues to keep this theme from approval. I didn't do a full review because it was previously approved by other reviewers. The following issues are mostly trivial, but they should be fixed in the next version of this theme.

For now, I'm approving this theme.

Hook into the header

It's better to hook into the header than just dropping everything into header.php. For example, you should hook those inline styles to wp_head.

Wrong function for including stylesheet

get_stylesheet_uri() should be used in this line:

<link rel="stylesheet" type="text/css" media="all" href="<?php echo get_stylesheet_directory_uri().'/style.css'; ?>" />

It should be:

<link rel="stylesheet" type="text/css" media="all" href="<?php echo get_stylesheet_uri(); ?>" />

This makes sure plugins can properly hook into this.

Escaping title attributes

Don't use the_title() as the title attribute in links. Use the_title_attribute():

<h2 class="h2 title"><a href="<?php the_permalink() ?>" rel="bookmark" title="Permanent Link to <?php the_title(); ?>">

Should be:

<h2 class="h2 title"><a href="<?php the_permalink() ?>" rel="bookmark" title="Permanent Link to <?php the_title_attribute(); ?>">

I noticed this in loop.php. It may be present in other templates as well.

get_template_part()

Don't use get_template_part() to load templates in sub-folders. Use locate_template(). You already started it here:

if (function_exists('get_post_format') and locate_template( array( 'formats/format-standard.php' ))){
                    get_template_part( 'formats/format', get_post_format() );
}

A better way to write this would be:

if ( !locate_template( array( 'formats/format-standard.php', 'formats/format.php' ), true ) ) {

	// run your "else" stuff here
}

Or, even better, just call the template instead of checking for it (and remove the if/else statement):

locate_template( array( 'formats/format-standard.php', 'formats/format.php' ), true );

Here's a guide to read about this:
http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes

Review

If you have any questions about the review, please check the Theme Review guidelines or ask in the form below. I'll be happy to help out.
http://codex.wordpress.org/Theme_Review

Note that this is not a complete review. Other theme reviewers may find other issues. Please follow all the notes in the Theme Review guidelines.

comment:3 greenshady2 years ago

  • Resolution set to approved
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.