WordPress.org

Make WordPress Themes

Attachments (1)

Clearing-floats-page.png (33.3 KB) - added by saymar90 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @saymar90
6 years ago

  • Owner set to saymar90
  • Status changed from new to assigned

#2 @saymar90
6 years ago

Suggest

Approved.

Last Review

Debug error

  • Use of undefined constant meta_value - assumed 'meta_value' on line 211 of ..\wp-content\themes\pulsepress\inc\voting.php Fixed

Theme Functionality

  • When we want to display post by most popular, most popular posts should be display first not sticky posts. Fixed
  • When we want to display post by unpopular, less popular posts should be display first not sticky posts. Fixed
  • When we want to display post by most voted-on, most voted posts should be display first not sticky posts. Fixed

Lasts Reviews

Visual issues / functionality / browser checks

  • The Keyboard Shortcut link does not work on Author, Tag, Category or Monthly archives. Fixed

Code Quality

Theme Settings and Data Security
Please see the Theme Review Guidelines for more details.

  • Fixed The reference name for enqueued scripts should be prefixed in inc\js.php should be 'pulsepress_scrollit' and 'pulsepress_wp-locale' instead of:
    Line 83 wp_enqueue_script( 'scrollit', PulsePress_JS_URL .'/jquery.scrollTo-min.js', array( 'jquery' )  );
    Line 85 wp_enqueue_script( 'wp-locale', PulsePress_JS_URL . '/wp-locale.js', array(), 12 );
    

Theme Check Recommended

  • No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' ) in the functions.php file.
  • No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Summary

  • When we want to display post by unpopular, less popular posts should be display first not sticky posts. Fixed

Notes

  • Issues are all mostly quite minor, I'll leave the ticket open for 48 hours. If a revision is submitted that addresses these issues, I will continue the review on the new ticket.
  • Please don't consider the attachment.
Last edited 6 years ago by saymar90 (previous) (diff)

#3 @enej
6 years ago

Hi saymar90

I have tested this to see if the unpopular posts were not ignoring the sticky posts. But that is not the case. Its a bug that was fixed in 1.3.12, can you make sure that when you are testing that the sticky post is also not the last post that was made since the order of post is still chronological. (newest at the top). So it could be that is showing up at the top because the it should be chronologically at the top.

Thanks again so much for your help with the testing.

Cheers Enej

#4 @saymar90
6 years ago

  • Resolution set to approved
  • Status changed from assigned to closed

My bad, I tested again and now it works. Sorry for the inconvenience...

I have edited my first post.

#5 @enej
6 years ago

Hi saymar90

Is there anything I have to do now to get PulsePress on to WordPress.org?
I am sorry I don't know what the whole procedure yet.

Cheers

#6 @saymar90
6 years ago

Hi! Enej

You just have to wait.

Thanks.

#7 @enej
6 years ago

Thanks for everything again!

#8 @saymar90
6 years ago

You are welcome.

Note: See TracTickets for help on using tickets.