WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#6076 closed theme (not-approved)

THEME: Swift Basic - 0.0.2

Reported by: gandham Owned by: garinungkadol
Priority: Keywords: theme-swift-basic, synchold
Cc: satish_g2009@…

Description

Swift Basic - 0.0.2

Swift Basic is the free version of Swift, the fastest loading, developer friendly and most advanced SEO WordPress theme with loads of intutive customization options, giving you infinite number of layouts. It supports all the awesome WordPress features like menus, post types, post formats, you name it and it will be there in Swift.

Theme URL - http://swiftthemes.com/swift-basic/
Author URL - http://SwiftThemes.Com

SVN - http://themes.svn.wordpress.org/swift-basic/0.0.2
ZIP - http://wordpress.org/extend/themes/download/swift-basic.0.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/swift-basic/0.0.1&new_path=/swift-basic/0.0.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-swift-basic&order=id

https://themes.svn.wordpress.org/swift-basic/0.0.2/screenshot.png

Change History (3)

comment:1 garinungkadol2 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

comment:2 garinungkadol2 years ago

RECOMMENDATION: NOT-APPROVED
I'll close this ticket in a couple of days while we wait for feedback on using custom background functions.

ISSUES FROM PREVIOUS REVIEW
Exemption Requests

  • Using 'swift' as text-domain.

-- Unfortunately, you already have a theme in the repository called 'Swift' (http://themes.trac.wordpress.org/ticket/3004) so you cannot use 'swift' as the text domain for Swift Basic. Are these themes related?

  • Using custom background functions

-- I'm still waiting for feedback regarding this.

  • NOT-FIXED: All global variables must be prefixed with the theme slug or an appropriate variant. See $count, $image_repeat, $font_stack, $font_unit, $font_style, $font_weight, $text_transform. See: lib\admin\admin-setup.php, lib\admin\swift-design-options-input.php, author.php, tag.php and index.php
  • NOT-FIXED: For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively. See: lib\admin\swift-design-options-input.php, lib\admin\swift-options-input.php
  • NOT-FIXED: Themes are required to save options in a single array.
  • NOT-FIXED: While the image you are using in your screenshot is not copyrighted. The image's license (Attribution-ShareAlike 2.0 Generic (CC BY-SA 2.0)) is not compatible with GPL. You will need to change the image in your screenshot.
  • PARTIALLY-FIXED: Missing textdomain in modified-core-functions.php
    Line 154: <?php edit_comment_link(__('(Edit)'),'&nbsp;&nbsp;','' );
    
  • PARTIALLY-FIXED: Posts with long titles now have part of the text cut-off. Please note this in the readme.txt. You can see this running this test: http://codex.wordpress.org/Theme_Unit_Test#Post_With_Long_Title.
  • FIXED: Wide images are resized to fit the post content area.
  • FIXED: Favicons are not enabled by default.
  • FIXED: Removed editor style functionality to handle problem with body background appearing on the post admin screen.
  • FIXED: Debugger errors have been fixed
  • FIXED: 3-column Fluid Magazine layout now displays properly
  • FIXED: Added note to readme.txt that footer menu only supports one level of links.
  • FIXED: edit_theme_options is the capability being used for add_theme_page()

comment:3 garinungkadol2 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

Please see this thread on the theme-reviewers mailing list for guidelines on how to implement additional backgrounds: http://lists.wordpress.org/pipermail/theme-reviewers/2011-December/007655.html

Note: See TracTickets for help on using tickets.