WordPress.org

Make WordPress Themes

Attachments (3)

imagetest-overflow.jpeg (66.2 KB) - added by sabreuse 5 years ago.
imagetest-captions.jpeg (97.0 KB) - added by sabreuse 5 years ago.
pagefooter.png (23.9 KB) - added by sabreuse 5 years ago.

Download all attachments as: .zip

Change History (7)

#1 @sabreuse
5 years ago

  • Owner set to sabreuse
  • Status changed from new to assigned

@sabreuse
5 years ago

#2 @sabreuse
5 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS

This is a complete review. Below are the theme review results. Anything marked FAIL needs to be addressed. Anything marked RECOMMENDED is strongly advised. Other points may be raised purely for information.

OVERALL REVIEW: NOT-APPROVED


Previous reviews: FIXED

The code quality issue reported in the previous review has been corrected.

Theme-Check: PASS

I've listed the output from Theme-Check below for your reference. Note that none of these is required, as your design doesn't use thumbnails, header image, or menu.

RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' )in the functions.php file.
RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
INFO: At least one hard coded date was found in the file archive.php. Consider get_option( 'date_format' )

Regarding the editor styling recommendation, your theme includes an editor-style.css file, but it's blank, and anyway you never actually call it. If you want to add support for editor styling, you'll need to build out the stylesheet and then enable it in functions.php with add_editor_style() -- you can look at twentyeleven for an example of how to do it. Otherwise, it would be better to leave out the blank stylesheet.

Unit tests: FAIL

Whenever images have captions, the text in the surrounding block is incorrectly resized. See screenshot.

Oversized images overflow the content area of the post. See screenshot.

On pages, but not posts, the footer text is significantly larger than the page text. See screenshot.


You are encouraged to resubmit your theme once the errors have been corrected. If you have any questions, please feel free to leave a comment on this ticket, or contact the theme-reviewers email list.

#3 @hellweaver666
5 years ago

Hi Sabreuse,

As requested, problems fixed and new version uploaded here:

http://themes.trac.wordpress.org/ticket/6172

I've removed the editor-style.css for now, but will work to bring it back in the near future.

Andy

#4 @hellweaver666
5 years ago

Hi Sabreuse,

This theme seems to have disappeared into the ether, I can't find it in any of the queues. I made the requested changes but nobody seems to have picked it up for review. Any chance you could take a look?

http://themes.trac.wordpress.org/ticket/6172

Thanks a ton!

Andy

Note: See TracTickets for help on using tickets.