WordPress.org

Make WordPress Themes

Attachments (4)

menu1.jpg (29.7 KB) - added by sixhours 6 years ago.
menu2.jpg (14.6 KB) - added by sixhours 6 years ago.
floats.jpg (45.6 KB) - added by sixhours 6 years ago.
headerimageadmin.jpg (61.7 KB) - added by sixhours 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @sixhours
6 years ago

  • Owner set to sixhours
  • Status changed from new to assigned

@sixhours
6 years ago

@sixhours
6 years ago

@sixhours
6 years ago

#2 @sixhours
6 years ago

  • Status changed from assigned to accepted

Thanks for submitting your theme! Please post any comments or questions on this ticket. If you can address these fixes within the next 2 days and post a link to the revised theme's trac ticket here, I will be happy to follow up and mark as approved.


Resolution: Not Approved until the following issues are fixed:

Use get_template_directory() instead of TEMPLATEPATH in functions.php

Pages should not display "Comments are closed" notice (nothing should be displayed on pages)

Navigation menu and custom menu sidebar widget formatting looks off (see attached screencaps menu1 and menu2)… can't tell if this is intentional design or not (guessing not?)

There's a navigation menu area defined in the header (Header Menu) but applying a custom menu there doesn't work (always defaults to the page list.)

Floats aren't clearing pagination links properly on posts (see attached screencap floats.jpg)

Google font should be enqueued via a function with wp_enqueue_script rather than manually linked in header.php

Header image preview in the administration area overlaps text (see attached screencap headerimageadmin.jpg)


Minor issues (may fix in a future release):

searchform.php calls a different theme's text domain:

<?php esc_attr_e( 'Search', 'olyphantly' ); ?>

Some theme files are translation-ready, others are not. If you intend to make your theme translatable it would be good to standardize this in a future release.

#3 @themesweet
6 years ago

Hi!

Thanks so much for the feedback. I've uploaded a new version with your changes taken into account. Here's the link: http://themes.trac.wordpress.org/ticket/6329

I had a heck of a time with the admin header image styling so I just put some more space on the bottom. I hope this is okay.

Thanks so much for reviewing and hope you're enjoying your day!

#4 @sixhours
6 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.